From bad14de1e2702748fee340caa77caaa4305abb11 Mon Sep 17 00:00:00 2001 From: Jake Hillion Date: Fri, 30 Dec 2022 22:41:09 +0000 Subject: [PATCH] add issue references to every skipped test --- test/integration/anonymous.toml | 2 +- test/integration/pointers.toml | 20 ++++++++++---------- test/integration/pointers_function.toml | 12 ++++++------ test/integration/pointers_incomplete.toml | 6 +++--- test/integration/references.toml | 4 ++-- test/integration/std_unordered_map.toml | 2 +- test/integration/std_vector.toml | 4 ++-- 7 files changed, 25 insertions(+), 25 deletions(-) diff --git a/test/integration/anonymous.toml b/test/integration/anonymous.toml index 46c83c9..fbf74dc 100644 --- a/test/integration/anonymous.toml +++ b/test/integration/anonymous.toml @@ -133,7 +133,7 @@ definitions = ''' }]''' [cases.anon_struct_ptr] - skip = "We don't support pointer to anon-structs yet" + skip = "We don't support pointer to anon-structs yet" # https://github.com/facebookexperimental/object-introspection/issues/20 param_types = ["const AnonStructPtrContainer&"] setup = ''' return AnonStructPtrContainer{ diff --git a/test/integration/pointers.toml b/test/integration/pointers.toml index c388a8a..ef4f7af 100644 --- a/test/integration/pointers.toml +++ b/test/integration/pointers.toml @@ -14,7 +14,7 @@ definitions = ''' [cases] [cases.int] - oid_skip = "top-level pointers are skipped over" + oid_skip = "top-level pointers are skipped over" # https://github.com/facebookexperimental/object-introspection/issues/19 oil_disable = "oil can't chase raw pointers safely" param_types = ["int*"] setup = "return new int(1);" @@ -33,7 +33,7 @@ definitions = ''' ] }]''' [cases.int_no_follow] - oid_skip = "top-level pointers are skipped over" + oid_skip = "top-level pointers are skipped over" # https://github.com/facebookexperimental/object-introspection/issues/19 param_types = ["int*"] setup = "return new int(1);" expect_json = '''[{ @@ -44,7 +44,7 @@ definitions = ''' "NOT": "members" }]''' [cases.int_null] - oid_skip = "top-level pointers are skipped over" + oid_skip = "top-level pointers are skipped over" # https://github.com/facebookexperimental/object-introspection/issues/19 param_types = ["int*"] setup = "return nullptr;" expect_json = '''[{ @@ -57,7 +57,7 @@ definitions = ''' [cases.void] - oid_skip = "top-level pointers are skipped over" + oid_skip = "top-level pointers are skipped over" # https://github.com/facebookexperimental/object-introspection/issues/19 oil_disable = "oil can't chase raw pointers safely" param_types = ["void*"] setup = "return new int(1);" @@ -70,7 +70,7 @@ definitions = ''' "NOT": "members" }]''' [cases.void_no_follow] - oid_skip = "top-level pointers are skipped over" + oid_skip = "top-level pointers are skipped over" # https://github.com/facebookexperimental/object-introspection/issues/19 param_types = ["void*"] setup = "return new int(1);" expect_json = '''[{ @@ -81,7 +81,7 @@ definitions = ''' "NOT": "members" }]''' [cases.void_null] - oid_skip = "top-level pointers are skipped over" + oid_skip = "top-level pointers are skipped over" # https://github.com/facebookexperimental/object-introspection/issues/19 param_types = ["void*"] setup = "return nullptr;" expect_json = '''[{ @@ -94,7 +94,7 @@ definitions = ''' [cases.vector] - oid_skip = "top-level pointers are skipped over" + oid_skip = "top-level pointers are skipped over" # https://github.com/facebookexperimental/object-introspection/issues/19 oil_disable = "oil can't chase raw pointers safely" param_types = ["std::vector*"] setup = "return new std::vector{1,2,3};" @@ -113,7 +113,7 @@ definitions = ''' ] }]''' [cases.vector_no_follow] - oid_skip = "top-level pointers are skipped over" + oid_skip = "top-level pointers are skipped over" # https://github.com/facebookexperimental/object-introspection/issues/19 param_types = ["std::vector*"] setup = "return new std::vector{1,2,3};" expect_json = '''[{ @@ -124,7 +124,7 @@ definitions = ''' "NOT": "members" }]''' [cases.vector_null] - oid_skip = "BAD DATA SEGMENT!!! top-level pointers are skipped over" + oid_skip = "BAD DATA SEGMENT!!! top-level pointers are skipped over" # https://github.com/facebookexperimental/object-introspection/issues/19 param_types = ["std::vector*"] setup = "return nullptr;" expect_json = '''[{ @@ -223,7 +223,7 @@ definitions = ''' {"staticSize":8, "dynamicSize":4, "NOT": {"pointer":0}} ]}]''' [cases.vector_of_pointers_no_follow] - oid_skip = "pointer field is missing from results" + oid_skip = "pointer field is missing from results" # https://github.com/facebookexperimental/object-introspection/issues/21 param_types = ["const std::vector&"] setup = "return {{new int(1), nullptr, new int(3)}};" expect_json = '''[{ diff --git a/test/integration/pointers_function.toml b/test/integration/pointers_function.toml index b6e5181..f012e1a 100644 --- a/test/integration/pointers_function.toml +++ b/test/integration/pointers_function.toml @@ -14,7 +14,7 @@ definitions = ''' [cases] [cases.raw] - oid_skip = "function pointers are not handled correctly" + oid_skip = "function pointers are not handled correctly" # https://github.com/facebookexperimental/object-introspection/issues/22 param_types = ["const FuncPtrStruct&"] setup = "return {{myFunction}};" expect_json = '''[{ @@ -29,7 +29,7 @@ definitions = ''' }] }]''' [cases.raw_chase] # We should never chase function pointers - oid_skip = "function pointers are not handled correctly" + oid_skip = "function pointers are not handled correctly" # https://github.com/facebookexperimental/object-introspection/issues/22 oil_disable = "oil can't chase raw pointers safely" param_types = ["const FuncPtrStruct&"] setup = "return {{myFunction}};" @@ -46,7 +46,7 @@ definitions = ''' }] }]''' [cases.raw_null] - oid_skip = "function pointers are not handled correctly" + oid_skip = "function pointers are not handled correctly" # https://github.com/facebookexperimental/object-introspection/issues/22 param_types = ["const FuncPtrStruct&"] setup = "return {{nullptr}};" expect_json = '''[{ @@ -62,7 +62,7 @@ definitions = ''' }]''' [cases.std_function] - oid_skip = "function pointers are not handled correctly" + oid_skip = "function pointers are not handled correctly" # https://github.com/facebookexperimental/object-introspection/issues/22 param_types = ["std::function &"] setup = "return myFunction;" expect_json = '''[{ @@ -73,7 +73,7 @@ definitions = ''' "NOT": "members" }]''' [cases.std_function_chase] # We should never chase function pointers - oid_skip = "function pointers are not handled correctly" + oid_skip = "function pointers are not handled correctly" # https://github.com/facebookexperimental/object-introspection/issues/22 oil_disable = "oil can't chase raw pointers safely" param_types = ["std::function &"] setup = "return myFunction;" @@ -86,7 +86,7 @@ definitions = ''' "NOT": "members" }]''' [cases.std_function_null] - oid_skip = "function pointers are not handled correctly" + oid_skip = "function pointers are not handled correctly" # https://github.com/facebookexperimental/object-introspection/issues/22 param_types = ["std::function &"] setup = "return nullptr;" expect_json = '''[{ diff --git a/test/integration/pointers_incomplete.toml b/test/integration/pointers_incomplete.toml index 26500ab..bc2bbe9 100644 --- a/test/integration/pointers_incomplete.toml +++ b/test/integration/pointers_incomplete.toml @@ -20,7 +20,7 @@ definitions = ''' [cases] [cases.raw] oil_disable = "oil can't chase raw pointers safely" - oid_skip = "oid codegen fails on this" + oid_skip = "oid codegen fails on this" # https://github.com/facebookexperimental/object-introspection/issues/17 param_types = ["IncompleteType*"] setup = "return static_cast(::operator new(5));" cli_options = ["--chase-raw-pointers"] @@ -32,7 +32,7 @@ definitions = ''' "NOT": "members" }]''' [cases.raw_no_follow] - oid_skip = "oid codegen fails on this" + oid_skip = "oid codegen fails on this" # https://github.com/facebookexperimental/object-introspection/issues/17 param_types = ["IncompleteType*"] setup = "return static_cast(::operator new(5));" expect_json = '''[{ @@ -43,7 +43,7 @@ definitions = ''' "NOT": "members" }]''' [cases.raw_null] - oid_skip = "oid codegen fails on this" + oid_skip = "oid codegen fails on this" # https://github.com/facebookexperimental/object-introspection/issues/17 param_types = ["IncompleteType*"] setup = "return nullptr;" expect_json = '''[{ diff --git a/test/integration/references.toml b/test/integration/references.toml index d989919..e4613ad 100644 --- a/test/integration/references.toml +++ b/test/integration/references.toml @@ -9,7 +9,7 @@ definitions = ''' ''' [cases] [cases.int_ref] - skip = "references are being treated as raw pointers" + skip = "references are being treated as raw pointers" # https://github.com/facebookexperimental/object-introspection/issues/16 param_types = ["const IntRef&"] setup = "return {{*new int(1)}};" expect_json = '''[{ @@ -24,7 +24,7 @@ definitions = ''' } ]}]''' [cases.vector_ref] - skip = "references are being treated as raw pointers" + skip = "references are being treated as raw pointers" # https://github.com/facebookexperimental/object-introspection/issues/16 param_types = ["const VectorRef&"] setup = "return {{*new std::vector{1,2,3}}};" expect_json = '''[{ diff --git a/test/integration/std_unordered_map.toml b/test/integration/std_unordered_map.toml index d4ce073..4a97e98 100644 --- a/test/integration/std_unordered_map.toml +++ b/test/integration/std_unordered_map.toml @@ -1,7 +1,7 @@ includes = ["unordered_map"] [cases] [cases.int_int] - skip = true + skip = true # https://github.com/facebookexperimental/object-introspection/issues/15 param_types = ["const std::unordered_map&"] setup = "return {{{1,2},{3,4}}};" # TODO confirm this JSON is correct diff --git a/test/integration/std_vector.toml b/test/integration/std_vector.toml index 316e2c6..b6e59ba 100644 --- a/test/integration/std_vector.toml +++ b/test/integration/std_vector.toml @@ -9,12 +9,12 @@ includes = ["vector"] setup = "return {{1,2,3}};" expect_json = '[{"staticSize":24, "dynamicSize":12, "length":3, "capacity":3, "elementStaticSize":4}]' [cases.bool_empty] - skip = true + skip = true # https://github.com/facebookexperimental/object-introspection/issues/14 param_types = ["const std::vector&"] setup = "return {};" expect_json = '[{"staticSize":40, "dynamicSize":0, "length":0, "capacity":0, "elementStaticSize":0.125}]' [cases.bool_some] - skip = true + skip = true # https://github.com/facebookexperimental/object-introspection/issues/14 param_types = ["const std::vector&"] setup = "return {{true, false, true}};" expect_json = '[{"staticSize":40,"dynamicSize":8, "length":3, "capacity":64, "elementStaticSize":0.125}]'