JakeHillion/object-introspection
1
0
Fork 0
mirror of https://github.com/JakeHillion/object-introspection.git synced 2024-12-23 05:43:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

TypeGraph: Set alignment for Thrift isset container to 1

Browse Source
This commit is contained in:
Alastair Robertson 2023-08-01 06:33:59 -07:00 committed by Alastair Robertson
parent 79d1d55b03
commit 6d30015764
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
oi/type_graph/Types.h
View File

@ -300,7 +300,20 @@ class Container : public Type {
}
virtual uint64_t align() const override {
return 8; // TODO not needed for containers?
// XXX Big hack!
// We can not assume that all containers have 8-byte alignment. However, to
// properly calculate alignment would require significant refactoring of
// the container identification code:
// - DrgnParser needs to return Class objects instead of Containers
// - They must be flattened
// - We must calculate alignment based on their members
// - Then we are able to convert them into Container objects
//
// As a quick, hopefully temporary solution, hardcode some known container
// alignments here
if (containerInfo_.ctype == THRIFT_ISSET_TYPE)
return 1;
return 8;
}
virtual NodeId id() const override {