JakeHillion/object-introspection
1
0
Fork 0
mirror of https://github.com/JakeHillion/object-introspection.git synced 2024-09-19 11:09:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

Correct offset calculation with multiple base classes (#494)

Browse Source 
If a class inherits from more than one base class Clang Parser currently
calculates incorrect offsets for everything but the first base class.
This is owing to the fact that TypeGraph needs offsets in bits but
ClangParser is providing them in bytes.
This commit is contained in:
Jon Haslam 2024-04-23 14:31:16 +01:00 committed by GitHub
parent 472a7366ee
commit 479545d4b8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
oi/type_graph/ClangTypeParser.cpp
View File

@ -335,7 +335,8 @@ void ClangTypeParser::enumerateClassParents(const clang::RecordType& ty,
if (baseCxxDecl == nullptr) if (baseCxxDecl == nullptr)
continue; continue;
auto offset = layout.getBaseClassOffset(baseCxxDecl).getQuantity(); auto offset =
layout.getBaseClassOffset(baseCxxDecl).getQuantity() * CHAR_BIT;
auto& ptype = enumerateType(*baseType); auto& ptype = enumerateType(*baseType);
parents.emplace_back(Parent{ptype, static_cast<uint64_t>(offset)}); parents.emplace_back(Parent{ptype, static_cast<uint64_t>(offset)});
} }