nixpkgs/pkgs/development/python-modules/pre-commit/default.nix
Wael Nasreddine 1882d20155
pre-commit: installed git hook should have full path to binary (#77638)
pre-commit currently install impure Git hooks that look for the
`pre-commit` binary in PATH. If the user has `pre-commit` loaded via a
nix-shell instead of having it installed then GUI editors, such as
Intellij, won't be able to use Git commit because the hook fails trying
to look for the `pre-commit` binary in PATH.

This patch updates the hook template to use the hardcoded path to the
`pre-commit` binary if it was found, fallback to using the one from
PATH.
2020-02-01 10:05:42 -08:00

58 lines
1.2 KiB
Nix

{ lib, fetchPypi, buildPythonApplication, pythonOlder
, aspy-yaml
, cached-property
, cfgv
, futures
, identify
, importlib-metadata
, importlib-resources
, nodeenv
, python
, six
, toml
, virtualenv
}:
buildPythonApplication rec {
pname = "pre-commit";
version = "1.21.0";
src = fetchPypi {
inherit version;
pname = "pre_commit";
sha256 = "0l5qg1cw4a0670m96s0ryy5mqz5aslfrrnwpriqgmrnsgdixhj4g";
};
patches = [
./hook-tmpl-use-the-hardcoded-path-to-pre-commit.patch
];
propagatedBuildInputs = [
aspy-yaml
cached-property
cfgv
identify
nodeenv
six
toml
virtualenv
importlib-metadata
] ++ lib.optional (pythonOlder "3.7") importlib-resources
++ lib.optional (pythonOlder "3.2") futures;
# slow and impure
doCheck = false;
preFixup = ''
substituteInPlace $out/${python.sitePackages}/pre_commit/resources/hook-tmpl \
--subst-var-by pre-commit $out
'';
meta = with lib; {
description = "A framework for managing and maintaining multi-language pre-commit hooks";
homepage = https://pre-commit.com/;
license = licenses.mit;
maintainers = with maintainers; [ borisbabic ];
};
}