JakeHillion/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
364,736 Commits 1 Branch 0 Tags 12 GiB
e5bf0233a8
Commit Graph

5 Commits

Author SHA1 Message Date
Axel Forsman
96e9be097b gbsplay: 2016-12-17 -> 0.0.94 
Add the "nas" output plugin. Remove configure flags since those should
get detected automatically. Install bash completions. Format through
nixpkgs-fmt.
 2021-06-13 14:37:18 +02:00
Profpatsch
4a7f99d55d treewide: with stdenv.lib; in meta -> with lib; 
Part of: https://github.com/NixOS/nixpkgs/issues/108938

meta = with stdenv.lib;

is a widely used pattern. We want to slowly remove
the `stdenv.lib` indirection and encourage people
to use `lib` directly. Thus let’s start with the meta
field.

This used a rewriting script to mostly automatically
replace all occurances of this pattern, and add the
`lib` argument to the package header if it doesn’t
exist yet.

The script in its current form is available at
https://cs.tvl.fyi/depot@2f807d7f141068d2d60676a89213eaa5353ca6e0/-/blob/users/Profpatsch/nixpkgs-rewriter/default.nix
 2021-01-11 10:38:22 +01:00
Greg Price
45a04ed6d4 gbsplay: fix configure flags 
This caused none of these flags to have any effect.  That's because
the configure command looked like this:

    ./configure --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 \
        --without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n

with one giant flag '--without-test --without-contrib...', containing
internal spaces.

This can be seen in `nix log nixpkgs.gbsplay`, in this line:

    configure flags: --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 --without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n

and then in the fact that features like "devdsp" and "midi" are listed
as enabled in later output, and source files like plugout_midi.c are
included in the build.

I don't have a real opinion on whether it's better to have these flags
or not, but it's clear the author's intention was to pass them.  So,
fix the attr name so they get passed.
 2020-04-21 07:51:55 +02:00
Christoph-Simon Senjak
c84c720631 fixing gbsplay/default.nix 2017-01-26 00:41:54 +01:00
Christoph-Simon Senjak
74e6aa7de6 gbsplay: init at version 2016-12-17 2017-01-25 21:59:27 +01:00