Whenever we create scripts that are installed to $out, we must use runtimeShell
in order to get the shell that can be executed on the machine we create the
package for. This is relevant for cross-compiling. The only use case for
stdenv.shell are scripts that are executed as part of the build system.
Usages in checkPhase are borderline however to decrease the likelyhood
of people copying the wrong examples, I decided to use runtimeShell as well.
Added better practices to update_exts script.
Use `jq` instead of `grep` for more reliable JSON querying.
Check for 404 when requesting package.json information to avoid mangled
output.
Added proper failure points for missing vscode package, unknown version,
and if the code executable couldn't be found.
Switched to using a `nix-shell` shebang for even better reliability and
use the `sh` shell to be that little bit more generic.
Script is still clunky and sequential, anything more and I'd need to
write a proper program to do this and that's getting a bit silly? But
people that have a dozen or so extensions might be in for a long wait.
Be explicit about using bash
Improve the use of jq to remove unnecessary use of tr. Hat-tip coretemp.
Add some comments, finally.
Remove the `fetch` function.
Change the `get_ver` function to more accurately demonstrate what it is trying
to do, as well as add in some better error handling for non-200 http responses.
I couldn't make the bash `${param/search/replacement}` work for chopping up the
response in the `get_ver` function, hence the use of `sed`. Hopefully it all
makes a bit more sense now.
Remove github requests.
VSIXPackage is just a zip format in disguise so use a tmpdir and unpackage the
package.json file for the file in question so we can get the precise version
that we're interested in without additional redundant calls to github that may
not provide the right answer anyway.
Add trap to try to clean up the temp folders and clean up as we go.
I can't use 'fetchurl' or even 'nix-prefetch-url' because for the former we
don't yet know the hash that we're after and for the latter there isn't a way to
tie the predownloaded file into the next part of the workflow.
Prevent an unnecessary file from being extracted.
Change the unzip command to read the file we're after to stdout so we can use jq
on it directly instead of creating a file, reading it, then deleting it.
Courtesy of worldofpeace, remove the dependency on coreutils and use the
provided nix-hash function to generate the required hash.
Fix up a comment
Remove use of 'awk' and clean up individual Nix printing with cat to EOF expression.
- Now simply let the default `unpackPhase` unzip the vsix file. This
should allow users to retrieve the extension directly from github.
- Extensions now installed using their unique id as install folder.
- Extensions under `vscode-extensions` now use the unique id
as extension name.
