JakeHillion/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
232,129 Commits 2 Branches 0 Tags 13 GiB
be2f095ceb
Commit Graph

3588 Commits

Author SHA1 Message Date
Michael Weiss
cdd95a9625
chromium: 81.0.4044.138 -> 83.0.4103.61 
https://chromereleases.googleblog.com/2020/05/stable-channel-update-for-desktop_19.html

This update includes 38 security fixes.

CVEs:
CVE-2020-6465 CVE-2020-6466 CVE-2020-6467 CVE-2020-6468 CVE-2020-6469
CVE-2020-6470 CVE-2020-6471 CVE-2020-6472 CVE-2020-6473 CVE-2020-6474
CVE-2020-6475 CVE-2020-6476 CVE-2020-6477 CVE-2020-6478 CVE-2020-6479
CVE-2020-6480 CVE-2020-6481 CVE-2020-6482 CVE-2020-6483 CVE-2020-6484
CVE-2020-6485 CVE-2020-6486 CVE-2020-6487 CVE-2020-6488 CVE-2020-6489
CVE-2020-6490 CVE-2020-6491
 2020-05-19 23:55:32 +02:00
DonHugo69
20b3ba16c4
vivaldi: 2.11 -> 3.0 2020-05-19 14:51:20 +02:00
adisbladis
b3f79e194a
firefox-devedition-bin: 77.0b6 -> 77.0b7 2020-05-19 02:07:38 +01:00
adisbladis
aac358315f
firefox-beta-bin: 77.0b6 -> 77.0b7 2020-05-19 02:07:38 +01:00
squalus
fda9c39559 ungoogled-chromium: 81.0.4044.122-2 -> 81.0.4044.138-1 2020-05-18 01:01:19 -07:00
adisbladis
80a4efc3bd
firefox-devedition-bin: 76.0b8 -> 77.0b6 2020-05-16 14:08:19 +01:00
adisbladis
198653e57e
firefox-beta-bin: 76.0b8 -> 77.0b6 2020-05-16 14:07:56 +01:00
Andreas Rammhold
b0774e2d0e
Merge pull request #87811 from andir/firefox 
firefox: 76.0 -> 76.0.1
 2020-05-15 20:21:24 +02:00
Christoph Neidahl
5262ada436 palemoon: 28.9.1 -> 28.9.3 2020-05-15 09:06:54 +02:00
Mario Rodas
b51a82932f
Merge pull request #87733 from taku0/flashplayer-32.0.0.371 
flashplayer: 32.0.0.363 -> 32.0.0.371
 2020-05-14 08:05:29 -05:00
Andreas Rammhold
b70435e43c
firefox: 76.0 -> 76.0.1 2020-05-14 12:50:34 +02:00
aszlig
8fb49973ce
firefox: Add patch to fix AES GCM IV bit size 
Regression introduced by bce5268a21.

The bit size of the initialisation vector for AES GCM has been
introduced in NSS version 3.52 in the CK_GCM_PARMS struct via the
ulIvBits field.

Unfortunately, Firefox 68.8.0 and 76.0 do not set this field and thus it
gets initialised to zero, which in turn causes IV generation to fail.

I found out about this because WebRTC stopped working after updating to
NSS 3.52 and so I started bisecting.

Since there wasn't an obvious error in Firefox hinting towards NSS but
instead just the video stream ended up as a "null" stream, I didn't
suspect the NSS update to be the culprit at first. So I verified a few
times and then also started bisecting the actual commit in NSS that
caused the issue.

This turned out to be the problematic change:

https://phabricator.services.mozilla.com/D63241

> One notable change was caused by an inconsistancy between the spec and
> the released headers in PKCS#11 v2.40. CK_GCM_PARAMS had an extra
> field in the header that was not in the spec. OASIS considers the
> header file to be normative, so PKCS#11 v3.0 resolved the issue in
> favor of the header file definition.

Since the test I've used[1] was a bit flaky, I still didn't believe the
result of the bisect to be accurate, but after running the test several
times leading same results I dug through the above change line by line
to get more clues.

It fortunately didn't take that long to stumble upon the ulIvBits change
(which is actually documented in the NSS 3.52 release notes[4], but I
managed to blatantly ignore it for some reason) and started checking the
Firefox source tree for changes regarding that field.

Initialisation of that new field has been introduced[2] in preparation
for the 76 release, but subsequently got reverted[3] prior to the
release, because Firefox 76 is expected to be shipped with NSS 3.51,
which didn't have the ulIvBits field.

The patch I'm adding here is just a reintroduction of that change,
because we're using NSS 3.52. Not initialising that field will break
WebRTC and WebCrypto, which I think the former seems to gain in
popularity these days ;-)

Tested the change against the mentioned VM test[1] and also by testing
manually using Jitsi Meet and Nextcloud Talk.

[1]: https://github.com/aszlig/avonc/tree/884315838b6f0ebb32b/tests/talk
[2]: https://hg.mozilla.org/mozilla-central/rev/3ed30e6b6de1
[3]: https://hg.mozilla.org/mozilla-central/rev/665137da70ee
[4]: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.52_release_notes

Signed-off-by: aszlig <aszlig@nix.build>
 2020-05-13 02:23:12 +02:00
Robert Schütz
52fcfd3876 qutebrowser: 1.11.0 -> 1.11.1 
fixes CVE-2020-11054
 2020-05-12 18:46:09 +02:00
taku0
d8fa222ca2 flashplayer: 32.0.0.363 -> 32.0.0.371 2020-05-12 18:31:02 +09:00
xiorcale
ccfe14cb3b github username: kjuvi -> xiorcale 2020-05-09 09:08:18 +02:00
Christian Mainka
e659bf3ce4 brave: 1.7.92 -> 1.8.95 2020-05-08 18:16:17 +02:00
Pavol Rusnak
6abf4a43ad
treewide: per RFC45, remove more unquoted URLs 2020-05-08 15:20:47 +02:00
Vladimír Čunát
a2d5351b63
Merge #86788: firefox 75.0 -> 76.0 (critical security) 
https://www.mozilla.org/en-US/firefox/76.0/releasenotes/
Some of the changes were in master already, but whatever...
 2020-05-07 19:57:16 +02:00
Tim Steinbach
795564a03d
Merge pull request #81997 from eadwu/vivaldi-snapshot/fix-rpath-libdrm_gbm 
vivaldi: include libdrm and libgbm
 2020-05-07 08:17:27 -04:00
Michael Weiss
f00f6a73df
Merge pull request #87021 from primeos/chromium 
chromium: 81.0.4044.129 -> 81.0.4044.138
 2020-05-06 13:01:58 +02:00
Andreas Rammhold
5040192913
firefox-bin: 75.0 -> 76.0 
Discussion: https://github.com/NixOS/nixpkgs/pull/86788
 2020-05-06 11:41:38 +02:00
Andreas Rammhold
5bac4f0213
firefox-esr-68: 68.7.0esr -> 68.8.0esr 
Discussion: https://github.com/NixOS/nixpkgs/pull/86788
 2020-05-06 11:40:28 +02:00
Michael Weiss
dec3d5f39f
chromium: 81.0.4044.129 -> 81.0.4044.138 
https://chromereleases.googleblog.com/2020/05/stable-channel-update-for-desktop.html

This update includes 3 security fixes.

CVEs: CVE-2020-6831 CVE-2020-6464
 2020-05-06 01:11:53 +02:00
Andreas Rammhold
d9f4f0645c
Merge pull request #81917 from colemickens/nixpkgs-firefox-libva 
firefox: wrapper: add libva to libs
 2020-05-05 20:21:43 +02:00
Andreas Rammhold
8996273bee
firefox-devedition-bin: 76.0b4 -> 76.0b8 2020-05-04 17:46:12 +02:00
Andreas Rammhold
f3cc8dc6fa
firefox-esr-68: 68.7.0esr -> 68.8.0esr 2020-05-04 17:29:37 +02:00
Andreas Rammhold
c186bc893f
firefox-beta-bin: 76.0b4 -> 76.0b8 2020-05-04 17:29:14 +02:00
Andreas Rammhold
3911336cc6
firefox-bin: 75.0 -> 76.0 2020-05-04 17:22:59 +02:00
Andreas Rammhold
324e40f0f4
firefox: 75.0 -> 76.0 2020-05-04 16:31:27 +02:00
R. RyanTM
5be4c34185 ephemeral: 6.3.3 -> 6.4.1 2020-05-04 01:34:33 -07:00
paumr
4a5b85364e qutebrowser: 1.10.1 -> 1.11.0 2020-05-01 16:44:31 +02:00
squalus
ae5c4ed886 ungoogled-chromium: 81.0.4044.92-2 -> 81.0.4044.122-2 2020-05-01 09:19:53 +02:00
Michael Weiss
bfa2452dc8
Merge pull request #86206 from primeos/chromium 
chromium: 81.0.4044.122 -> 81.0.4044.129
 2020-04-29 11:15:25 +02:00
Michael Weiss
db4aece884
chromium: 81.0.4044.122 -> 81.0.4044.129 
https://chromereleases.googleblog.com/2020/04/stable-channel-update-for-desktop_27.html

This update includes 2 security fixes.

CVEs: CVE-2020-6462 CVE-2020-6461
 2020-04-28 14:39:10 +02:00
Christoph Neidahl
1e814e356a palemoon: 28.8.4 -> 28.9.1, add GTK3 option 2020-04-27 21:02:09 -07:00
Cole Mickens
552d729571
firefox: wrapper: use ffmpeg_4 for vaapi 
without this, adding libva is insufficient to get VA-API working in
Firefox.
 2020-04-27 05:05:14 -07:00
Cole Mickens
730d542ae0
firefox: wrapper: add libva to libs 2020-04-27 03:48:33 -07:00
worldofpeace
b4d7725cfe
Merge pull request #76082 from squalus/ungoogled 
ungoogled-chromium: init at 81.0.4044.92-2
 2020-04-23 21:03:18 -04:00
Michael Weiss
a2df9776f0
chromium: 81.0.4044.113 -> 81.0.4044.122 
https://chromereleases.googleblog.com/2020/04/stable-channel-update-for-desktop_21.html

This update includes 8 security fixes.

CVEs: CVE-2020-6459 CVE-2020-6460 CVE-2020-645
 2020-04-22 01:20:32 +02:00
worldofpeace
b0631dc3de
Merge pull request #85469 from JeffLabonte/brave_1_5_123-1_7_92 
brave: 1.5.123 -> 1.7.92
 2020-04-20 08:04:46 -04:00
worldofpeace
443e544721 firefox-wrapper: don't throw on enableGnomeExtensions 
We use the config for the native messaging host below this statement.
 2020-04-18 20:36:55 -04:00
taku0
f63bc540cb flashplayer: 32.0.0.344 -> 32.0.0.363 2020-04-18 23:08:58 +02:00
Michael Weiss
267eefcdb7
chromium: Build with VA-API but disable it by default 
This makes it possible to enable VA-API without having to rebuild
Chromium: `chromium.override { enableVaapi = true; }`
 2020-04-18 13:46:22 +02:00
John Ericson
eb4acb6ca9
Merge pull request #85468 from Ericson2314/no-dumpmachine 
treewide: Get rid of -dumpmachine in favor of static info
 2020-04-18 00:35:19 -04:00
Jeff Labonte
094c35b920 brave: 1.5.123 -> 1.7.92 2020-04-17 19:50:17 -04:00
Michael Weiss
cb5c0a4bbc
chromium{Beta,Dev}: M81 -> M83 -> M84 2020-04-17 13:44:45 +02:00
Linus Heckemann
6b23355abb
Merge pull request #85307 from xaverdh/firefox-plugins-cleanup 
firefox-wrapper: remove dead npapi plugin code
 2020-04-17 07:32:41 +02:00
Dominik Xaver Hörl
c415d67284 mozilla-plugins: remove all npapi plugins except for flash player 
Firefox from version 52 onwards no longer supports npapi plugins (see https://support.mozilla.org/en-US/kb/npapi-plugins).
 2020-04-16 23:04:51 +02:00
Michael Weiss
6109f94f8a
Merge pull request #85360 from primeos/chromium 
chromium: 81.0.4044.92 -> 81.0.4044.113
 2020-04-16 22:33:45 +02:00
Michael Weiss
16477d764f
google-chrome-{beta,dev}: Fix one substituteInPlace pattern 2020-04-16 13:39:07 +02:00
Michael Weiss
ef2c3ab20e
chromium: 81.0.4044.92 -> 81.0.4044.113 
https://chromereleases.googleblog.com/2020/04/stable-channel-update-for-desktop_15.html

This update includes 1 security fix.

CVEs: CVE-2020-6457
 2020-04-16 10:53:53 +02:00
Dominik Xaver Hörl
c51b0afd54 firefox-wrapper: remove dead npapi plugin code 2020-04-16 10:12:09 +02:00
worldofpeace
c3408adb7d ephemeral: 6.3.1 -> 6.3.3 
https://github.com/cassidyjames/ephemeral/releases/tag/6.3.2
https://github.com/cassidyjames/ephemeral/releases/tag/6.3.3
 2020-04-16 01:11:28 -04:00
adisbladis
2ac39a1ec6
firefox-devedition-bin: 76.0b1 -> 76.0b4 2020-04-14 09:07:25 +01:00
adisbladis
7767fdad1a
firefox-beta-bin: 76.0b1 -> 76.0b4 2020-04-14 09:06:56 +01:00
John Ericson
204d710405 treewide: Get rid of -dumpmachine in favor of static info 2020-04-13 19:26:19 -04:00
squalus
7205bd64a3 ungoogled-chromium: init at 81.0.4044.92-2 2020-04-13 13:17:05 -07:00
Michael Weiss
b533f10345
chromium: Fix the VA-API build 2020-04-10 23:28:35 +02:00
Michael Reilly
84cf00f980
treewide: Per RFC45, remove all unquoted URLs 2020-04-10 17:54:53 +01:00
Andy Fowlston
85e4f2d554 tor-browser-bundle-bin: 9.0.7 -> 9.0.9 
https://blog.torproject.org/new-release-tor-browser-909
https://blog.torproject.org/new-release-tor-browser-908
 2020-04-09 18:51:59 +01:00
Michael Weiss
da832dd7d4
chromium: 80.0.3987.163 -> 81.0.4044.92 
https://chromereleases.googleblog.com/2020/04/stable-channel-update-for-desktop_7.html

This update includes 32 security fixes.

CVEs:
CVE-2020-6454 CVE-2020-6423 CVE-2020-6455 CVE-2020-6430 CVE-2020-6456
CVE-2020-6431 CVE-2020-6432 CVE-2020-6433 CVE-2020-6434 CVE-2020-6435
CVE-2020-6436 CVE-2020-6437 CVE-2020-6438 CVE-2020-6439 CVE-2020-6440
CVE-2020-6441 CVE-2020-6442 CVE-2020-6443 CVE-2020-6444 CVE-2020-6445
CVE-2020-6446 CVE-2020-6447 CVE-2020-6448
 2020-04-08 00:08:46 +02:00
Michael Weiss
d782c440ae
chromiumDev: Add the missing setuptools dependency 
The build was failing with:
```
[1625/39505] ACTION //components/schema_org:generate_schema_org_code(//build/toolchain/linux:clang_x64)
FAILED: gen/components/schema_org/schema_org_entity_names.h gen/components/schema_org/schema_org_entity_names.cc gen/components/schema_org/schema_org_property_configurations.h gen/components/schema_org/schema_org_property_configurations.cc gen/components/schema_org/schema_org_property_names.h gen/components/schema_org/schema_org_property_names.cc
python ../../components/schema_org/generate_schema_org_code.py --schema-file ../../third_party/schema_org/schema.jsonld --output-dir gen/components/schema_org --templates templates/schema_org_entity_names.cc.tmpl templates/schema_org_entity_names.h.tmpl templates/schema_org_property_configurations.cc.tmpl templates/schema_org_property_configurations.h.tmpl templates/schema_org_property_names.cc.tmpl templates/schema_org_property_names.h.tmpl
Traceback (most recent call last):
  File "../../components/schema_org/generate_schema_org_code.py", line 22, in <module>
    env = Environment(loader=PackageLoader('generate_schema_org_code', ''))
  File "/build/chromium-83.0.4100.3/components/schema_org/../../third_party/jinja2/loaders.py", line 222, in __init__
    from pkg_resources import DefaultProvider, ResourceManager, \
ImportError: No module named pkg_resources
```
 2020-04-07 23:21:28 +02:00
Andreas Rammhold
80d0a401d0
Merge pull request #84584 from andir/firefox 
firefox: 74.0.1 -> 75.0 and related updates
 2020-04-07 20:05:14 +02:00
Andreas Rammhold
79fb58973f
firefox-devedition-bin: 75.0b12 -> 76.0b1 2020-04-07 13:27:28 +02:00
Andreas Rammhold
9d6a7fdaad
firefox-beta-bin: 75.0b11 -> 76.0b1 2020-04-07 13:27:27 +02:00
Andreas Rammhold
bab82e78b2
firefox-bin: 74.0.1 -> 75.0 2020-04-07 13:27:27 +02:00
Andreas Rammhold
f56ea6cdd7
firefox-esr-68: 68.6.1esr -> 68.7.0esr 2020-04-07 13:27:27 +02:00
Andreas Rammhold
4a41fd7a1e
firefox: 74.0.1 -> 75.0 2020-04-07 13:27:27 +02:00
Andreas Rammhold
9de3c9749c
firefox: prepare for version 75 2020-04-07 13:27:27 +02:00
Michael Weiss
ff3bc51d2b
chromiumBeta: Fix the build 
This patch was also backported to M81 [0][1].

[0]: https://chromium-review.googlesource.com/c/chromium/src/+/2091896
[1]: bbf0fad592
 2020-04-07 12:32:33 +02:00
Tim Steinbach
a3358eeeb4
vivaldi: 2.11.1811.51-1 -> 2.11.1811.52-1 2020-04-06 13:06:01 -04:00
Michael Weiss
ad3220f9ff
chromiumDev: Override gn to fix the configuration phase 
The configuration phase was failing due to:
```
configuring
ERROR at //BUILD.gn:1376:5: Unknown function.
    filter_exclude([ "$root_build_dir/foo" ],
    ^-------------
```
 2020-04-06 12:52:52 +02:00
Florian Klink
29f491d5b7
Merge pull request #81864 from volth/patch-389 
firefox: mark as broken on 32-bit buildPlatform
 2020-04-05 20:29:29 +02:00
Jeff Labonte
e1c851a5d7 brave: 1.5.115 -> 1.5.123 2020-04-05 15:38:53 +02:00
Andreas Rammhold
da542ec399
Merge pull request #84211 from andir/firefox 
firefox: 74.0 -> 74.0.1
 2020-04-04 12:59:37 +02:00
Andreas Rammhold
f6430a2aea
firefox-esr: 68.8.0esr -> 68.8.1esr 2020-04-03 22:42:48 +02:00
Andreas Rammhold
befaaff62b
firefox-devedition-bin: 75.0b10 -> 75.0b12 2020-04-03 22:12:29 +02:00
Andreas Rammhold
c1d2dc9666
firefox-beta-bin: 75.0b10 -> 75.0b11 2020-04-03 22:11:59 +02:00
Andreas Rammhold
87abb48dc2
firefox-bin: 74.0 -> 74.0.1 2020-04-03 22:11:37 +02:00
Andreas Rammhold
48e6a3f1f1
firefox: 74.0 -> 74.0.1 2020-04-03 22:11:03 +02:00
Michael Weiss
9f3914824d
chromium: Ignore unknown warning options 
This can e.g. save around 150k lines of unnecessary log messages which
take up around 66% of the total lines (based on a log of 80.0.3987.100):
29527 warning: unknown warning option '-Wno-bitwise-conditional-parentheses'; did you mean '-Wno-bitwise-op-parentheses'? [-Wunknown-warning-option]
29527 warning: unknown warning option '-Wno-builtin-assume-aligned-alignment' [-Wunknown-warning-option]
29527 warning: unknown warning option '-Wno-deprecated-copy'; did you mean '-Wno-deprecated'? [-Wunknown-warning-option]
29527 warning: unknown warning option '-Wno-final-dtor-non-final-class'; did you mean '-Wno-abstract-final-class'? [-Wunknown-warning-option]
29527 warning: unknown warning option '-Wno-implicit-int-float-conversion'; did you mean '-Wno-implicit-float-conversion'? [-Wunknown-warning-option]
 2020-04-03 12:40:46 +02:00
Michael Weiss
cbd13f3c55
chromium: 80.0.3987.162 -> 80.0.3987.163 
https://chromereleases.googleblog.com/2020/04/stable-channel-update-for-desktop.html

Note: This update contains only two fixes [0]. The fix that reverts a
feature which caused a crash spike on 80.0.3987.162 [1] seems important
for us (though the commit doesn't provide any data on the crash spike).

[0]: https://chromium.googlesource.com/chromium/src/+log/80.0.3987.162..80.0.3987.163?pretty=fuller
[1]: fc11c43603
 2020-04-03 11:17:54 +02:00
Tim Steinbach
5d9e9258de
vivaldi: 2.11.1811.49-1 -> 2.11.1811.51-1 2020-04-02 10:05:48 -04:00
Michael Weiss
36c7123709
chromiumDev: Remove a patch that is already applied 
This fixes the patch phase.
I missed this problem in #83956.
 2020-04-02 13:01:39 +02:00
Michael Weiss
6b7528c940
chromium: 80.0.3987.149 -> 80.0.3987.162 
https://chromereleases.googleblog.com/2020/03/stable-channel-update-for-desktop_31.html

This update includes 8 security fixes.

CVEs:
CVE-2020-6450 CVE-2020-6451 CVE-2020-6452
 2020-04-01 12:37:52 +02:00
R. RyanTM
e38859deac ephemeral: 6.3.0 -> 6.3.1 2020-03-30 17:57:40 -07:00
Florian Klink
ae3928997c
Merge pull request #82807 from mehlon/tor-browser 
tor-browser-bundle-bin: enable multimedia support by default
 2020-03-29 19:41:40 +02:00
Maximilian Bosch
3f0a792feb
Merge pull request #83300 from mehlon/torbrowser-1.0.7 
tor-browser-bundle-bin: 9.0.6 -> 9.0.7
 2020-03-29 01:01:31 +01:00
Michael Weiss
d83420f5e1
Merge pull request #82919 from artemist/chromium-ozone 
chromium: Add option to enable ozone (for Wayland)
 2020-03-28 14:50:21 +01:00
adisbladis
e76a190ce7
firefox-devedition-bin: 75.0b2 -> 75.0b10 2020-03-28 10:31:07 +00:00
adisbladis
657d81a4c3
firefox-beta-bin: 75.0b2 -> 75.0b10 2020-03-28 10:31:07 +00:00
Artemis Tosini
b3e1a1bbbb
chromium: Add option to enable ozone (for Wayland) 2020-03-27 21:16:38 +00:00
Mario Rodas
3afe526536
Merge pull request #83120 from JeffLabonte/update_brave_1.5.112_to_1.5.115 
brave: 1.5.112 -> 1.5.115
 2020-03-26 22:54:24 -05:00
Michael Weiss
29becfcf19
Merge pull request #83304 from nh2/issue-41918-chromium-swiftshader-by-default 
chromium: Enable swiftshader by default.
 2020-03-25 13:42:30 +01:00
Niklas Hambüchen
015bb28ae1 chromium: Enable swiftshader by default. 
This makes it possible to use chromium headless with WebGL
(e.g. for webdriver tests) without having to rebuild from source.

The upstram default is to enable, thus simply removing our disabling switch.

Also fixes #41918.
 2020-03-24 22:50:49 +01:00
Peter Simons
b3c2908825 chromium: I accidentally added the webrtc patch into the wrong section 2020-03-24 22:50:03 +01:00
mehlon
79f6b312ba tor-browser-bundle-bin: 9.0.6 -> 9.0.7 2020-03-24 17:19:42 +01:00
Michael Weiss
fca8961bdb
Revert "chromiumDev: Add the missing clang-format binary" 
This reverts commit 02ca096a85.

The clang-format binary is now included in the release tarball [0] and
we don't need to add it anymore. This fixes the following build error:
ln: failed to create symbolic link 'buildtools/linux64/clang-format': File exists
However, the build still fails a bit later in the configure phase.

[0]: https://bugs.chromium.org/p/chromium/issues/detail?id=1052503
 2020-03-23 21:50:48 +01:00
Peter Simons
81b18c3711 chromium: fix webrtc interaction with pulseaudio 
The webrtc code suffered from a race condition when used
with Pulseaudio. This lead to audio input breaking every
couple of minutes during a webrtc session.
 2020-03-23 16:56:08 +01:00
Jörg Thalheim
e77dca6ca8
browsh: fix build with strict deps enabled 2020-03-23 08:14:39 +00:00