Commit Graph

73 Commits

Author SHA1 Message Date
Andrew Dunham
274afc4932 go: build each package single-threaded (#53390)
I noticed that I was seeing the Go compiler build things in parallel even when I'd set `-j1 --cores 1`. It appears that the compiler, by default, uses the number of CPUs that are available to perform a build, while nixpkgs parallelizes at the directory level.

In order to change the fewest assumptions, this explicitly tells the Go compiler to run single-threaded. The flag's documentation is:

```
-p n
	the number of programs, such as build commands or
	test binaries, that can be run in parallel.
	The default is the number of CPUs available.
```

So this should function as expected. Feedback appreciated!
2019-02-07 14:39:53 +00:00
Jörg Thalheim
b4593b4629
buildGoPackage: also support pname
Following python-modules and stdenv.mkDerivation.
Hopefully zero rebuilds.

Motivation: https://github.com/NixOS/nixpkgs/pull/52409
2018-12-18 03:57:54 +01:00
Jörg Thalheim
79b9462468
go_1_11: fix cross compilation 2018-11-24 10:36:57 +00:00
Jörg Thalheim
9564927888
buildGoPackage: remove build-time dependency on parallel (and perl)
xargs is as good as parallel for our job

fixes #50752
2018-11-21 17:45:44 +00:00
Jörg Thalheim
9bbfc6f6e2
buildGoPackage: re-enable GOCACHE
If projects uses go1.11 modules GOCACHE is required.
Also if buildGoPackage is used in a nix-shell setting we don't
want to override GOCACHE to allow incremental builds.
This should be backported to 18.09
2018-10-28 13:51:16 +00:00
Armando Ramirez
7d238e6da8 Allow doCheck config of buildGoPackage 2018-09-10 23:05:23 +00:00
Frederik Rietdijk
f59e6f4037 Merge master into staging 2018-07-26 16:18:53 +02:00
Antoine Eiche
05df6d4f62 goBuildPackage: Add -x to the go build command if NIX_DEBUG >= 1
The -x go option prints all intermediate commands used by the Go
compiler. For instance, this is pretty useful to debug Go LD_FLAGS
because the used linker command is printed.
2018-07-18 09:50:47 +02:00
Antoine Eiche
a8a5bf0496 buildGoPackage: add shellHook attribute 2018-07-17 13:13:57 +02:00
adisbladis
e95f17e272
buildGoPackage: Dont copy sources to $out
Some sources are quite large and they don't seem to offer much value
2018-07-11 20:40:47 +08:00
Piotr Bogdan
d1fad21401 buildGoPackage: use a separator when joining extraSrcPaths together 2018-04-01 17:44:36 +01:00
Jörg Thalheim
aafd5a63ea buildGoPackage: disable go 1.10 cache
This disables annoying error messages that the go cache in /homeless-shelter cannot be created.
2018-02-24 01:57:16 +00:00
Yegor Timoshenko
40702af936
buildGoPackage: fill in meta.homepage 2017-12-20 01:07:14 +00:00
Orivej Desh
0fddfcdd4d
Merge pull request #30350 from alicebob/absdir
go: use absolute dir in getGoDirs()
2017-11-11 01:17:23 +00:00
Kamil Chmielewski
d05b21d7c0 goDeps: support fetchFromGiHub to fetch Go libs
https://github.com/NixOS/nixpkgs/pull/16017#issuecomment-246252087
https://github.com/NixOS/nixpkgs/pull/17254#issuecomment-245297782
2017-11-01 01:28:57 +01:00
Harmen
6cae9e7127 go: use absolute dir in getGoDirs() 2017-10-12 15:46:08 +02:00
Orivej Desh
07d2a5b412 go: update nonfatal build error list 2017-09-28 10:28:20 +00:00
Joachim Schiele
f30dd71a38 go-modules/generic: add missing PATHs to GOPATH when using nix-shell (#26176) 2017-06-01 20:40:21 +02:00
Jörg Thalheim
2a42b45105 Merge pull request #25103 from Hodapp87/google_cloud_print
cloud-print-connector: init at unstable-2017-01-19
2017-05-20 18:23:12 +01:00
Chris Hodapp
cc4f861f82 cloud-print-connector: init at unstable-2017-01-19
This adds a fairly basic build for just the binaries for the Google
Cloud Print CUPS connector (gcp-cups-connector), and gcp-connector-util
to set it up in the first place. In the future I would like to
streamline the configuration more and make gcp-cups-connector a
proper NixOS service - as right now it must be run by hand.
2017-04-30 08:54:54 -04:00
snyh
12f52d234e buildGoPackage: fix preFixup failing
The preFixup is always failed if the target package hasn't any
binary output.
2017-04-16 09:19:58 +08:00
Joachim Fasting
4a12a681ef
go builder: use removeReferencesTo 2017-03-29 00:35:01 +02:00
Shea Levy
d6c3e74425 buildGoModule: share the buildFlagsArray with the parallel subprocesses 2017-03-15 11:00:55 -04:00
Vladimír Čunát
e065861a4f
buildGoPackage: reduce the default meta.platforms
platforms.all makes no sense as go.meta.platforms is smaller.  Discussion:
https://github.com/NixOS/nixpkgs/pull/20923#issuecomment-266763319
2016-12-14 10:26:20 +01:00
zimbatm
cbdc94f2b7 buildGoPackage: remove go version from name (#21111)
As a user installing the program it's not interesting what go version it
was compiled against. Not more interesting than any other potential
dependencies. It also makes it harder to install or update the package.
2016-12-13 11:35:15 +00:00
Franz Pletz
2d934fdffb
buildGoPackage: introduce extraSrcPaths option
This option adds support for including sources from existing gopaths into
the gopath of the package to build.
2016-10-29 05:18:16 +02:00
Kamil Chmielewski
914e0e594c buildGoPackage: deps.json -> deps.nix in NIXON
https://github.com/NixOS/nixpkgs/pull/17254#issuecomment-245295541

* update docs to describe `deps.nix`
* include goDeps in nix-shell GOPATH
* NixOS 16.09 rel notes about replacing goPackages
2016-09-16 00:04:55 +01:00
Tuomas Tynkkynen
9b63aff395 go: Split output order to match new convention 2016-08-31 13:55:40 +03:00
Kamil Chmielewski
da3ddd48e4 buildGoPackage: remove Go deps file libs.json
After #16017 there were a lot
of comments saying that `nix` would be better than `JSON`
for Go packages dependency sets.
As said in https://github.com/NixOS/nixpkgs/pull/16017#issuecomment-229624046

    > Because of the content-addressable store, if two programs have the
    > same dependency it will already result in the same derivation in
    > the
    > store. Git also has compression in the pack files so it won't make
    > much difference to duplicate the dependencies on disk. And finally
    > most users will just use the binary builds so it won't make any
    > differences to them.

This PR removes `libs.json` file and puts all package dependencies in
theirs `deps.json`.
2016-08-11 23:07:09 +02:00
zimbatm
f870d6aeb6 goBuildPackage: export go
This is useful to make sure to use the same version of go in further
derivations.
2016-06-09 16:11:17 +02:00
Kamil Chmielewski
7eb671ebcd no more goPackages 2016-06-09 13:08:00 +02:00
Kamil Chmielewski
fc9bc9eba5 goDeps: support for mercurial repos 2016-06-09 11:22:02 +02:00
Kamil Chmielewski
81f3092e11 Reusing go libs in deis build 2016-06-09 11:21:30 +02:00
Kamil Chmielewski
bf9f60fe74 buildGoPackage: we don't need to build vendored packages 2016-04-07 17:45:20 +02:00
Charles Strahan
d53d5048d8 goPackages: add ide-like packages
This adds the following packages:

 * errcheck
 * gotool
 * gometalinter
 * motion
 * shlex
2016-03-18 03:14:44 -04:00
Valérian Galliat
37d1dcd12d buildGoPackage: do not remove Go references if allowGoReferences is true
allowGoReference was only checked for disallowedReferences definition,
but the fixup of all output binaries removing references to the compiler
did not take this setting into account.
2016-02-28 22:42:58 -05:00
Lluís Batlle i Rossell
082f2e6938 go builder: respect enableParallelBuilding
It was parallelizing for $NIX_BUILD_CORES regardless of
enableParallelBuilding.
2016-01-21 17:11:28 +01:00
Emery Hemingway
2b6dcdfcd0 Rename 'emery' maintainer handle to 'ehmry', fixes #11493
Communication happens on Github so names should be consistent.
2015-12-05 23:06:20 +01:00
William A. Kennington III
043839368e goPackages: Exclude commonly useless go packages from being built 2015-08-29 19:10:24 -07:00
William A. Kennington III
26f9ea6dd5 goPackages: Fix tools 2015-08-29 13:25:00 -07:00
William A. Kennington III
83cf8b0cf8 goPackages: Split into multiple derivations
This should reduce the closure size for end users who only need go
binaries as well as reduce the size of closures hydra builders consume.
2015-08-29 12:58:03 -07:00
William A. Kennington III
3afc3494bb goPackages: Use parallel instead of forking in bash 2015-08-29 11:51:26 -07:00
William A. Kennington III
d0880a27dd go-modules: Fix the application of reference removal on packages like mongo-tools 2015-08-27 01:02:20 -07:00
William A. Kennington III
c2ae91a413 buildGoPackage: Fix parallel test pid computation 2015-08-26 11:17:56 -07:00
Luca Bruno
08a6b7aa46 Revert "goPackages: disable parallel builds"
This reverts commit 75ed15e174.

Turns out it was just a missing &

cc @wkennington
2015-08-26 12:13:57 +02:00
Luca Bruno
75ed15e174 goPackages: disable parallel builds
It breaks cascadia tests. If a process terminates before wait,
the PID is non-existant and wait fails.
Using & and wait in bash is just broken and shouldn't be used.
We shall probably use GNU parallel for this job.

cc @wkennington
2015-08-26 12:11:27 +02:00
William A. Kennington III
bf0da55a8c gotools: Fix build and update to 2015-08-19 2015-08-19 13:54:54 -07:00
William A. Kennington III
c1338b3b06 buildGoPackage: Remove references to the go compiler to reduce closure size for binaries 2015-08-05 16:23:03 -07:00
William A. Kennington III
2856d4701e buildGoPackage: Support nativeBuildInputs 2015-08-05 16:22:36 -07:00
Anton Fedotov
f0269dd8b0 go-modules: This patch fixes an error with copying sources during installPhase if src of go module conatins file with spaces 2015-08-02 07:09:34 +03:00