From 8d07b99b96661a60e14141824bf891e10776cf85 Mon Sep 17 00:00:00 2001 From: Bas van Dijk Date: Tue, 19 Sep 2017 11:03:38 +0200 Subject: [PATCH 01/18] journalbeat: 5.5.0 -> 5.6.0 --- pkgs/tools/system/journalbeat/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/tools/system/journalbeat/default.nix b/pkgs/tools/system/journalbeat/default.nix index de4687a6a57f..5d60f4c7c5c3 100644 --- a/pkgs/tools/system/journalbeat/default.nix +++ b/pkgs/tools/system/journalbeat/default.nix @@ -7,7 +7,7 @@ let in buildGoPackage rec { name = "journalbeat-${version}"; - version = "5.5.0"; + version = "5.6.0"; goPackagePath = "github.com/mheese/journalbeat"; @@ -22,7 +22,7 @@ in buildGoPackage rec { owner = "mheese"; repo = "journalbeat"; rev = "v${version}"; - sha256 = "134n1kg6nx5yycn2cyldiayaqm8zps94hz4zfz9klp2jzq68m35y"; + sha256 = "0b5yqzw1h945mwwyy7cza6bc7kzv3x1p9w2xkzmvr7rw3pd32r06"; }; meta = with lib; { From a9f8207f9f0b37e78b5f31e163fdee7023469545 Mon Sep 17 00:00:00 2001 From: Aneesh Agrawal Date: Mon, 18 Sep 2017 02:30:47 -0700 Subject: [PATCH 02/18] radicale_infcloud: init --- .../radicale_infcloud/default.nix | 24 +++++++++++++++++++ pkgs/top-level/python-packages.nix | 2 ++ 2 files changed, 26 insertions(+) create mode 100644 pkgs/development/python-modules/radicale_infcloud/default.nix diff --git a/pkgs/development/python-modules/radicale_infcloud/default.nix b/pkgs/development/python-modules/radicale_infcloud/default.nix new file mode 100644 index 000000000000..afa1895e5404 --- /dev/null +++ b/pkgs/development/python-modules/radicale_infcloud/default.nix @@ -0,0 +1,24 @@ +{ stdenv, fetchFromGitHub, buildPythonPackage }: + +buildPythonPackage rec { + pname = "radicale_infcloud"; + name = "${pname}-${version}"; + version = "2017-07-27"; + + src = fetchFromGitHub { + owner = "Unrud"; + repo = "RadicaleInfCloud"; + rev = "972757bf4c6be8b966ee063e3741ced29ba8169f"; + sha256 = "1c9ql9nv8kwi791akwzd19dcqzd916i7yxzbnrismzw4f5bhgzsk"; + }; + + doCheck = false; # Tries to import radicale, circular dependency + + meta = with stdenv.lib; { + homepage = https://github.com/Unrud/RadicaleInfCloud/; + description = "Integrate InfCloud into Radicale's web interface"; + license = with licenses; [ agpl3 gpl3 ]; + platforms = platforms.all; + maintainers = with maintainers; [ aneeshusa ]; + }; +} diff --git a/pkgs/top-level/python-packages.nix b/pkgs/top-level/python-packages.nix index ccc9e4598437..09ad96ed873a 100644 --- a/pkgs/top-level/python-packages.nix +++ b/pkgs/top-level/python-packages.nix @@ -18346,6 +18346,8 @@ in { }; }; + radicale_infcloud = callPackage ../development/python-modules/radicale_infcloud {}; + recaptcha_client = buildPythonPackage rec { name = "recaptcha-client-1.0.6"; From 367e30b8f3c71852a6cdc70e5612fb5b93dda06c Mon Sep 17 00:00:00 2001 From: Samuel Leathers Date: Tue, 19 Sep 2017 14:13:59 -0400 Subject: [PATCH 03/18] libxmlxx: move glibmm to propagatedBuildInputs --- pkgs/development/libraries/libxmlxx/default.nix | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkgs/development/libraries/libxmlxx/default.nix b/pkgs/development/libraries/libxmlxx/default.nix index 65e10c5a3995..23b36db8fe10 100644 --- a/pkgs/development/libraries/libxmlxx/default.nix +++ b/pkgs/development/libraries/libxmlxx/default.nix @@ -12,9 +12,7 @@ stdenv.mkDerivation rec { nativeBuildInputs = [ pkgconfig perl ]; - buildInputs = [ glibmm ]; - - propagatedBuildInputs = [ libxml2 ]; + propagatedBuildInputs = [ libxml2 glibmm ]; meta = with stdenv.lib; { homepage = http://libxmlplusplus.sourceforge.net/; From 4916f64948ae0c8fc7a1e0187c6305f90ffa88e0 Mon Sep 17 00:00:00 2001 From: volth Date: Tue, 19 Sep 2017 13:38:39 +0000 Subject: [PATCH 04/18] libwebsockets: 1.4 -> 2.3.0 --- .../libraries/libwebsockets/default.nix | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/pkgs/development/libraries/libwebsockets/default.nix b/pkgs/development/libraries/libwebsockets/default.nix index 6ce183889043..dbcbf550c13f 100644 --- a/pkgs/development/libraries/libwebsockets/default.nix +++ b/pkgs/development/libraries/libwebsockets/default.nix @@ -1,15 +1,19 @@ -{ fetchgit, stdenv, cmake, openssl, zlib }: +{ fetchFromGitHub, stdenv, cmake, openssl, zlib, libuv }: stdenv.mkDerivation rec { - name = "libwebsockets-1.4"; + name = "libwebsockets-${version}"; + version = "2.3.0"; - src = fetchgit { - url = "git://git.libwebsockets.org/libwebsockets"; - rev = "16fb0132cec0fcced29bce6d86eaf94a9beb9785"; - sha256 = "0gk4dgx125nz7wl59bx0kgxxg261r9kyxvdff5ld98slr9f08d0l"; + src = fetchFromGitHub { + owner = "warmcat"; + repo = "libwebsockets"; + rev = "v${version}"; + sha256 = "1hv2b5r6sg42xnqhm4ysjvyiz3cqpfmwaqm33vpbx0k7arj4ixvy"; }; buildInputs = [ cmake openssl zlib ]; + propagatedBuildInputs = [ libuv ]; + cmakeFlags = [ "-DLWS_WITH_PLUGINS=ON" ]; meta = { description = "Light, portable C library for websockets"; @@ -19,8 +23,7 @@ stdenv.mkDerivation rec { throughput in both directions. ''; homepage = https://libwebsockets.org/trac/libwebsockets; - # See http://git.libwebsockets.org/cgi-bin/cgit/libwebsockets/tree/LICENSE - license = stdenv.lib.licenses.gpl2Plus; + license = stdenv.lib.licenses.lgpl; maintainers = [ ]; platforms = stdenv.lib.platforms.all; }; From 6950da832df90684c2cd164961f9de8bd45aba4e Mon Sep 17 00:00:00 2001 From: Volth Date: Tue, 19 Sep 2017 16:12:49 +0000 Subject: [PATCH 05/18] mosquitto: 1.4 -> 1.4.14 fixes #29567 --- pkgs/servers/mqtt/mosquitto/default.nix | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/pkgs/servers/mqtt/mosquitto/default.nix b/pkgs/servers/mqtt/mosquitto/default.nix index a136c94aa575..782581b860a9 100644 --- a/pkgs/servers/mqtt/mosquitto/default.nix +++ b/pkgs/servers/mqtt/mosquitto/default.nix @@ -1,17 +1,17 @@ -{ stdenv, fetchurl, openssl, libuuid, cmake, libwebsockets }: +{ stdenv, fetchurl, openssl, libuuid, cmake, libwebsockets, c-ares }: stdenv.mkDerivation rec { pname = "mosquitto"; - version = "1.4"; + version = "1.4.14"; name = "${pname}-${version}"; src = fetchurl { - url = http://mosquitto.org/files/source/mosquitto-1.4.tar.gz; - sha256 = "1imw5ps0cqda41b574k8hgz9gdr8yy58f76fg8gw14pdnvf3l7sr"; + url = "http://mosquitto.org/files/source/mosquitto-${version}.tar.gz"; + sha256 = "1la2577h7hcyj7lq26vizj0sh2zmi9m7nbxjp3aalayi66kiysqm"; }; - buildInputs = [ openssl libuuid libwebsockets ] + buildInputs = [ openssl libuuid libwebsockets c-ares ] ++ stdenv.lib.optional stdenv.isDarwin cmake; makeFlags = [ @@ -24,7 +24,6 @@ stdenv.mkDerivation rec { --replace "/usr/local" "" substituteInPlace config.mk \ --replace "WITH_WEBSOCKETS:=no" "WITH_WEBSOCKETS:=yes" - ''; meta = { From 2c2252247c5af86cdd6a7d19f27ce6017c69c63d Mon Sep 17 00:00:00 2001 From: Samuel Leathers Date: Tue, 19 Sep 2017 16:07:03 -0400 Subject: [PATCH 06/18] lenmus: removing custom cmakeFlags --- pkgs/applications/misc/lenmus/default.nix | 4 ---- 1 file changed, 4 deletions(-) diff --git a/pkgs/applications/misc/lenmus/default.nix b/pkgs/applications/misc/lenmus/default.nix index 4ac0dc2eb944..b78a226b6145 100644 --- a/pkgs/applications/misc/lenmus/default.nix +++ b/pkgs/applications/misc/lenmus/default.nix @@ -16,10 +16,6 @@ stdenv.mkDerivation rec { sha256 = "1n639xr1qxx6rhqs0c6sjxp3bv8cwkmw1vfk1cji7514gj2a9v3p"; }; - cmakeFlags = [ - "-DCMAKE_INSALL_PREFIX=$out" - ]; - enableParallelBuilding = true; patches = [ From 6d423da7cc696f6a307dca72ca9634ac1ee0ecc4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= Date: Tue, 19 Sep 2017 21:14:42 +0100 Subject: [PATCH 07/18] libwebsockets: fix eval --- pkgs/development/libraries/libwebsockets/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/development/libraries/libwebsockets/default.nix b/pkgs/development/libraries/libwebsockets/default.nix index dbcbf550c13f..0953a915a2c8 100644 --- a/pkgs/development/libraries/libwebsockets/default.nix +++ b/pkgs/development/libraries/libwebsockets/default.nix @@ -23,7 +23,7 @@ stdenv.mkDerivation rec { throughput in both directions. ''; homepage = https://libwebsockets.org/trac/libwebsockets; - license = stdenv.lib.licenses.lgpl; + license = stdenv.lib.licenses.lgpl21; maintainers = [ ]; platforms = stdenv.lib.platforms.all; }; From 6c74ee68b9d985a9a5b26eb9e6ee1bfc06283bee Mon Sep 17 00:00:00 2001 From: John Ericson Date: Mon, 18 Sep 2017 21:12:23 -0400 Subject: [PATCH 08/18] cc-wrapper, cc-wrapper-old: Simplify shell logic 1. `crossDrv` is now the default so we don't need to worry about that in build != host builds. 2. shell is the build time shell, so `wrapCCCross` doesn't need to worry, as build == host. 3. `shell.shellPath` will always be appended where useful. 4. Complicated `shell == ""` logic served no purpose. --- pkgs/build-support/cc-wrapper/default.nix | 7 ++----- pkgs/build-support/gcc-wrapper-old/default.nix | 10 ++-------- pkgs/top-level/all-packages.nix | 4 ++-- 3 files changed, 6 insertions(+), 15 deletions(-) diff --git a/pkgs/build-support/cc-wrapper/default.nix b/pkgs/build-support/cc-wrapper/default.nix index 999faf756ed4..866be9cded9e 100644 --- a/pkgs/build-support/cc-wrapper/default.nix +++ b/pkgs/build-support/cc-wrapper/default.nix @@ -86,7 +86,8 @@ stdenv.mkDerivation { preferLocalBuild = true; - inherit cc shell libc_bin libc_dev libc_lib binutils_bin coreutils_bin; + inherit cc libc_bin libc_dev libc_lib binutils_bin coreutils_bin; + shell = getBin shell + shell.shellPath or ""; gnugrep_bin = if nativeTools then "" else gnugrep; binPrefix = prefix; @@ -384,10 +385,6 @@ stdenv.mkDerivation { # for substitution in utils.sh expandResponseParams = "${expand-response-params}/bin/expand-response-params"; - crossAttrs = { - shell = shell.crossDrv + shell.crossDrv.shellPath; - }; - meta = let cc_ = if cc != null then cc else {}; in (if cc_ ? meta then removeAttrs cc.meta ["priority"] else {}) // diff --git a/pkgs/build-support/gcc-wrapper-old/default.nix b/pkgs/build-support/gcc-wrapper-old/default.nix index 8d28879fb06f..ae17989d932b 100644 --- a/pkgs/build-support/gcc-wrapper-old/default.nix +++ b/pkgs/build-support/gcc-wrapper-old/default.nix @@ -6,7 +6,7 @@ # variables so that the compiler and the linker just "work". { name ? "", stdenv, lib, nativeTools, nativeLibc, nativePrefix ? "" -, gcc ? null, libc ? null, binutils ? null, coreutils ? null, shell ? "" +, gcc ? null, libc ? null, binutils ? null, coreutils ? null, shell ? stdenv.shell , zlib ? null , hostPlatform, targetPlatform }: @@ -56,15 +56,9 @@ stdenv.mkDerivation { langAda = if nativeTools then false else gcc ? langAda && gcc.langAda; langVhdl = if nativeTools then false else gcc ? langVhdl && gcc.langVhdl; zlib = if gcc != null && gcc ? langVhdl then zlib else null; - shell = if shell == "" then stdenv.shell else - if builtins.isAttrs shell then (shell + shell.shellPath) - else shell; + shell = shell + shell.shellPath or ""; crossAttrs = { - shell = shell.crossDrv + shell.crossDrv.shellPath; - coreutils = coreutils.crossDrv; - binutils = binutils.crossDrv; - gcc = gcc.crossDrv; # # This is not the best way to do this. I think the reference should be # the style in the gcc-cross-wrapper, but to keep a stable stdenv now I diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 5418ddc002f8..068fa3230d63 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -6230,7 +6230,7 @@ with pkgs; }; wrapCCCross = - {cc, libc, binutils, shell ? "", name ? "gcc-cross-wrapper"}: + {cc, libc, binutils, name ? "gcc-cross-wrapper"}: forcedNativePackages.ccWrapperFun { nativeTools = false; @@ -6240,7 +6240,7 @@ with pkgs; isGNU = cc.isGNU or false; isClang = cc.isClang or false; - inherit cc binutils libc shell name; + inherit cc binutils libc name; }; # prolog From a50d0b719f671f8955d5bd415586ef9358cb31b5 Mon Sep 17 00:00:00 2001 From: Thomas Tuegel Date: Tue, 19 Sep 2017 12:16:47 -0500 Subject: [PATCH 09/18] alacritty: install desktop icon --- pkgs/applications/misc/alacritty/default.nix | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkgs/applications/misc/alacritty/default.nix b/pkgs/applications/misc/alacritty/default.nix index 2316ce5ab298..5e7dc934a093 100644 --- a/pkgs/applications/misc/alacritty/default.nix +++ b/pkgs/applications/misc/alacritty/default.nix @@ -57,6 +57,9 @@ buildRustPackage rec { cp $f $out/bin done; patchelf --set-rpath "${stdenv.lib.makeLibraryPath rpathLibs}" $out/bin/alacritty + + mkdir -p $out/share/applications + cp Alacritty.desktop $out/share/applications/alacritty.desktop ''; dontPatchELF = true; From 6e01011211f856ca94c643daeab3f82694750916 Mon Sep 17 00:00:00 2001 From: Thomas Tuegel Date: Tue, 19 Sep 2017 12:16:04 -0500 Subject: [PATCH 10/18] alacritty: respect pre- and post-hooks of overridden phases Failing to `runHook` when overriding phases can have unpredictable results. fixes #29572 --- pkgs/applications/misc/alacritty/default.nix | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkgs/applications/misc/alacritty/default.nix b/pkgs/applications/misc/alacritty/default.nix index 5e7dc934a093..79333e7d9fa1 100644 --- a/pkgs/applications/misc/alacritty/default.nix +++ b/pkgs/applications/misc/alacritty/default.nix @@ -46,12 +46,14 @@ buildRustPackage rec { pkgconfig ] ++ rpathLibs; - patchPhase = '' + postPatch = '' substituteInPlace copypasta/src/x11.rs \ --replace Command::new\(\"xclip\"\) Command::new\(\"${xclip}/bin/xclip\"\) ''; installPhase = '' + runHook preInstall + mkdir -p $out/bin for f in $(find target/release -maxdepth 1 -type f); do cp $f $out/bin @@ -60,6 +62,8 @@ buildRustPackage rec { mkdir -p $out/share/applications cp Alacritty.desktop $out/share/applications/alacritty.desktop + + runHook postInstall ''; dontPatchELF = true; From a3e806ef0fbe1271751c2ce8e2a763b03706d69d Mon Sep 17 00:00:00 2001 From: Frank Doepper Date: Mon, 4 Sep 2017 09:41:57 +0200 Subject: [PATCH 11/18] tp_smapi with hdaps --- pkgs/os-specific/linux/tp_smapi/default.nix | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkgs/os-specific/linux/tp_smapi/default.nix b/pkgs/os-specific/linux/tp_smapi/default.nix index 510f781e3936..2da828888040 100644 --- a/pkgs/os-specific/linux/tp_smapi/default.nix +++ b/pkgs/os-specific/linux/tp_smapi/default.nix @@ -18,11 +18,13 @@ stdenv.mkDerivation rec { makeFlags = [ "KBASE=${kernel.dev}/lib/modules/${kernel.modDirVersion}" "SHELL=/bin/sh" + "HDAPS=1" ]; installPhase = '' install -v -D -m 644 thinkpad_ec.ko "$out/lib/modules/${kernel.modDirVersion}/kernel/drivers/firmware/thinkpad_ec.ko" install -v -D -m 644 tp_smapi.ko "$out/lib/modules/${kernel.modDirVersion}/kernel/drivers/firmware/tp_smapi.ko" + install -v -D -m 644 hdaps.ko "$out/lib/modules/${kernel.modDirVersion}/kernel/drivers/firmware/hdaps.ko" ''; dontStrip = true; From 28dd1158ff18def37892677a9eef109ce5147b81 Mon Sep 17 00:00:00 2001 From: Frank Doepper Date: Tue, 5 Sep 2017 09:24:30 +0200 Subject: [PATCH 12/18] circumvent hdaps name clash --- pkgs/os-specific/linux/tp_smapi/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/os-specific/linux/tp_smapi/default.nix b/pkgs/os-specific/linux/tp_smapi/default.nix index 2da828888040..4fc14a04eeab 100644 --- a/pkgs/os-specific/linux/tp_smapi/default.nix +++ b/pkgs/os-specific/linux/tp_smapi/default.nix @@ -24,7 +24,7 @@ stdenv.mkDerivation rec { installPhase = '' install -v -D -m 644 thinkpad_ec.ko "$out/lib/modules/${kernel.modDirVersion}/kernel/drivers/firmware/thinkpad_ec.ko" install -v -D -m 644 tp_smapi.ko "$out/lib/modules/${kernel.modDirVersion}/kernel/drivers/firmware/tp_smapi.ko" - install -v -D -m 644 hdaps.ko "$out/lib/modules/${kernel.modDirVersion}/kernel/drivers/firmware/hdaps.ko" + install -v -D -m 644 hdaps.ko "$out/lib/modules/${kernel.modDirVersion}/kernel/drivers/firmware/hdapsd.ko" ''; dontStrip = true; From 1787043323491a8fa0d431e405f8127b4e19e2c3 Mon Sep 17 00:00:00 2001 From: Ruben Maher Date: Wed, 20 Sep 2017 10:09:15 +0930 Subject: [PATCH 13/18] flow: 0.54.0 -> 0.55.0 --- pkgs/development/tools/analysis/flow/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/development/tools/analysis/flow/default.nix b/pkgs/development/tools/analysis/flow/default.nix index 26e81916774b..cbf890ab1ec6 100644 --- a/pkgs/development/tools/analysis/flow/default.nix +++ b/pkgs/development/tools/analysis/flow/default.nix @@ -3,14 +3,14 @@ with lib; stdenv.mkDerivation rec { - version = "0.54.0"; + version = "0.55.0"; name = "flow-${version}"; src = fetchFromGitHub { owner = "facebook"; repo = "flow"; rev = "v${version}"; - sha256 = "02z3jrfrr6gn056wplwkhymd1nyncjs67yl3vhv6n27jr3572npn"; + sha256 = "042q2197m9l7r6j053dd4hqaqv7dsc5wh8h6aifkcmqa4ypp4w5r"; }; installPhase = '' From f170dbe16f70a83de49a07e2291e0ab30f806104 Mon Sep 17 00:00:00 2001 From: Peter Hoeg Date: Wed, 20 Sep 2017 08:50:00 +0800 Subject: [PATCH 14/18] syncthing: 0.14.37 -> 0.14.38 --- pkgs/applications/networking/syncthing/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/networking/syncthing/default.nix b/pkgs/applications/networking/syncthing/default.nix index e82bd462fe32..4e3f0a684239 100644 --- a/pkgs/applications/networking/syncthing/default.nix +++ b/pkgs/applications/networking/syncthing/default.nix @@ -1,14 +1,14 @@ { stdenv, lib, fetchFromGitHub, go, procps, removeReferencesTo }: stdenv.mkDerivation rec { - version = "0.14.37"; + version = "0.14.38"; name = "syncthing-${version}"; src = fetchFromGitHub { owner = "syncthing"; repo = "syncthing"; rev = "v${version}"; - sha256 = "0mk09m5wc6g7w65cf86rrvzb2gfzbg4jrkwpsabn732iyhkkaj4z"; + sha256 = "0afid083azvrihv1v2cas09dprr2fflmj9gi7iy18gvwy2pg0jj8"; }; buildInputs = [ go removeReferencesTo ]; From c1de354a3db238ddd1c125a77fd931566b2dda47 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= Date: Wed, 20 Sep 2017 02:48:25 +0100 Subject: [PATCH 15/18] libwebsockets: revert making libuv a propagated build input it is possible to use libwebsockets without libuv cc @volth --- pkgs/development/libraries/libwebsockets/default.nix | 3 +-- pkgs/servers/mqtt/mosquitto/default.nix | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/pkgs/development/libraries/libwebsockets/default.nix b/pkgs/development/libraries/libwebsockets/default.nix index 0953a915a2c8..98f3ea1679cb 100644 --- a/pkgs/development/libraries/libwebsockets/default.nix +++ b/pkgs/development/libraries/libwebsockets/default.nix @@ -11,8 +11,7 @@ stdenv.mkDerivation rec { sha256 = "1hv2b5r6sg42xnqhm4ysjvyiz3cqpfmwaqm33vpbx0k7arj4ixvy"; }; - buildInputs = [ cmake openssl zlib ]; - propagatedBuildInputs = [ libuv ]; + buildInputs = [ cmake openssl zlib libuv ]; cmakeFlags = [ "-DLWS_WITH_PLUGINS=ON" ]; meta = { diff --git a/pkgs/servers/mqtt/mosquitto/default.nix b/pkgs/servers/mqtt/mosquitto/default.nix index 782581b860a9..b0e05aa8bc0a 100644 --- a/pkgs/servers/mqtt/mosquitto/default.nix +++ b/pkgs/servers/mqtt/mosquitto/default.nix @@ -1,4 +1,4 @@ -{ stdenv, fetchurl, openssl, libuuid, cmake, libwebsockets, c-ares }: +{ stdenv, fetchurl, openssl, libuuid, cmake, libwebsockets, c-ares, libuv }: stdenv.mkDerivation rec { pname = "mosquitto"; @@ -11,7 +11,7 @@ stdenv.mkDerivation rec { sha256 = "1la2577h7hcyj7lq26vizj0sh2zmi9m7nbxjp3aalayi66kiysqm"; }; - buildInputs = [ openssl libuuid libwebsockets c-ares ] + buildInputs = [ openssl libuuid libwebsockets c-ares libuv ] ++ stdenv.lib.optional stdenv.isDarwin cmake; makeFlags = [ From 100db4fa3b3ba5906350fb1d5f157e0a3a3b2ef1 Mon Sep 17 00:00:00 2001 From: John Ericson Date: Wed, 20 Sep 2017 00:56:05 -0400 Subject: [PATCH 16/18] vim: Properly categorize pkgconfig dependency --- pkgs/applications/editors/vim/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/editors/vim/default.nix b/pkgs/applications/editors/vim/default.nix index 4eefb207fd75..2f110749277c 100644 --- a/pkgs/applications/editors/vim/default.nix +++ b/pkgs/applications/editors/vim/default.nix @@ -18,9 +18,9 @@ stdenv.mkDerivation rec { inherit (common) version src postPatch hardeningDisable enableParallelBuilding meta; - buildInputs = [ ncurses pkgconfig ] + nativeBuildInputs = [ gettext pkgconfig ]; + buildInputs = [ ncurses ] ++ stdenv.lib.optionals hostPlatform.isDarwin [ Carbon Cocoa ]; - nativeBuildInputs = [ gettext ]; configureFlags = [ "--enable-multibyte" From e19bb868dc55265cf99bb00ab542f96110b9cf6e Mon Sep 17 00:00:00 2001 From: John Ericson Date: Tue, 19 Sep 2017 20:24:43 -0400 Subject: [PATCH 17/18] all-packages: Remove `forcedNativePackages`; we no longer need it Its kept around in the Hurd package set, but all that code is presumably broken. --- pkgs/os-specific/gnu/default.nix | 11 +++++++++-- pkgs/top-level/all-packages.nix | 17 ++++------------- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/pkgs/os-specific/gnu/default.nix b/pkgs/os-specific/gnu/default.nix index 247c73e468d0..fb3796394e81 100644 --- a/pkgs/os-specific/gnu/default.nix +++ b/pkgs/os-specific/gnu/default.nix @@ -3,15 +3,22 @@ args@{ fetchgit, stdenv, autoconf, automake, automake111x, libtool , texinfo, glibcCross, hurdPartedCross, libuuid, samba , gccCrossStageStatic, gccCrossStageFinal -, forcedNativePackages, forceSystem, newScope, platform, config +, forceSystem, newScope, platform, config , targetPlatform, buildPlatform -, overrides ? {} }: +, overrides ? {} +, buildPackages, pkgs +}: with args; let callPackage = newScope gnu; + forcedNativePackages = + if stdenv.hostPlatform == stdenv.buildPlatform + then pkgs + else buildPackages; + gnu = { hurdCross = forcedNativePackages.callPackage ./hurd { inherit fetchgit stdenv autoconf libtool texinfo diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 068fa3230d63..311b6c85df48 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -29,8 +29,6 @@ with pkgs; callPackage_i686 = pkgsi686Linux.callPackage; - forcedNativePackages = if hostPlatform == buildPlatform then pkgs else buildPackages; - # A stdenv capable of building 32-bit binaries. On x86_64-linux, # it uses GCC compiled with multilib support; on i686-linux, it's # just the plain stdenv. @@ -5428,34 +5426,27 @@ with pkgs; else if targetPlatform.libc == "libSystem" then darwin.xcode else null; in wrapCCCross { - cc = forcedNativePackages.gcc.cc.override { + cc = gcc.cc.override { crossStageStatic = true; langCC = false; libcCross = libcCross1; enableShared = false; # Why is this needed? - inherit (forcedNativePackages) binutils; }; libc = libcCross1; - inherit (forcedNativePackages) binutils; }; # Only needed for mingw builds gccCrossMingw2 = assert targetPlatform != buildPlatform; wrapCCCross { cc = gccCrossStageStatic.gcc; libc = windows.mingw_headers2; - inherit (forcedNativePackages) binutils; }; gccCrossStageFinal = assert targetPlatform != buildPlatform; wrapCCCross { - cc = forcedNativePackages.gcc.cc.override { + cc = gcc.cc.override { crossStageStatic = false; - - # Why is this needed? - inherit (forcedNativePackages) binutils; }; libc = libcCross; - inherit (forcedNativePackages) binutils; }; gcc45 = lowPrio (wrapCC (callPackage ../development/compilers/gcc/4.5 { @@ -6232,7 +6223,7 @@ with pkgs; wrapCCCross = {cc, libc, binutils, name ? "gcc-cross-wrapper"}: - forcedNativePackages.ccWrapperFun { + ccWrapperFun { nativeTools = false; nativeLibc = false; noLibc = (libc == null); @@ -7334,7 +7325,7 @@ with pkgs; cross_renaming: we should make all programs use pkgconfig as nativeBuildInput after the renaming. */ - pkgconfig = forcedNativePackages.callPackage ../development/tools/misc/pkgconfig { + pkgconfig = callPackage ../development/tools/misc/pkgconfig { fetchurl = fetchurlBoot; }; pkgconfigUpstream = lowPrio (pkgconfig.override { vanilla = true; }); From 1fc12241edb27fc9bb40b2c191f2718493a7f895 Mon Sep 17 00:00:00 2001 From: John Ericson Date: Tue, 19 Sep 2017 22:09:45 -0400 Subject: [PATCH 18/18] all-packages: get rid of wrapCCCross It's unneeded --- .../compilers/emscripten-fastcomp/default.nix | 12 ++-- pkgs/top-level/all-packages.nix | 67 +++++++++---------- 2 files changed, 41 insertions(+), 38 deletions(-) diff --git a/pkgs/development/compilers/emscripten-fastcomp/default.nix b/pkgs/development/compilers/emscripten-fastcomp/default.nix index e543f799495f..5d952073740e 100644 --- a/pkgs/development/compilers/emscripten-fastcomp/default.nix +++ b/pkgs/development/compilers/emscripten-fastcomp/default.nix @@ -4,10 +4,14 @@ let self = { emscriptenfastcomp-unwrapped = callPackage ./emscripten-fastcomp.nix {}; - emscriptenfastcomp-wrapped = wrapCCWith stdenv.cc.libc '' - # hardening flags break WASM support - cat > $out/nix-support/add-hardening.sh - '' self.emscriptenfastcomp-unwrapped; + emscriptenfastcomp-wrapped = wrapCCWith { + cc = self.emscriptenfastcomp-unwrapped; + libc = stdenv.cc.libc; + extraBuildCommands = '' + # hardening flags break WASM support + cat > $out/nix-support/add-hardening.sh + ''; + }; emscriptenfastcomp = symlinkJoin { name = "emscriptenfastcomp"; paths = [ self.emscriptenfastcomp-wrapped self.emscriptenfastcomp-unwrapped ]; diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 311b6c85df48..60a3bc8394df 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -5388,17 +5388,22 @@ with pkgs; }; wrapCCMulti = cc: - if system == "x86_64-linux" then lowPrio ( - let - extraBuildCommands = '' - echo "dontMoveLib64=1" >> $out/nix-support/setup-hook - ''; - in wrapCCWith glibc_multi extraBuildCommands (cc.cc.override { - stdenv = overrideCC stdenv (wrapCCWith glibc_multi "" cc.cc); + if system == "x86_64-linux" then lowPrio (wrapCCWith { + cc = cc.cc.override { + stdenv = overrideCC stdenv (wrapCCWith { + cc = cc.cc; + libc = glibc_multi; + }); profiledCompiler = false; enableMultilib = true; - })) - else throw "Multilib ${cc.name} not supported on ‘${system}’"; + }; + + libc = glibc_multi; + + extraBuildCommands = '' + echo "dontMoveLib64=1" >> $out/nix-support/setup-hook + ''; + }) else throw "Multilib ${cc.name} not supported on ‘${system}’"; gcc_multi = wrapCCMulti gcc; @@ -5425,7 +5430,8 @@ with pkgs; if targetPlatform.libc == "msvcrt" then __targetPackages.windows.mingw_w64_headers else if targetPlatform.libc == "libSystem" then darwin.xcode else null; - in wrapCCCross { + in wrapCCWith { + name = "gcc-cross-wrapper"; cc = gcc.cc.override { crossStageStatic = true; langCC = false; @@ -5437,12 +5443,14 @@ with pkgs; }; # Only needed for mingw builds - gccCrossMingw2 = assert targetPlatform != buildPlatform; wrapCCCross { + gccCrossMingw2 = assert targetPlatform != buildPlatform; wrapCCWith { + name = "gcc-cross-wrapper"; cc = gccCrossStageStatic.gcc; libc = windows.mingw_headers2; }; - gccCrossStageFinal = assert targetPlatform != buildPlatform; wrapCCCross { + gccCrossStageFinal = assert targetPlatform != buildPlatform; wrapCCWith { + name = "gcc-cross-wrapper"; cc = gcc.cc.override { crossStageStatic = false; }; @@ -6198,19 +6206,24 @@ with pkgs; wla-dx = callPackage ../development/compilers/wla-dx { }; - wrapCCWith = libc: extraBuildCommands: baseCC: ccWrapperFun { - nativeTools = stdenv.cc.nativeTools or false; - nativeLibc = stdenv.cc.nativeLibc or false; + wrapCCWith = { name ? "", cc, libc, extraBuildCommands ? "" }: ccWrapperFun { + nativeTools = targetPlatform == hostPlatform && stdenv.cc.nativeTools or false; + nativeLibc = targetPlatform == hostPlatform && stdenv.cc.nativeLibc or false; nativePrefix = stdenv.cc.nativePrefix or ""; - cc = baseCC; - isGNU = baseCC.isGNU or false; - isClang = baseCC.isClang or false; - inherit libc extraBuildCommands; + noLibc = (libc == null); + + isGNU = cc.isGNU or false; + isClang = cc.isClang or false; + + inherit name cc libc extraBuildCommands; }; ccWrapperFun = callPackage ../build-support/cc-wrapper; - wrapCC = wrapCCWith stdenv.cc.libc ""; + wrapCC = cc: wrapCCWith { + inherit cc; + inherit (stdenv.cc) libc; + }; # legacy version, used for gnat bootstrapping wrapGCC-old = baseGCC: callPackage ../build-support/gcc-wrapper-old { nativeTools = stdenv.cc.nativeTools or false; @@ -6220,20 +6233,6 @@ with pkgs; libc = glibc; }; - wrapCCCross = - {cc, libc, binutils, name ? "gcc-cross-wrapper"}: - - ccWrapperFun { - nativeTools = false; - nativeLibc = false; - noLibc = (libc == null); - - isGNU = cc.isGNU or false; - isClang = cc.isClang or false; - - inherit cc binutils libc name; - }; - # prolog yap = callPackage ../development/compilers/yap { };