JakeHillion/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go_1_17: enable on x86_64-darwin

Browse Source 
Apparently this does not depend on stdenv's macOS SDK at all,
and carries around its own go-specific toolchain. So this works
fine as-is and doesn't need any changes in Nixpkgs to support a
10.13 deployment target.
This commit is contained in:
Ryan Burns 2021-11-04 10:42:10 -07:00
parent 642292c85d
commit e1fad6fc50
2 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkgs/development/compilers/go/1.17.nix
View File

@ -273,7 +273,5 @@ stdenv.mkDerivation rec {
license = licenses.bsd3;
maintainers = teams.golang.members;
platforms = platforms.linux ++ platforms.darwin;
# requires >=10.13 stdenv on x86_64-darwin
badPlatforms = [ "x86_64-darwin" ];
};
}

10
pkgs/top-level/all-packages.nix
View File

@ -20228,9 +20228,8 @@ with pkgs;
go = buildPackages.go_1_16;
};
# go_1_17 has go module changes which may not be portable
# across different go versions and/or platforms,
# it also requires >=10.13 stdenv on darwin which
# is not currently available for x86_64-darwin
# across different go versions and/or platforms:
# https://github.com/NixOS/nixpkgs/issues/144667
#
# do not uncomment this without approval from the go CODEOWNERS
#buildGo117Package = callPackage ../development/go-packages/generic {
@ -20246,9 +20245,8 @@ with pkgs;
go = buildPackages.go_1_16;
};
# go_1_17 has go module changes which may not be portable
# across different go versions and/or platforms,
# it also requires >=10.13 stdenv on darwin which
# is not currently available for x86_64-darwin
# across different go versions and/or platforms:
# https://github.com/NixOS/nixpkgs/issues/144667
#
# do not uncomment this without approval from the go CODEOWNERS
#buildGo117Module = callPackage ../development/go-modules/generic {