From dfa28951818189a983079bacbbc06d92a584e953 Mon Sep 17 00:00:00 2001 From: Matthew Bauer Date: Wed, 13 Jun 2018 18:38:40 -0400 Subject: [PATCH] androidndk: fixup asm linking MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This fixes cross compiling to android that is currently broken. The asm symlink needs to be set on versions /newer/ than 10e not the other way around. We also need to use hostInfo’s triple here because ... /cc @ericson2314 @bkchr --- pkgs/development/mobile/androidenv/androidndk-pkgs.nix | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkgs/development/mobile/androidenv/androidndk-pkgs.nix b/pkgs/development/mobile/androidenv/androidndk-pkgs.nix index 1323466ea865..9541d62e1601 100644 --- a/pkgs/development/mobile/androidenv/androidndk-pkgs.nix +++ b/pkgs/development/mobile/androidenv/androidndk-pkgs.nix @@ -110,7 +110,8 @@ rec { mkdir -p $out cp -r ${includePath} $out/include chmod +w $out/include - ${lib.optionalString (lib.versionOlder buildAndroidndk.version "10e") "ln -s $out/include/${targetInfo.triple}/asm $out/include/asm"} + ${lib.optionalString (lib.versionOlder "10e" buildAndroidndk.version) + "ln -s $out/include/${hostInfo.triple}/asm $out/include/asm"} ln -s ${libPath} $out/lib ''; }