From 32b8c88ce4e37febc7b9e3d44c370921a2fa7ee6 Mon Sep 17 00:00:00 2001 From: Jan Tojnar Date: Sun, 1 Dec 2019 02:07:45 +0100 Subject: [PATCH 1/2] Revert "environment.noXlibs: do not pull gobject-introspection" gobject-introspection has nothing to do with graphical systems or GNOME, it is needed for language bindings like Python. This reverts commit d757135c058295c80ff998879df3d5e07b783717 --- nixos/modules/config/no-x-libs.nix | 1 - 1 file changed, 1 deletion(-) diff --git a/nixos/modules/config/no-x-libs.nix b/nixos/modules/config/no-x-libs.nix index d0f62d05870a..873b8073fed9 100644 --- a/nixos/modules/config/no-x-libs.nix +++ b/nixos/modules/config/no-x-libs.nix @@ -35,7 +35,6 @@ with lib; networkmanager-vpnc = super.networkmanager-vpnc.override { withGnome = false; }; networkmanager-iodine = super.networkmanager-iodine.override { withGnome = false; }; gobject-introspection = super.gobject-introspection.override { x11Support = false; }; - polkit = super.polkit.override { withGnome = false; }; })); }; } From 4cb7f43d3a96f9d7132cb422be17626e3d5f44f7 Mon Sep 17 00:00:00 2001 From: Jan Tojnar Date: Sun, 1 Dec 2019 02:12:43 +0100 Subject: [PATCH 2/2] polkit: rename misleading flag gobject-introspection has nothing to do with graphical systems or GNOME, it is needed for language bindings like Python. --- pkgs/development/libraries/polkit/default.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/development/libraries/polkit/default.nix b/pkgs/development/libraries/polkit/default.nix index d0df41c3e5ff..17163c2206cd 100644 --- a/pkgs/development/libraries/polkit/default.nix +++ b/pkgs/development/libraries/polkit/default.nix @@ -2,7 +2,7 @@ , intltool, spidermonkey_60 , gobject-introspection, libxslt, docbook_xsl, dbus , docbook_xml_dtd_412, gtk-doc, coreutils , useSystemd ? (stdenv.isLinux && !stdenv.hostPlatform.isMusl), systemd, elogind -, withGnome ? true +, withIntrospection ? true # A few tests currently fail on musl (polkitunixusertest, polkitunixgrouptest, polkitidentitytest segfault). # Not yet investigated; it may be due to the "Make netgroup support optional" # patch not updating the tests correctly yet, or doing something wrong, @@ -57,7 +57,7 @@ stdenv.mkDerivation rec { [ expat pam spidermonkey_60 ] # On Linux, fall back to elogind when systemd support is off. ++ stdenv.lib.optional stdenv.isLinux (if useSystemd then systemd else elogind) - ++ stdenv.lib.optional withGnome gobject-introspection; + ++ stdenv.lib.optional withIntrospection gobject-introspection; propagatedBuildInputs = [ glib # in .pc Requires @@ -86,7 +86,7 @@ stdenv.mkDerivation rec { "--with-systemdsystemunitdir=${placeholder "out"}/etc/systemd/system" "--with-polkitd-user=polkituser" #TODO? config.ids.uids.polkituser "--with-os-type=NixOS" # not recognized but prevents impurities on non-NixOS - (if withGnome then "--enable-introspection" else "--disable-introspection") + (if withIntrospection then "--enable-introspection" else "--disable-introspection") ] ++ stdenv.lib.optional (!doCheck) "--disable-test"; makeFlags = [