JakeHillion/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

python3Packages.ipykernel: fix build on darwin

Browse Source 
Also python34 is not supported:

979e6fd2db

nixpkgs doesn't provide python34 anymore, so pythonOlder "3.5" is always
true and can be removed.
This commit is contained in:
Dmitry Kalinkin 2020-02-24 03:30:16 -05:00
parent a850d0a83d
commit d35009ee63
No known key found for this signature in database
GPG Key ID: 5157B3EC8B2CA333
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
pkgs/development/python-modules/ipykernel/default.nix
View File

@ -16,7 +16,6 @@
buildPythonPackage rec { buildPythonPackage rec {
pname = "ipykernel"; pname = "ipykernel";
version = "5.1.4"; version = "5.1.4";
disabled = pythonOlder "3.4";
src = fetchPypi { src = fetchPypi {
inherit pname version; inherit pname version;
@ -38,12 +37,23 @@ buildPythonPackage rec {
preCheck = '' preCheck = ''
export HOME=$(mktemp -d) export HOME=$(mktemp -d)
''; '';
disabledTests = lib.optionals stdenv.isDarwin [ disabledTests = lib.optionals stdenv.isDarwin ([
# see https://github.com/NixOS/nixpkgs/issues/76197 # see https://github.com/NixOS/nixpkgs/issues/76197
"test_subprocess_print" "test_subprocess_print"
"test_subprocess_error" "test_subprocess_error"
"test_ipython_start_kernel_no_userns" "test_ipython_start_kernel_no_userns"
]; ] ++ lib.optionals (pythonOlder "3.8") [
# flaky test https://github.com/ipython/ipykernel/issues/485
"test_shutdown"
# test regression https://github.com/ipython/ipykernel/issues/486
"test_sys_path_profile_dir"
"test_save_history"
"test_help_output"
"test_write_kernel_spec"
"test_ipython_start_kernel_userns"
"ZMQDisplayPublisherTests"
]);
# Some of the tests use localhost networking. # Some of the tests use localhost networking.
__darwinAllowLocalNetworking = true; __darwinAllowLocalNetworking = true;