From cc997f28d154e6bc47eacbe3632859090fedd616 Mon Sep 17 00:00:00 2001 From: Jan Tojnar Date: Fri, 18 Oct 2019 16:06:53 +0200 Subject: [PATCH] fish: switch to fetchFromGitHub The expression claimed there are differences between the release tarball and the tarball github packages from the tag but fetchFromGitHub literally downloads the same tarball. --- pkgs/shells/fish/default.nix | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pkgs/shells/fish/default.nix b/pkgs/shells/fish/default.nix index 1ef3c4b6fd9a..4f6df766d1be 100644 --- a/pkgs/shells/fish/default.nix +++ b/pkgs/shells/fish/default.nix @@ -1,4 +1,4 @@ -{ stdenv, fetchurl, coreutils, utillinux, +{ stdenv, fetchFromGitHub, coreutils, utillinux, which, gnused, gnugrep, groff, man-db, getent, libiconv, pcre2, gettext, ncurses, python3, @@ -93,11 +93,11 @@ let etcConfigAppendix = builtins.toFile "etc-config.appendix.fish" etcConfigAppendixText; - src = fetchurl { - # There are differences between the release tarball and the tarball github packages from the tag - # Hence we cannot use fetchFromGithub - url = "https://github.com/fish-shell/fish-shell/releases/download/${version}/${pname}-${version}.tar.gz"; - sha256 = "03j3jl9jzlnhq4p86zj8wqsh5sx45j1d1fvfa80ks1cfdg68qwhl"; + src = fetchFromGitHub { + owner = "fish-shell"; + repo = "fish-shell"; + rev = version; + sha256 = "1qh6dka1ayz352ihcq4529hjgnz255gyrqs3xyif6b2ycvrm4ad5"; }; nativeBuildInputs = [ cmake ];