From 92908738385789d50b9a1f863f977631de41e92b Mon Sep 17 00:00:00 2001 From: Sean Buckley Date: Wed, 11 Aug 2021 20:14:23 -0400 Subject: [PATCH] firefox: fix enableOfficialBranding --- .../networking/browsers/firefox/common.nix | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/pkgs/applications/networking/browsers/firefox/common.nix b/pkgs/applications/networking/browsers/firefox/common.nix index 514447931f38..52d89d20ffb9 100644 --- a/pkgs/applications/networking/browsers/firefox/common.nix +++ b/pkgs/applications/networking/browsers/firefox/common.nix @@ -273,7 +273,10 @@ buildStdenv.mkDerivation ({ '') + '' # AS=as in the environment causes build failure https://bugzilla.mozilla.org/show_bug.cgi?id=1497286 unset AS - ''; + '' + (lib.optionalString enableOfficialBranding '' + export MOZILLA_OFFICIAL=1 + export BUILD_OFFICIAL=1 + ''); configureFlags = [ "--enable-application=browser" @@ -325,11 +328,7 @@ buildStdenv.mkDerivation ({ cd obj-* ''; - makeFlags = lib.optionals enableOfficialBranding [ - "MOZILLA_OFFICIAL=1" - "BUILD_OFFICIAL=1" - ] - ++ lib.optionals ltoSupport [ + makeFlags = lib.optionals ltoSupport [ "AR=${buildStdenv.cc.bintools.bintools}/bin/llvm-ar" "LLVM_OBJDUMP=${buildStdenv.cc.bintools.bintools}/bin/llvm-objdump" "NM=${buildStdenv.cc.bintools.bintools}/bin/llvm-nm"