Merge pull request #26416 from lverns/make-genericName-optional

make-desktopitem: make genericName optional

pkgs/build-support/make-desktopitem/default.nix

@@ -1,36 +1,48 @@
-{stdenv}:
+{stdenv, lib}:
 { name
 , type ? "Application"
 , exec
-, icon ? ""
+, icon ? null
-, comment ? ""
+, comment ? null
 , terminal ? "false"
 , desktopName
-, genericName
+, genericName ? null
-, mimeType ? ""
+, mimeType ? null
 , categories ? "Application;Other;"
 , startupNotify ? null
-, extraEntries ? ""
+, extraEntries ? null
 }:
 
 stdenv.mkDerivation {
   name = "${name}.desktop";
-  buildCommand = ''
+
+  buildCommand = let
+
+   optionalEntriesList = [{k="Icon";          v=icon;}
+                          {k="Comment";       v=comment;}
+                          {k="GenericName";   v=genericName;}
+                          {k="MimeType";      v=mimeType;}
+                          {k="StartupNotify"; v=startupNotify;}];
+
+   valueNotNull = {k, v}: v != null;
+   entriesToKeep = builtins.filter valueNotNull optionalEntriesList;
+
+   mkEntry = {k, v}:  k + "=" + v;
+   optionalEntriesString  = lib.concatMapStringsSep "\n" mkEntry entriesToKeep;
+
+  in
+  ''
     mkdir -p $out/share/applications
     cat > $out/share/applications/${name}.desktop <<EOF
     [Desktop Entry]
     Type=${type}
     Exec=${exec}
-    Icon=${icon}
-    Comment=${comment}
     Terminal=${terminal}
     Name=${desktopName}
-    GenericName=${genericName}
-    MimeType=${mimeType}
     Categories=${categories}
+    ${optionalEntriesString}
+    ${if extraEntries == null then ''EOF'' else ''
     ${extraEntries}
-    ${if startupNotify == null then ''EOF'' else ''
-    StartupNotify=${startupNotify}
     EOF''}
   '';
 }