From aa5a07977e8e8454e6cd2334cbe3b2fb473f598e Mon Sep 17 00:00:00 2001 From: xeji Date: Thu, 8 Mar 2018 12:14:43 +0100 Subject: [PATCH] v8: build with gcc6 on linux doesn't build with gcc 7 due to this issue in upstream code: https://bugs.chromium.org/p/chromium/issues/detail?id=614289 --- pkgs/top-level/all-packages.nix | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index e97a4d38acbb..5f4f07cbf0dd 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -11595,11 +11595,14 @@ with pkgs; inherit (python2Packages) python; }; - v8 = callPackage ../development/libraries/v8 { + v8 = callPackage ../development/libraries/v8 ({ inherit (python2Packages) python gyp; cctools = darwin.cctools; icu = icu58; # v8-5.4.232 fails against icu4c-59.1 - }; + } // lib.optionalAttrs stdenv.isLinux { + # doesn't build with gcc7 + stdenv = overrideCC stdenv gcc6; + }); v8_static = lowPrio (self.v8.override { static = true; });