From 9f52d1f2342a5c28c36ee3a67953f4f713077235 Mon Sep 17 00:00:00 2001 From: rnhmjoj Date: Tue, 22 Dec 2020 10:17:32 +0100 Subject: [PATCH] Revert "nixos/wireless: fix failure with no interfaces" This reverts commit 8f177612b14063b644288a5a1058bf47f44b43a5. Attempting to start any service from udev when systemd-udev-settle is used at all hangs the boot for 2min. See issue #107341. --- nixos/modules/services/networking/wpa_supplicant.nix | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/nixos/modules/services/networking/wpa_supplicant.nix b/nixos/modules/services/networking/wpa_supplicant.nix index 3cfcb535ef5b..395139879036 100644 --- a/nixos/modules/services/networking/wpa_supplicant.nix +++ b/nixos/modules/services/networking/wpa_supplicant.nix @@ -233,10 +233,9 @@ in { path = [ pkgs.wpa_supplicant ]; script = '' - if [ -f /etc/wpa_supplicant.conf -a "/etc/wpa_supplicant.conf" != "${configFile}" ]; then - echo >&2 "<3>/etc/wpa_supplicant.conf present but ignored. Generated ${configFile} is used instead." + if [ -f /etc/wpa_supplicant.conf -a "/etc/wpa_supplicant.conf" != "${configFile}" ] + then echo >&2 "<3>/etc/wpa_supplicant.conf present but ignored. Generated ${configFile} is used instead." fi - iface_args="-s -u -D${cfg.driver} -c ${configFile}" ${if ifaces == [] then '' for i in $(cd /sys/class/net && echo *); do @@ -249,10 +248,6 @@ in { fi fi done - if [ -z "$args" ]; then - echo >&2 "<3>No wireless interfaces detected (yet)." - exit 1 - fi '' else '' args="${concatMapStringsSep " -N " (i: "-i${i} $iface_args") ifaces}" ''} @@ -266,7 +261,7 @@ in { # Restart wpa_supplicant when a wlan device appears or disappears. services.udev.extraRules = '' - ACTION=="add|remove", SUBSYSTEM=="net", ENV{DEVTYPE}=="wlan", RUN+="/run/current-system/systemd/bin/systemctl restart wpa_supplicant.service" + ACTION=="add|remove", SUBSYSTEM=="net", ENV{DEVTYPE}=="wlan", RUN+="/run/current-system/systemd/bin/systemctl try-restart wpa_supplicant.service" ''; };