x265: build a single shared library for all bit-depths

This builds the 10-bit and 12-bit versions of x265 as static
libraries, which then get linked into the 8-bit dynamic library and
executable. This causes x265 to default to 8-bit, but make 10- and
12-bit available to callers that use introspection, such as ffmpeg.

    $ x265 -V
    x265 [info]: HEVC encoder version 3.2
    x265 [info]: build info [Linux][GCC 9.3.0][64 bit] 8bit+10bit+12bit
    x265 [info]: using cpu capabilities: MMX2 SSE2Fast LZCNT SSSE3 SSE4.2 AVX FMA3 BMI2 AVX2

    $ ffmpeg -h encoder=libx265
    [...]
        Supported pixel formats: yuv420p yuvj420p yuv422p yuvj422p yuv444p yuvj444p gbrp yuv420p10le yuv422p10le yuv444p10le gbrp10le yuv420p12le yuv422p12le yuv444p12le gbrp12le gray gray10le gray12le

Inspired by @codyopel's comment on #80405.
This commit is contained in:
Dominik Honnef 2020-07-02 16:33:53 +02:00 committed by Frederik Rietdijk
parent d59c57f8a6
commit 90cd27e4a0

View File

@ -1,7 +1,6 @@
{ stdenv, fetchurl, fetchpatch, cmake, nasm, numactl { stdenv, fetchurl, fetchpatch, cmake, nasm, numactl
, numaSupport ? stdenv.hostPlatform.isLinux && (stdenv.hostPlatform.isx86 || stdenv.hostPlatform.isAarch64) # Enabled by default on NUMA platforms , numaSupport ? stdenv.hostPlatform.isLinux && (stdenv.hostPlatform.isx86 || stdenv.hostPlatform.isAarch64) # Enabled by default on NUMA platforms
, debugSupport ? false # Run-time sanity checks (debugging) , debugSupport ? false # Run-time sanity checks (debugging)
, highbitdepthSupport ? false # false=8bits per channel, true=10/12bits per channel
, werrorSupport ? false # Warnings as errors , werrorSupport ? false # Warnings as errors
, ppaSupport ? false # PPA profiling instrumentation , ppaSupport ? false # PPA profiling instrumentation
, vtuneSupport ? false # Vtune profiling instrumentation , vtuneSupport ? false # Vtune profiling instrumentation
@ -13,10 +12,17 @@
let let
mkFlag = optSet: flag: if optSet then "-D${flag}=ON" else "-D${flag}=OFF"; mkFlag = optSet: flag: if optSet then "-D${flag}=ON" else "-D${flag}=OFF";
inherit (stdenv) is64bit; inherit (stdenv) is64bit;
in
stdenv.mkDerivation rec { cmakeFlagsAll = [
pname = "x265"; "-DSTATIC_LINK_CRT=OFF"
(mkFlag debugSupport "CHECKED_BUILD")
(mkFlag ppaSupport "ENABLE_PPA")
(mkFlag vtuneSupport "ENABLE_VTUNE")
(mkFlag custatsSupport "DETAILED_CU_STATS")
(mkFlag unittestsSupport "ENABLE_TESTS")
(mkFlag werrorSupport "WARNINGS_AS_ERRORS")
];
version = "3.2"; version = "3.2";
src = fetchurl { src = fetchurl {
@ -27,8 +33,6 @@ stdenv.mkDerivation rec {
sha256 = "0fqkhfhr22gzavxn60cpnj3agwdf5afivszxf3haj5k1sny7jk9n"; sha256 = "0fqkhfhr22gzavxn60cpnj3agwdf5afivszxf3haj5k1sny7jk9n";
}; };
enableParallelBuilding = true;
patches = [ patches = [
# Fix build on ARM (#406) # Fix build on ARM (#406)
(fetchpatch { (fetchpatch {
@ -37,22 +41,54 @@ stdenv.mkDerivation rec {
}) })
]; ];
buildLib = has12Bit: stdenv.mkDerivation rec {
name = "libx265-${if has12Bit then "12" else "10"}-${version}";
inherit src patches;
enableParallelBuilding = true;
postPatch = ''
sed -i 's/unknown/${version}/g' source/cmake/version.cmake
'';
cmakeLibFlags = [
"-DENABLE_CLI=OFF"
"-DENABLE_SHARED=OFF"
"-DENABLE_HDR10_PLUS=ON"
"-DEXPORT_C_API=OFF"
"-DHIGH_BIT_DEPTH=ON"
];
cmakeFlags = [(mkFlag has12Bit "MAIN12")] ++ cmakeLibFlags ++ cmakeFlagsAll;
preConfigure = ''
cd source
'';
nativeBuildInputs = [cmake nasm] ++ stdenv.lib.optional numaSupport numactl;
};
libx265-10 = buildLib false;
libx265-12 = buildLib true;
in
stdenv.mkDerivation rec {
pname = "x265";
inherit version src patches;
enableParallelBuilding = true;
postPatch = '' postPatch = ''
sed -i 's/unknown/${version}/g' source/cmake/version.cmake sed -i 's/unknown/${version}/g' source/cmake/version.cmake
''; '';
cmakeFlags = [ cmakeFlags = [
(mkFlag debugSupport "CHECKED_BUILD")
"-DSTATIC_LINK_CRT=OFF"
(mkFlag (highbitdepthSupport && is64bit) "HIGH_BIT_DEPTH")
(mkFlag werrorSupport "WARNINGS_AS_ERRORS")
(mkFlag ppaSupport "ENABLE_PPA")
(mkFlag vtuneSupport "ENABLE_VTUNE")
(mkFlag custatsSupport "DETAILED_CU_STATS")
"-DENABLE_SHARED=ON" "-DENABLE_SHARED=ON"
"-DHIGH_BIT_DEPTH=OFF"
"-DENABLE_HDR10_PLUS=OFF"
"-DEXTRA_LIB=${libx265-10}/lib/libx265.a;${libx265-12}/lib/libx265.a"
"-DLINKED_10BIT=ON"
"-DLINKED_12BIT=ON"
(mkFlag cliSupport "ENABLE_CLI") (mkFlag cliSupport "ENABLE_CLI")
(mkFlag unittestsSupport "ENABLE_TESTS") ] ++ cmakeFlagsAll;
];
preConfigure = '' preConfigure = ''
cd source cd source