From 6091e2aa3355ac0cab30ef024b9d977111d479d8 Mon Sep 17 00:00:00 2001 From: Florian Jacob Date: Thu, 5 Oct 2017 15:05:30 +0200 Subject: [PATCH] nixos/network-interfaces: assertion for too long interface names --- nixos/modules/tasks/network-interfaces.nix | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/nixos/modules/tasks/network-interfaces.nix b/nixos/modules/tasks/network-interfaces.nix index 8ce7b2d2cf36..1741d2c7e1f7 100644 --- a/nixos/modules/tasks/network-interfaces.nix +++ b/nixos/modules/tasks/network-interfaces.nix @@ -924,6 +924,14 @@ in (flip map interfaces (i: { assertion = i.subnetMask == null; message = "The networking.interfaces.${i.name}.subnetMask option is defunct. Use prefixLength instead."; + })) ++ (flip map interfaces (i: { + # With the linux kernel, interface name length is limited by IFNAMSIZ + # to 16 bytes, including the trailing null byte. + # See include/linux/if.h in the kernel sources + assertion = stringLength i.name < 16; + message = '' + The name of networking.interfaces."${i.name}" is too long, it needs to be less than 16 characters. + ''; })) ++ (flip map slaveIfs (i: { assertion = i.ip4 == [ ] && i.ipAddress == null && i.ip6 == [ ] && i.ipv6Address == null; message = "The networking.interfaces.${i.name} must not have any defined ips when it is a slave.";