From 83374dea0f28380d691e819cd14a4d52b5e76266 Mon Sep 17 00:00:00 2001 From: "R. RyanTM" Date: Wed, 11 Nov 2020 19:18:50 +0000 Subject: [PATCH 1/4] opustags: 1.4.0 -> 1.5.0 --- pkgs/applications/audio/opustags/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/audio/opustags/default.nix b/pkgs/applications/audio/opustags/default.nix index 8e5546aec8b6..18a9402bdf40 100644 --- a/pkgs/applications/audio/opustags/default.nix +++ b/pkgs/applications/audio/opustags/default.nix @@ -1,13 +1,13 @@ { stdenv, lib, cmake, pkgconfig, libogg, fetchFromGitHub, libiconv }: stdenv.mkDerivation rec { pname = "opustags"; - version = "1.4.0"; + version = "1.5.0"; src = fetchFromGitHub { owner = "fmang"; repo = "opustags"; rev = version; - sha256 = "1y0czl72paawy342ff9ickaamkih43k59yfcdw7bnddypyfa7nbg"; + sha256 = "191zx2g3lijybgcy3a4fz5l35cagdrcdr0difhcfz0zn60hwnvqc"; }; buildInputs = [ libogg ]; From 211a84e410e99389f2f6add53da1f37c0231b715 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Tue, 24 Nov 2020 18:57:53 +0100 Subject: [PATCH 2/4] opustags: 1.5.0 -> 1.5.1 --- pkgs/applications/audio/opustags/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/audio/opustags/default.nix b/pkgs/applications/audio/opustags/default.nix index 18a9402bdf40..630f7b171e8d 100644 --- a/pkgs/applications/audio/opustags/default.nix +++ b/pkgs/applications/audio/opustags/default.nix @@ -1,13 +1,13 @@ { stdenv, lib, cmake, pkgconfig, libogg, fetchFromGitHub, libiconv }: stdenv.mkDerivation rec { pname = "opustags"; - version = "1.5.0"; + version = "1.5.1"; src = fetchFromGitHub { owner = "fmang"; repo = "opustags"; rev = version; - sha256 = "191zx2g3lijybgcy3a4fz5l35cagdrcdr0difhcfz0zn60hwnvqc"; + sha256 = "1dicv4s395b9gb4jpr0rnxdq9azr45pid62q3x08lb7cvyq3yxbh"; }; buildInputs = [ libogg ]; From e0090f93e941bf915f5af832a478f101f41e2ade Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Thu, 26 Nov 2020 01:16:31 +0100 Subject: [PATCH 3/4] opustags: Fix some build failures on darwin, enable tests --- pkgs/applications/audio/opustags/default.nix | 31 ++++++++++++++++++-- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/pkgs/applications/audio/opustags/default.nix b/pkgs/applications/audio/opustags/default.nix index 630f7b171e8d..65836582feb4 100644 --- a/pkgs/applications/audio/opustags/default.nix +++ b/pkgs/applications/audio/opustags/default.nix @@ -1,4 +1,6 @@ -{ stdenv, lib, cmake, pkgconfig, libogg, fetchFromGitHub, libiconv }: +{ stdenv, fetchFromGitHub, fetchpatch, cmake, pkg-config, libiconv, libogg +, ffmpeg, glibcLocales, perl, perlPackages }: + stdenv.mkDerivation rec { pname = "opustags"; version = "1.5.1"; @@ -10,14 +12,37 @@ stdenv.mkDerivation rec { sha256 = "1dicv4s395b9gb4jpr0rnxdq9azr45pid62q3x08lb7cvyq3yxbh"; }; + patches = [ + # Fix building on darwin + (fetchpatch { + url = "https://github.com/fmang/opustags/commit/64fc6f8f6d20e034892e89abff0236c85cae98dc.patch"; + sha256 = "1djifzqhf1w51gbpqbndsh3gnl9iizp6hppxx8x2a92i9ns22zpg"; + }) + (fetchpatch { + url = "https://github.com/fmang/opustags/commit/f98208c1a1d10c15f98b127bbfdf88a7b15b08dc.patch"; + sha256 = "1h3v0r336fca0y8zq1vl2wr8gaqs3vvrrckx7pvji4k1jpiqvp38"; + }) + ]; + buildInputs = [ libogg ]; - nativeBuildInputs = [ cmake pkgconfig ] ++ lib.optional stdenv.isDarwin libiconv; + nativeBuildInputs = [ cmake pkg-config ] ++ stdenv.lib.optional stdenv.isDarwin libiconv; - meta = with lib; { + doCheck = true; + + checkInputs = [ ffmpeg glibcLocales perl ] ++ (with perlPackages; [ ListMoreUtils ]); + + checkPhase = '' + export LANG="en_US.UTF-8" + export LC_ALL="en_US.UTF-8" + make check + ''; + + meta = with stdenv.lib; { homepage = "https://github.com/fmang/opustags"; description = "Ogg Opus tags editor"; platforms = platforms.all; + broken = stdenv.isDarwin; maintainers = [ maintainers.kmein ]; license = licenses.bsd3; }; From 9796f668e28a887b810cf89d04931b9001cb211d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Thu, 26 Nov 2020 01:33:08 +0100 Subject: [PATCH 4/4] opustags: add SuperSandro2000 as maintainer --- pkgs/applications/audio/opustags/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/audio/opustags/default.nix b/pkgs/applications/audio/opustags/default.nix index 65836582feb4..4e26c9b77523 100644 --- a/pkgs/applications/audio/opustags/default.nix +++ b/pkgs/applications/audio/opustags/default.nix @@ -43,7 +43,7 @@ stdenv.mkDerivation rec { description = "Ogg Opus tags editor"; platforms = platforms.all; broken = stdenv.isDarwin; - maintainers = [ maintainers.kmein ]; + maintainers = with maintainers; [ kmein SuperSandro2000 ]; license = licenses.bsd3; }; }