From 77e081bb2b82a412b901abffb347ca4eb2e75eec Mon Sep 17 00:00:00 2001 From: Doron Behar Date: Mon, 26 Oct 2020 22:48:27 +0200 Subject: [PATCH] nixos/sddm: Use libsForQt514.sddm if needed (for lxqt) Currently lxqt is a desktop environment that's compiled against qt514. To avoid possible issues (#101369), we (hopefully) use the same qt version as the desktop environment at hand. LXQT should move to qt515, and for the long term the correct qt version should be inherited by the sddm module. --- nixos/modules/services/x11/display-managers/sddm.nix | 7 ++++++- pkgs/top-level/all-packages.nix | 3 ++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/nixos/modules/services/x11/display-managers/sddm.nix b/nixos/modules/services/x11/display-managers/sddm.nix index 4040b903426b..a39bb55b38c4 100644 --- a/nixos/modules/services/x11/display-managers/sddm.nix +++ b/nixos/modules/services/x11/display-managers/sddm.nix @@ -9,7 +9,12 @@ let cfg = dmcfg.sddm; xEnv = config.systemd.services.display-manager.environment; - inherit (pkgs) sddm; + sddm = if config.services.xserver.desktopManager.lxqt.enable then + # TODO: Move lxqt to libsForQt515 + pkgs.libsForQt514.sddm + else + pkgs.libsForQt5.sddm + ; xserverWrapper = pkgs.writeScript "xserver-wrapper" '' #!/bin/sh diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 4ac1911cbab9..93a0f316b1b7 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -25901,7 +25901,8 @@ in lumina = recurseIntoAttrs (callPackage ../desktops/lumina { }); lxqt = recurseIntoAttrs (import ../desktops/lxqt { - # TODO: Update these to qt515 at some point + # TODO: Update these to qt515 at some point. When doing it, please remove + # the choice of libsForQt5*.sddm in sddm's module. qt5 = qt514; libsForQt5 = libsForQt514; inherit pkgs;