From ec2ddf284d5d435f75a284cb3b840f15ab371741 Mon Sep 17 00:00:00 2001 From: Joachim Fasting Date: Mon, 9 May 2016 19:27:27 +0200 Subject: [PATCH 1/2] systemd: get linuxHeaders from stdenv Building against anything other than the headers used to build libc doesn't really make any sense. --- pkgs/os-specific/linux/systemd/default.nix | 3 ++- pkgs/top-level/all-packages.nix | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/os-specific/linux/systemd/default.nix b/pkgs/os-specific/linux/systemd/default.nix index d6a928cd0cfd..3af702982fb6 100644 --- a/pkgs/os-specific/linux/systemd/default.nix +++ b/pkgs/os-specific/linux/systemd/default.nix @@ -1,7 +1,8 @@ { stdenv, fetchFromGitHub, pkgconfig, intltool, gperf, libcap, kmod , zlib, xz, pam, acl, cryptsetup, libuuid, m4, utillinux, libffi , glib, kbd, libxslt, coreutils, libgcrypt, libgpgerror, libapparmor, audit, lz4 -, kexectools, libmicrohttpd, linuxHeaders, libseccomp, iptables +, kexectools, libmicrohttpd, linuxHeaders ? stdenv.cc.libc.linuxHeaders, libseccomp +, iptables , autoreconfHook, gettext, docbook_xsl, docbook_xml_dtd_42, docbook_xml_dtd_45 , enableKDbus ? false }: diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index b31b2b8c8fdb..a401ca24611e 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -11202,7 +11202,6 @@ in sysstat = callPackage ../os-specific/linux/sysstat { }; systemd = callPackage ../os-specific/linux/systemd { - linuxHeaders = linuxHeaders_3_18; utillinux = utillinuxMinimal; # break the cyclic dependency } // { From e0c07070b1fca1ec237f3a4ab04cbec0b6c75282 Mon Sep 17 00:00:00 2001 From: Joachim Fasting Date: Mon, 9 May 2016 19:28:24 +0200 Subject: [PATCH 2/2] duperemove: get linuxHeaders from stdenv Building against anything other than the headers used to build libc doesn't really make any sense. Also: this package is Linux specific, so mark it as such. --- pkgs/tools/filesystems/duperemove/default.nix | 12 ++++++------ pkgs/top-level/all-packages.nix | 4 +--- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/pkgs/tools/filesystems/duperemove/default.nix b/pkgs/tools/filesystems/duperemove/default.nix index 146414a47e10..d333334d394c 100644 --- a/pkgs/tools/filesystems/duperemove/default.nix +++ b/pkgs/tools/filesystems/duperemove/default.nix @@ -1,5 +1,5 @@ -{ lib, stdenv, fetchFromGitHub, libgcrypt -, pkgconfig, glib, linuxHeaders, sqlite }: +{ stdenv, fetchFromGitHub, libgcrypt +, pkgconfig, glib, linuxHeaders ? stdenv.cc.libc.linuxHeaders, sqlite }: stdenv.mkDerivation rec { name = "duperemove-${version}"; @@ -16,11 +16,11 @@ stdenv.mkDerivation rec { makeFlags = [ "DESTDIR=$(out)" "PREFIX=" ]; - meta = { + meta = with stdenv.lib; { description = "A simple tool for finding duplicated extents and submitting them for deduplication"; homepage = https://github.com/markfasheh/duperemove; - license = lib.licenses.gpl2; - maintainers = with lib.maintainers; [ bluescreen303 thoughtpolice ]; - platforms = lib.platforms.all; + license = licenses.gpl2; + maintainers = with maintainers; [ bluescreen303 thoughtpolice ]; + platforms = platforms.linux; }; } diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index a401ca24611e..779a1c225c7f 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -759,9 +759,7 @@ in dtrx = callPackage ../tools/compression/dtrx { }; - duperemove = callPackage ../tools/filesystems/duperemove { - linuxHeaders = linuxHeaders_3_18; - }; + duperemove = callPackage ../tools/filesystems/duperemove { }; dynamic-colors = callPackage ../tools/misc/dynamic-colors { };