glibc: remove TODO that is now done
This was preventing a mass-rebuild by returning null. As of
5f2d96ba2e
it always returns a string.
This commit is contained in:
parent
99470a3cb5
commit
569f05222c
@ -49,20 +49,12 @@ callPackage ./common.nix { inherit stdenv; } {
|
||||
++ stdenv.lib.optional stdenv.hostPlatform.isMusl "pie";
|
||||
|
||||
NIX_CFLAGS_COMPILE = stdenv.lib.concatStringsSep " "
|
||||
(if !stdenv.hostPlatform.isMusl
|
||||
# TODO: This (returning a string or `null`, instead of a list) is to
|
||||
# not trigger a mass rebuild due to the introduction of the
|
||||
# musl-specific flags below.
|
||||
# At next change to non-musl glibc builds, remove this `then`
|
||||
# and the above condition, instead keeping only the `else` below.
|
||||
then (stdenv.lib.optionals withGd gdCflags)
|
||||
else
|
||||
(builtins.concatLists [
|
||||
(stdenv.lib.optionals withGd gdCflags)
|
||||
# Fix -Werror build failure when building glibc with musl with GCC >= 8, see:
|
||||
# https://github.com/NixOS/nixpkgs/pull/68244#issuecomment-544307798
|
||||
(stdenv.lib.optional stdenv.hostPlatform.isMusl "-Wno-error=attribute-alias")
|
||||
]));
|
||||
(builtins.concatLists [
|
||||
(stdenv.lib.optionals withGd gdCflags)
|
||||
# Fix -Werror build failure when building glibc with musl with GCC >= 8, see:
|
||||
# https://github.com/NixOS/nixpkgs/pull/68244#issuecomment-544307798
|
||||
(stdenv.lib.optional stdenv.hostPlatform.isMusl "-Wno-error=attribute-alias")
|
||||
]);
|
||||
|
||||
# When building glibc from bootstrap-tools, we need libgcc_s at RPATH for
|
||||
# any program we run, because the gcc will have been placed at a new
|
||||
|
Loading…
Reference in New Issue
Block a user