JakeHillion/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libspotify: Fix build for linux.

Browse Source 
For Linux, the phases was run in the wrong order. I've
fixed that, but the package is still a complete mess that
needs to be cleaned up. The linux and darwin builds should
probably be separated into two different Nix expressions
to avoid the current conditional mess.
This commit is contained in:
Rickard Nilsson 2013-07-22 16:28:33 +02:00
parent a321f6f302
commit 3fa913d5ec
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pkgs/development/libraries/libspotify/default.nix
View File

@ -1,8 +1,8 @@
{ stdenv, fetchurl, libspotify, alsaLib, readline, pkgconfig, apiKey, unzip }:
{ stdenv, fetchurl, libspotify, alsaLib, readline, pkgconfig, apiKey, unzip, gnused }:
let version = "12.1.51"; in
if (stdenv.system == "x86_64-linux" && stdenv.system != "x86_64-darwin")
if (stdenv.system != "x86_64-linux" && stdenv.system != "x86_64-darwin")
then throw "Check https://developer.spotify.com/technologies/libspotify/ for a tarball for your system and add it here"
else stdenv.mkDerivation {
name = "libspotify-${version}";
@ -24,9 +24,10 @@ else stdenv.mkDerivation {
# common
buildPhase = "true";
# no patch or build phase for darwin
phases = [ "unpackPhase" "installPhase" ]
++ stdenv.lib.optionals (stdenv.system == "x86_64-linux")
[ "patchPhase" "buildPhase" ];
phases =
[ "unpackPhase" ] ++
(stdenv.lib.optionals (stdenv.system == "x86_64-linux") [ "patchPhase" "buildPhase" ]) ++
[ "installPhase" ];
installPhase = if (stdenv.system == "x86_64-linux")
then "installPhase"
else ''
@ -48,7 +49,7 @@ else stdenv.mkDerivation {
installFlags = stdenv.lib.optionalString (stdenv.system == "x86_64-linux")
"prefix=$(out)";
patchPhase = stdenv.lib.optionalString (stdenv.system == "x86_64-linux")
"sed -i 's/ldconfig//' Makefile";
"${gnused}/bin/sed -i 's/ldconfig//' Makefile";
postInstall = stdenv.lib.optionalString (stdenv.system == "x86_64-linux")
"mv -v share $out";