systemdMinimal: don't set {libfido2,p11-kit,libgcrypt} to null

We don't have to do that as we already set all the feature flags to
null. Setting individual libraries to null instead of disabling their
feature flag will lead with bad example that will cause each of the
features to be disabled with multiple flags in the systemdMinimal
variant.

If a dependency is pulled in via another feature we should disable that
rather than setting it to null. Overriding a given package should be the
last resort.
This commit is contained in:
Andreas Rammhold 2021-12-12 15:49:40 +01:00 committed by Florian Klink
parent 3869ce784e
commit 3ceeae830d
2 changed files with 5 additions and 7 deletions

View File

@ -61,6 +61,8 @@
, kexec-tools
, bashInteractive
, libmicrohttpd
, libfido2
, p11-kit
# the (optional) BPF feature requires bpftool, libbpf, clang and llmv-strip to be avilable during build time.
# Only libbpf should be a runtime dependency.
@ -97,8 +99,6 @@
, withTimesyncd ? true
, withTpm2Tss ? !stdenv.hostPlatform.isMusl
, withUserDb ? !stdenv.hostPlatform.isMusl
, libfido2
, p11-kit
# name argument
, pname ? "systemd"
@ -373,13 +373,13 @@ stdenv.mkDerivation {
glib
kmod
libcap
libgcrypt
libidn2
libuuid
linuxHeaders
pam
]
++ lib.optional wantGcrypt libgcrypt
++ lib.optional withApparmor libapparmor
++ lib.optional wantCurl (lib.getDev curl)
++ lib.optionals withCompression [ bzip2 lz4 xz zstd ]
@ -418,7 +418,7 @@ stdenv.mkDerivation {
# while we do not run tests we should also not build them. Removes about 600 targets
"-Dtests=false"
"-Danalyze=${lib.boolToString withAnalyze}"
"-Dgcrypt=${lib.boolToString (libgcrypt != null)}"
"-Dgcrypt=${lib.boolToString wantGcrypt}"
"-Dimportd=${lib.boolToString withImportd}"
"-Dlz4=${lib.boolToString withCompression}"
"-Dhomed=${lib.boolToString withHomed}"

View File

@ -23233,10 +23233,8 @@ with pkgs;
withTpm2Tss = false;
withUserDb = false;
glib = null;
libgcrypt = null;
lvm2 = null;
libfido2 = null;
p11-kit = null;
};