From 08aaa97b1e1b7f82d7994b8714aa57036890f199 Mon Sep 17 00:00:00 2001 From: "R. Ryantm" Date: Fri, 21 Oct 2022 17:22:11 +0000 Subject: [PATCH 01/27] gummy: 0.2 -> 0.3 --- pkgs/tools/misc/gummy/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/tools/misc/gummy/default.nix b/pkgs/tools/misc/gummy/default.nix index defe5950a116..9d5b473c3b9c 100644 --- a/pkgs/tools/misc/gummy/default.nix +++ b/pkgs/tools/misc/gummy/default.nix @@ -13,13 +13,13 @@ stdenv.mkDerivation rec { pname = "gummy"; - version = "0.2"; + version = "0.3"; src = fetchFromGitHub { owner = "fushko"; repo = "gummy"; rev = version; - sha256 = "sha256-nX5wEJ4HmgFHIgJP2MstBzQjU/9lrXOXoIl1vlolqak="; + sha256 = "sha256-dw2yOXTS61OIe+NOq8MPydhkZvTit13eC7cbL5nFseg="; }; nativeBuildInputs = [ From 713369c44b1bcf17b5d2f209bb229656ce2613bf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stanis=C5=82aw=20Pitucha?= Date: Sun, 23 Oct 2022 15:23:02 +1100 Subject: [PATCH 02/27] doc/contributing: Explicitly allow trivial changes by non-authors Discussed and proposed at https://discourse.nixos.org/t/rules-around-adding-to-someones-pr/22671/3 --- doc/contributing/reviewing-contributions.chapter.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/doc/contributing/reviewing-contributions.chapter.md b/doc/contributing/reviewing-contributions.chapter.md index 4452695a6f38..0e6a0dd5b530 100644 --- a/doc/contributing/reviewing-contributions.chapter.md +++ b/doc/contributing/reviewing-contributions.chapter.md @@ -302,6 +302,12 @@ Container system, boot system and library changes are some examples of the pull It is possible for community members that have enough knowledge and experience on a special topic to contribute by merging pull requests. +In case the PR is stuck waiting for the original author to apply a trivial +change (a typo, capitalisation change, etc.) and the author allowed the members +to modify the PR, consider applying it yourself. (or commit the existing review +suggestion) You should pay extra attention to make sure the addition doesn't go +against the idea of the original PR and would not be opposed by the author. +