From 2b5e7bd2ba4bd9f16a7fb928100ba4d5f99ab378 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20=C4=8Cun=C3=A1t?= Date: Sun, 19 Apr 2015 16:31:05 +0200 Subject: [PATCH] python2*: fix modules as well after 4101db0be There was a typo that failed them. Also, drop pkgconfig again, as it seems unused; and fix python26. Now all python*.modules build, except for python26.tkinter which fails on master as well. --- pkgs/development/interpreters/python/2.6/default.nix | 10 ++++------ pkgs/development/interpreters/python/2.7/default.nix | 10 +++++----- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/pkgs/development/interpreters/python/2.6/default.nix b/pkgs/development/interpreters/python/2.6/default.nix index 787e3ea9e3b5..83787fdb1e24 100644 --- a/pkgs/development/interpreters/python/2.6/default.nix +++ b/pkgs/development/interpreters/python/2.6/default.nix @@ -1,4 +1,4 @@ -{ stdenv, fetchurl, pkgconfig, zlib ? null, zlibSupport ? true, bzip2, includeModules ? false +{ stdenv, fetchurl, zlib ? null, zlibSupport ? true, bzip2, includeModules ? false , sqlite, tcl, tk, x11, openssl, readline, db, ncurses, gdbm, self, callPackage }: assert zlibSupport -> zlib != null; @@ -48,12 +48,12 @@ let buildInputs = optional (stdenv ? cc && stdenv.cc.libc != null) stdenv.cc.libc ++ - [ pkgconfig bzip2 openssl ]++ optionals includeModules [ db openssl ncurses gdbm readline x11 tcl tk sqlite ] + [ bzip2 openssl ]++ optionals includeModules [ db openssl ncurses gdbm readline x11 tcl tk sqlite ] ++ optional zlibSupport zlib; mkPaths = paths: { - C_INCLUDE_PATH = concatStringsSep ":" (map (p: "${p.dev or p}/include") buildInputs); - LIBRARY_PATH = concatStringsSep ":" (map (p: "${p.lib or (p.out or p)}/lib") buildInputs); + C_INCLUDE_PATH = concatStringsSep ":" (map (p: "${p.dev or p}/include") paths); + LIBRARY_PATH = concatStringsSep ":" (map (p: "${p.lib or (p.out or p)}/lib") paths); }; # Build the basic Python interpreter without modules that have @@ -90,8 +90,6 @@ let paxmark E $out/bin/python${majorVersion} ${ optionalString includeModules "$out/bin/python ./setup.py build_ext"} - - rm "$out/lib/python2.7/plat-linux2/regen" # refers to glibc.dev ''; passthru = rec { diff --git a/pkgs/development/interpreters/python/2.7/default.nix b/pkgs/development/interpreters/python/2.7/default.nix index 56f209809414..1c2f2f592ce3 100644 --- a/pkgs/development/interpreters/python/2.7/default.nix +++ b/pkgs/development/interpreters/python/2.7/default.nix @@ -1,4 +1,4 @@ -{ stdenv, fetchurl, pkgconfig, self, callPackage +{ stdenv, fetchurl, self, callPackage , bzip2, openssl , includeModules ? false @@ -60,7 +60,7 @@ let buildInputs = optional (stdenv ? cc && stdenv.cc.libc != null) stdenv.cc.libc ++ - [ pkgconfig bzip2 openssl ] + [ bzip2 openssl ] ++ optionals includeModules ( [ db gdbm ncurses sqlite readline ] ++ optionals x11Support [ tcl tk x11 libX11 ] @@ -68,8 +68,8 @@ let ++ optional zlibSupport zlib; mkPaths = paths: { - C_INCLUDE_PATH = concatStringsSep ":" (map (p: "${p.dev or p}/include") buildInputs); - LIBRARY_PATH = concatStringsSep ":" (map (p: "${p.lib or (p.out or p)}/lib") buildInputs); + C_INCLUDE_PATH = concatStringsSep ":" (map (p: "${p.dev or p}/include") paths); + LIBRARY_PATH = concatStringsSep ":" (map (p: "${p.lib or (p.out or p)}/lib") paths); }; # Build the basic Python interpreter without modules that have @@ -110,7 +110,7 @@ let ${ optionalString includeModules "$out/bin/python ./setup.py build_ext"} - rm "$out/lib/python2.7/plat-linux2/regen" # refers to glibc.dev + rm "$out"/lib/python*/plat-linux2/regen # refers to glibc.dev ''; passthru = rec {