JakeHillion/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

electron-source.electron_{27,28}: remove instead of marking them as EOL

Browse Source 
Follow-up to 7892638379.

We still have the EOLed `electron-{27,28}-bin` builds, that can be used
instead.

`electron-source.electron_{27,28}` do not build anymore due to LLVM
incompatibilities.

This is beneficial to users of software that still depend on those EOLed
electron versions as well.

Instead of wasting potentially hours of compute trying to build known
broken versions from source, the working binary variants will be used.

Furthermore, this allows us to cleanup the underlying chromium and
electron-source derivations from now unused version conditions such
as version specific patches and build flags.
This commit is contained in:
emilylange 2024-06-13 01:24:50 +02:00 committed by Yureka
parent a0a523d790
commit 268ce0e562
3 changed files with 2 additions and 1787 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pkgs/development/tools/electron/common.nix
View File

@ -234,7 +234,6 @@ in (chromium.override { upstream-info = info.chromium; }).mkDerivation (base: {
meta = with lib; {
description = "Cross platform desktop application shell";
homepage = "https://github.com/electron/electron";
knownVulnerabilities = optional (versionOlder info.version "29") "Electron version ${version} is EOL";
platforms = lib.platforms.linux;
license = licenses.mit;
maintainers = with maintainers; [ yayayayaka teutat3s ];

1784
pkgs/development/tools/electron/info.json
View File

File diff suppressed because it is too large Load Diff

4
pkgs/top-level/all-packages.nix
View File

@ -18004,8 +18004,8 @@ with pkgs;
electron_30-bin;
electron_24 = electron_24-bin;
electron_27 = if lib.meta.availableOn stdenv.hostPlatform electron-source.electron_27 then electron-source.electron_27 else electron_27-bin;
electron_28 = if lib.meta.availableOn stdenv.hostPlatform electron-source.electron_28 then electron-source.electron_28 else electron_28-bin;
electron_27 = electron_27-bin;
electron_28 = electron_28-bin;
electron_29 = if lib.meta.availableOn stdenv.hostPlatform electron-source.electron_29 then electron-source.electron_29 else electron_29-bin;
electron_30 = if lib.meta.availableOn stdenv.hostPlatform electron-source.electron_30 then electron-source.electron_30 else electron_30-bin;
electron = electron_30;