2017-07-06 02:47:48 +01:00
|
|
|
{ lib, config, stdenv }:
|
2017-07-05 22:56:53 +01:00
|
|
|
|
check-env: don't execute check-meta.nix 15,000 times
Generated from https://github.com/NixOS/nix/pull/2761:
```
ns calls ns/call
- /home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:22:5 591200 15026 39.3451
+ /home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:22:5 8744 308 28.3896
```
more, generated by:
```
$ NIX_SHOW_STATS=1 NIX_COUNT_CALLS=1 nix-instantiate ./pkgs/top-level/release.nix -A unstable > before 2>&1
$ jq -r '.functions | map((.name + ":" + .file + ":" + (.line|tostring) + ":" + (.column|tostring) + " " + (.count|tostring))) | .[]' before | sort > before.list
```
applying this patch, then:
```
$ NIX_SHOW_STATS=1 NIX_COUNT_CALLS=1 nix-instantiate ./pkgs/top-level/release.nix -A unstable > after 2>&1
$ jq -r '.functions | map((.name + ":" + .file + ":" + (.line|tostring) + ":" + (.column|tostring) + " " + (.count|tostring))) | .[]' after | sort > after.list
```
and then diffing before.list and after.list to get:
```
calls
- :/home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:4:1 7513
+ :/home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:4:1 154
- mutuallyExclusive:/home/grahamc/projects/github.com/NixOS/nixpkgs/lib/lists.nix:658:23 7513
+ mutuallyExclusive:/home/grahamc/projects/github.com/NixOS/nixpkgs/lib/lists.nix:658:23 154
- mutuallyExclusive:/home/grahamc/projects/github.com/NixOS/nixpkgs/lib/lists.nix:658:26 7513
+ mutuallyExclusive:/home/grahamc/projects/github.com/NixOS/nixpkgs/lib/lists.nix:658:26 154
- onlyLicenses:/home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:21:18 15026
+ onlyLicenses:/home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:21:18 308
```
The following information is from `NIX_SHOW_STATS=1 GC_INITIAL_HEAP_SIZE=4g nix-env -f ./outpaths.nix -qaP --no-name --out-path --arg checkMeta true`:
| stat | before | after | Δ | Δ% |
|:---------------------------|---------------:|---------------:|:----------------|--------:|
| **cpuTime** | 179.915 | 145.543 | 🡖 34.372 | -19.10% |
| **envs-bytes** | 3,900,878,824 | 3,599,483,208 | 🡖 301,395,616 | -7.73% |
| **envs-elements** | 214,426,071 | 185,881,709 | 🡖 28,544,362 | -13.31% |
| **envs-number** | 136,591,891 | 132,026,846 | 🡖 4,565,045 | -3.34% |
| **gc-heapSize** | 11,400,048,640 | 12,314,890,240 | 🡕 914,841,600 | 8.02% |
| **gc-totalBytes** | 25,976,902,560 | 24,510,740,176 | 🡖 1,466,162,384 | -5.64% |
| **list-bytes** | 1,665,290,080 | 1,665,290,080 | 0 | |
| **list-concats** | 7,264,417 | 7,264,417 | 0 | |
| **list-elements** | 208,161,260 | 208,161,260 | 0 | |
| **nrAvoided** | 191,359,386 | 179,693,661 | 🡖 11,665,725 | -6.10% |
| **nrFunctionCalls** | 119,665,062 | 116,348,547 | 🡖 3,316,515 | -2.77% |
| **nrLookups** | 80,996,257 | 76,069,825 | 🡖 4,926,432 | -6.08% |
| **nrOpUpdateValuesCopied** | 213,930,649 | 213,930,649 | 0 | |
| **nrOpUpdates** | 12,025,937 | 12,025,937 | 0 | |
| **nrPrimOpCalls** | 88,105,604 | 86,451,598 | 🡖 1,654,006 | -1.88% |
| **nrThunks** | 196,842,044 | 175,126,701 | 🡖 21,715,343 | -11.03% |
| **sets-bytes** | 7,678,425,776 | 7,285,767,928 | 🡖 392,657,848 | -5.11% |
| **sets-elements** | 310,241,340 | 294,373,227 | 🡖 15,868,113 | -5.11% |
| **sets-number** | 29,079,202 | 27,601,310 | 🡖 1,477,892 | -5.08% |
| **sizes-Attr** | 24 | 24 | 0 | |
| **sizes-Bindings** | 8 | 8 | 0 | |
| **sizes-Env** | 16 | 16 | 0 | |
| **sizes-Value** | 24 | 24 | 0 | |
| **symbols-bytes** | 16,474,666 | 16,474,676 | 🡕 10 | 0.00% |
| **symbols-number** | 376,426 | 376,427 | 🡕 1 | 0.00% |
| **values-bytes** | 6,856,506,288 | 6,316,585,560 | 🡖 539,920,728 | -7.87% |
| **values-number** | 285,687,762 | 263,191,065 | 🡖 22,496,697 | -7.87% |
The following information is from `NIX_SHOW_STATS=1 GC_INITIAL_HEAP_SIZE=4g nix-instantiate ./nixos/release-combined.nix -A tested`:
| stat | before | after | Δ | Δ% |
|:---------------------------|---------------:|---------------:|:----------------|-------:|
| **cpuTime** | 256.071 | 237.531 | 🡖 18.54 | -7.24% |
| **envs-bytes** | 7,111,004,192 | 7,041,478,520 | 🡖 69,525,672 | -0.98% |
| **envs-elements** | 346,236,940 | 339,588,487 | 🡖 6,648,453 | -1.92% |
| **envs-number** | 271,319,292 | 270,298,164 | 🡖 1,021,128 | -0.38% |
| **gc-heapSize** | 8,995,291,136 | 10,110,009,344 | 🡕 1,114,718,208 | 12.39% |
| **gc-totalBytes** | 37,172,737,408 | 36,878,391,888 | 🡖 294,345,520 | -0.79% |
| **list-bytes** | 1,886,162,656 | 1,886,163,472 | 🡕 816 | 0.00% |
| **list-concats** | 6,898,114 | 6,898,114 | 0 | |
| **list-elements** | 235,770,332 | 235,770,434 | 🡕 102 | 0.00% |
| **nrAvoided** | 328,829,821 | 326,618,157 | 🡖 2,211,664 | -0.67% |
| **nrFunctionCalls** | 240,850,845 | 239,998,495 | 🡖 852,350 | -0.35% |
| **nrLookups** | 144,849,632 | 142,126,339 | 🡖 2,723,293 | -1.88% |
| **nrOpUpdateValuesCopied** | 251,032,504 | 251,032,504 | 0 | |
| **nrOpUpdates** | 17,903,110 | 17,903,110 | 0 | |
| **nrPrimOpCalls** | 140,674,913 | 139,485,975 | 🡖 1,188,938 | -0.85% |
| **nrThunks** | 294,643,131 | 288,678,022 | 🡖 5,965,109 | -2.02% |
| **sets-bytes** | 9,464,322,192 | 9,456,172,048 | 🡖 8,150,144 | -0.09% |
| **sets-elements** | 377,474,889 | 377,134,877 | 🡖 340,012 | -0.09% |
| **sets-number** | 50,615,607 | 50,616,875 | 🡕 1,268 | 0.00% |
| **sizes-Attr** | 24 | 24 | 0 | |
| **sizes-Bindings** | 8 | 8 | 0 | |
| **sizes-Env** | 16 | 16 | 0 | |
| **sizes-Value** | 24 | 24 | 0 | |
| **symbols-bytes** | 3,147,102 | 3,147,064 | 🡖 38 | -0.00% |
| **symbols-number** | 82,819 | 82,819 | 0 | |
| **values-bytes** | 11,147,448,768 | 10,996,111,512 | 🡖 151,337,256 | -1.36% |
| **values-number** | 464,477,032 | 458,171,313 | 🡖 6,305,719 | -1.36% |
2019-04-11 17:35:35 +01:00
|
|
|
let
|
|
|
|
checkMeta = import ./check-meta.nix {
|
|
|
|
inherit lib config;
|
|
|
|
# Nix itself uses the `system` field of a derivation to decide where
|
|
|
|
# to build it. This is a bit confusing for cross compilation.
|
|
|
|
inherit (stdenv) hostPlatform;
|
|
|
|
};
|
|
|
|
in rec {
|
2017-07-05 22:56:53 +01:00
|
|
|
# `mkDerivation` wraps the builtin `derivation` function to
|
|
|
|
# produce derivations that use this stdenv and its shell.
|
|
|
|
#
|
|
|
|
# See also:
|
|
|
|
#
|
|
|
|
# * https://nixos.org/nixpkgs/manual/#sec-using-stdenv
|
|
|
|
# Details on how to use this mkDerivation function
|
|
|
|
#
|
|
|
|
# * https://nixos.org/nix/manual/#ssec-derivation
|
|
|
|
# Explanation about derivations in general
|
|
|
|
mkDerivation =
|
2019-02-01 15:59:12 +00:00
|
|
|
{
|
2017-07-13 00:00:19 +01:00
|
|
|
|
stdenv: Fix handling of dependencies and hooks
4 far-reaching changes: Smaller PATH, New vars, different propagation
logic, and different hook logic
Smaller PATH
------------
`buildInputs` no longer go on the PATH at build time, as they cannot be
run when cross compiling and we don't want to special case. Simply make
a `nativeBuildInput` too if one needs them on the PATH. Fixes #21191.
Many new depedendency variables
-------------------------------
See the stdenv chapter of the nixpkgs manual. I pulled out the existing
documentation of dependency specification into a new section, and added
language for these two (and their propagated equivalents) along side
the others'.
More complex propagation logic
------------------------------
Before a propagated*XXX*Input always acted as if it was specified
directly as a *XXX*Input downstream. That's simple enough, but violates
the intended roles of each sort of dep, which has functional and not
just stylistic consequences.
The new algorithm is detailed in the manual, and ensures everything
ends up in the right place. I tried to give both an informal and formal
description, but I suspect in practice it will not make much sense
until one tries cross compiling, after which it will immediately make
sense as the only sane option.
Simplified hook logic
---------------------
Rather than `envHook` and `crossEnvHook`, whose behavior differs
depending on whether we are cross compiling or not, there is now one
hook per sort (or rather non-propagated and propagated pair of sorts)
of dependency. These new hooks have the same meaning regardless of
cross compilation. See the setup hook section of stdenv chapter of the
Nixpkgs manual for more details.
2017-09-11 17:20:20 +01:00
|
|
|
# These types of dependencies are all exhaustively documented in
|
|
|
|
# the "Specifying Dependencies" section of the "Standard
|
|
|
|
# Environment" chapter of the Nixpkgs manual.
|
2017-07-05 22:56:53 +01:00
|
|
|
|
stdenv: Fix handling of dependencies and hooks
4 far-reaching changes: Smaller PATH, New vars, different propagation
logic, and different hook logic
Smaller PATH
------------
`buildInputs` no longer go on the PATH at build time, as they cannot be
run when cross compiling and we don't want to special case. Simply make
a `nativeBuildInput` too if one needs them on the PATH. Fixes #21191.
Many new depedendency variables
-------------------------------
See the stdenv chapter of the nixpkgs manual. I pulled out the existing
documentation of dependency specification into a new section, and added
language for these two (and their propagated equivalents) along side
the others'.
More complex propagation logic
------------------------------
Before a propagated*XXX*Input always acted as if it was specified
directly as a *XXX*Input downstream. That's simple enough, but violates
the intended roles of each sort of dep, which has functional and not
just stylistic consequences.
The new algorithm is detailed in the manual, and ensures everything
ends up in the right place. I tried to give both an informal and formal
description, but I suspect in practice it will not make much sense
until one tries cross compiling, after which it will immediately make
sense as the only sane option.
Simplified hook logic
---------------------
Rather than `envHook` and `crossEnvHook`, whose behavior differs
depending on whether we are cross compiling or not, there is now one
hook per sort (or rather non-propagated and propagated pair of sorts)
of dependency. These new hooks have the same meaning regardless of
cross compilation. See the setup hook section of stdenv chapter of the
Nixpkgs manual for more details.
2017-09-11 17:20:20 +01:00
|
|
|
# TODO(@Ericson2314): Stop using legacy dep attribute names
|
|
|
|
|
|
|
|
# host offset -> target offset
|
2019-02-01 15:59:12 +00:00
|
|
|
depsBuildBuild ? [] # -1 -> -1
|
stdenv: Fix handling of dependencies and hooks
4 far-reaching changes: Smaller PATH, New vars, different propagation
logic, and different hook logic
Smaller PATH
------------
`buildInputs` no longer go on the PATH at build time, as they cannot be
run when cross compiling and we don't want to special case. Simply make
a `nativeBuildInput` too if one needs them on the PATH. Fixes #21191.
Many new depedendency variables
-------------------------------
See the stdenv chapter of the nixpkgs manual. I pulled out the existing
documentation of dependency specification into a new section, and added
language for these two (and their propagated equivalents) along side
the others'.
More complex propagation logic
------------------------------
Before a propagated*XXX*Input always acted as if it was specified
directly as a *XXX*Input downstream. That's simple enough, but violates
the intended roles of each sort of dep, which has functional and not
just stylistic consequences.
The new algorithm is detailed in the manual, and ensures everything
ends up in the right place. I tried to give both an informal and formal
description, but I suspect in practice it will not make much sense
until one tries cross compiling, after which it will immediately make
sense as the only sane option.
Simplified hook logic
---------------------
Rather than `envHook` and `crossEnvHook`, whose behavior differs
depending on whether we are cross compiling or not, there is now one
hook per sort (or rather non-propagated and propagated pair of sorts)
of dependency. These new hooks have the same meaning regardless of
cross compilation. See the setup hook section of stdenv chapter of the
Nixpkgs manual for more details.
2017-09-11 17:20:20 +01:00
|
|
|
, depsBuildBuildPropagated ? [] # -1 -> -1
|
|
|
|
, nativeBuildInputs ? [] # -1 -> 0 N.B. Legacy name
|
|
|
|
, propagatedNativeBuildInputs ? [] # -1 -> 0 N.B. Legacy name
|
|
|
|
, depsBuildTarget ? [] # -1 -> 1
|
|
|
|
, depsBuildTargetPropagated ? [] # -1 -> 1
|
|
|
|
|
|
|
|
, depsHostHost ? [] # 0 -> 0
|
|
|
|
, depsHostHostPropagated ? [] # 0 -> 0
|
|
|
|
, buildInputs ? [] # 0 -> 1 N.B. Legacy name
|
|
|
|
, propagatedBuildInputs ? [] # 0 -> 1 N.B. Legacy name
|
|
|
|
|
|
|
|
, depsTargetTarget ? [] # 1 -> 1
|
|
|
|
, depsTargetTargetPropagated ? [] # 1 -> 1
|
2017-07-05 22:56:53 +01:00
|
|
|
|
2018-03-15 00:00:04 +00:00
|
|
|
, checkInputs ? []
|
|
|
|
, installCheckInputs ? []
|
|
|
|
|
2018-01-08 06:33:35 +00:00
|
|
|
# Configure Phase
|
2017-07-13 00:00:19 +01:00
|
|
|
, configureFlags ? []
|
2018-10-17 03:50:37 +01:00
|
|
|
, cmakeFlags ? []
|
2020-04-26 21:47:27 +01:00
|
|
|
, mesonFlags ? []
|
2017-07-13 00:00:19 +01:00
|
|
|
, # Target is not included by default because most programs don't care.
|
|
|
|
# Including it then would cause needless mass rebuilds.
|
|
|
|
#
|
|
|
|
# TODO(@Ericson2314): Make [ "build" "host" ] always the default.
|
|
|
|
configurePlatforms ? lib.optionals
|
|
|
|
(stdenv.hostPlatform != stdenv.buildPlatform)
|
|
|
|
[ "build" "host" ]
|
2018-01-08 06:33:35 +00:00
|
|
|
|
2018-03-15 00:00:04 +00:00
|
|
|
# TODO(@Ericson2314): Make unconditional / resolve #33599
|
2018-01-08 06:33:35 +00:00
|
|
|
# Check phase
|
2018-03-15 00:00:04 +00:00
|
|
|
, doCheck ? config.doCheckByDefault or false
|
2018-01-08 06:33:35 +00:00
|
|
|
|
2018-03-15 00:00:04 +00:00
|
|
|
# TODO(@Ericson2314): Make unconditional / resolve #33599
|
2018-01-08 06:33:35 +00:00
|
|
|
# InstallCheck phase
|
2018-03-15 00:00:04 +00:00
|
|
|
, doInstallCheck ? config.doCheckByDefault or false
|
2018-01-08 06:33:35 +00:00
|
|
|
|
2018-05-13 16:31:24 +01:00
|
|
|
, # TODO(@Ericson2314): Make always true and remove
|
|
|
|
strictDeps ? stdenv.hostPlatform != stdenv.buildPlatform
|
2017-07-05 22:56:53 +01:00
|
|
|
, meta ? {}
|
|
|
|
, passthru ? {}
|
|
|
|
, pos ? # position used in error messages and for meta.position
|
|
|
|
(if attrs.meta.description or null != null
|
|
|
|
then builtins.unsafeGetAttrPos "description" attrs.meta
|
2018-06-06 21:04:35 +01:00
|
|
|
else if attrs.version or null != null
|
|
|
|
then builtins.unsafeGetAttrPos "version" attrs
|
2017-07-05 22:56:53 +01:00
|
|
|
else builtins.unsafeGetAttrPos "name" attrs)
|
|
|
|
, separateDebugInfo ? false
|
|
|
|
, outputs ? [ "out" ]
|
2019-02-14 19:32:08 +00:00
|
|
|
, __darwinAllowLocalNetworking ? false
|
2017-07-05 22:56:53 +01:00
|
|
|
, __impureHostDeps ? []
|
|
|
|
, __propagatedImpureHostDeps ? []
|
|
|
|
, sandboxProfile ? ""
|
|
|
|
, propagatedSandboxProfile ? ""
|
2017-08-28 19:56:08 +01:00
|
|
|
|
|
|
|
, hardeningEnable ? []
|
|
|
|
, hardeningDisable ? []
|
2018-01-08 06:33:35 +00:00
|
|
|
|
2019-04-17 03:51:26 +01:00
|
|
|
, patches ? []
|
|
|
|
|
2017-07-05 22:56:53 +01:00
|
|
|
, ... } @ attrs:
|
2017-08-28 19:56:08 +01:00
|
|
|
|
2017-07-05 22:56:53 +01:00
|
|
|
let
|
2018-08-05 20:24:32 +01:00
|
|
|
# TODO(@oxij, @Ericson2314): This is here to keep the old semantics, remove when
|
|
|
|
# no package has `doCheck = true`.
|
|
|
|
doCheck' = doCheck && stdenv.hostPlatform == stdenv.buildPlatform;
|
|
|
|
doInstallCheck' = doInstallCheck && stdenv.hostPlatform == stdenv.buildPlatform;
|
|
|
|
|
2019-02-14 06:17:10 +00:00
|
|
|
separateDebugInfo' = separateDebugInfo && stdenv.hostPlatform.isLinux && !(stdenv.hostPlatform.useLLVM or false);
|
2018-11-28 18:29:00 +00:00
|
|
|
outputs' = outputs ++ lib.optional separateDebugInfo' "debug";
|
2018-08-05 20:24:46 +01:00
|
|
|
|
2017-12-22 21:05:33 +00:00
|
|
|
noNonNativeDeps = builtins.length (depsBuildTarget ++ depsBuildTargetPropagated
|
|
|
|
++ depsHostHost ++ depsHostHostPropagated
|
|
|
|
++ buildInputs ++ propagatedBuildInputs
|
|
|
|
++ depsTargetTarget ++ depsTargetTargetPropagated) == 0;
|
2019-01-28 15:00:10 +00:00
|
|
|
dontAddHostSuffix = attrs ? outputHash && !noNonNativeDeps || (stdenv.noCC or false);
|
2017-09-01 01:46:26 +01:00
|
|
|
supportedHardeningFlags = [ "fortify" "stackprotector" "pie" "pic" "strictoverflow" "format" "relro" "bindnow" ];
|
2018-11-29 21:45:57 +00:00
|
|
|
defaultHardeningFlags = if stdenv.hostPlatform.isMusl
|
2018-11-03 18:55:50 +00:00
|
|
|
then supportedHardeningFlags
|
|
|
|
else lib.remove "pie" supportedHardeningFlags;
|
2018-04-11 19:00:13 +01:00
|
|
|
enabledHardeningOptions =
|
|
|
|
if builtins.elem "all" hardeningDisable
|
|
|
|
then []
|
|
|
|
else lib.subtractLists hardeningDisable (defaultHardeningFlags ++ hardeningEnable);
|
2017-09-01 10:58:19 +01:00
|
|
|
# hardeningDisable additionally supports "all".
|
2017-09-01 01:46:26 +01:00
|
|
|
erroneousHardeningFlags = lib.subtractLists supportedHardeningFlags (hardeningEnable ++ lib.remove "all" hardeningDisable);
|
|
|
|
in if builtins.length erroneousHardeningFlags != 0
|
|
|
|
then abort ("mkDerivation was called with unsupported hardening flags: " + lib.generators.toPretty {} {
|
|
|
|
inherit erroneousHardeningFlags hardeningDisable hardeningEnable supportedHardeningFlags;
|
|
|
|
})
|
|
|
|
else let
|
2018-08-05 20:24:32 +01:00
|
|
|
doCheck = doCheck';
|
|
|
|
doInstallCheck = doInstallCheck';
|
|
|
|
|
2018-08-05 20:24:46 +01:00
|
|
|
outputs = outputs';
|
|
|
|
|
2018-01-02 14:52:27 +00:00
|
|
|
references = nativeBuildInputs ++ buildInputs
|
|
|
|
++ propagatedNativeBuildInputs ++ propagatedBuildInputs;
|
|
|
|
|
stdenv: Fix handling of dependencies and hooks
4 far-reaching changes: Smaller PATH, New vars, different propagation
logic, and different hook logic
Smaller PATH
------------
`buildInputs` no longer go on the PATH at build time, as they cannot be
run when cross compiling and we don't want to special case. Simply make
a `nativeBuildInput` too if one needs them on the PATH. Fixes #21191.
Many new depedendency variables
-------------------------------
See the stdenv chapter of the nixpkgs manual. I pulled out the existing
documentation of dependency specification into a new section, and added
language for these two (and their propagated equivalents) along side
the others'.
More complex propagation logic
------------------------------
Before a propagated*XXX*Input always acted as if it was specified
directly as a *XXX*Input downstream. That's simple enough, but violates
the intended roles of each sort of dep, which has functional and not
just stylistic consequences.
The new algorithm is detailed in the manual, and ensures everything
ends up in the right place. I tried to give both an informal and formal
description, but I suspect in practice it will not make much sense
until one tries cross compiling, after which it will immediately make
sense as the only sane option.
Simplified hook logic
---------------------
Rather than `envHook` and `crossEnvHook`, whose behavior differs
depending on whether we are cross compiling or not, there is now one
hook per sort (or rather non-propagated and propagated pair of sorts)
of dependency. These new hooks have the same meaning regardless of
cross compilation. See the setup hook section of stdenv chapter of the
Nixpkgs manual for more details.
2017-09-11 17:20:20 +01:00
|
|
|
dependencies = map (map lib.chooseDevOutputs) [
|
|
|
|
[
|
|
|
|
(map (drv: drv.__spliced.buildBuild or drv) depsBuildBuild)
|
|
|
|
(map (drv: drv.nativeDrv or drv) nativeBuildInputs
|
2018-11-28 18:29:00 +00:00
|
|
|
++ lib.optional separateDebugInfo' ../../build-support/setup-hooks/separate-debug-info.sh
|
2019-01-05 09:54:04 +00:00
|
|
|
++ lib.optional stdenv.hostPlatform.isWindows ../../build-support/setup-hooks/win-dll-link.sh
|
|
|
|
++ lib.optionals doCheck checkInputs
|
|
|
|
++ lib.optionals doInstallCheck' installCheckInputs)
|
stdenv: Fix handling of dependencies and hooks
4 far-reaching changes: Smaller PATH, New vars, different propagation
logic, and different hook logic
Smaller PATH
------------
`buildInputs` no longer go on the PATH at build time, as they cannot be
run when cross compiling and we don't want to special case. Simply make
a `nativeBuildInput` too if one needs them on the PATH. Fixes #21191.
Many new depedendency variables
-------------------------------
See the stdenv chapter of the nixpkgs manual. I pulled out the existing
documentation of dependency specification into a new section, and added
language for these two (and their propagated equivalents) along side
the others'.
More complex propagation logic
------------------------------
Before a propagated*XXX*Input always acted as if it was specified
directly as a *XXX*Input downstream. That's simple enough, but violates
the intended roles of each sort of dep, which has functional and not
just stylistic consequences.
The new algorithm is detailed in the manual, and ensures everything
ends up in the right place. I tried to give both an informal and formal
description, but I suspect in practice it will not make much sense
until one tries cross compiling, after which it will immediately make
sense as the only sane option.
Simplified hook logic
---------------------
Rather than `envHook` and `crossEnvHook`, whose behavior differs
depending on whether we are cross compiling or not, there is now one
hook per sort (or rather non-propagated and propagated pair of sorts)
of dependency. These new hooks have the same meaning regardless of
cross compilation. See the setup hook section of stdenv chapter of the
Nixpkgs manual for more details.
2017-09-11 17:20:20 +01:00
|
|
|
(map (drv: drv.__spliced.buildTarget or drv) depsBuildTarget)
|
|
|
|
]
|
|
|
|
[
|
|
|
|
(map (drv: drv.__spliced.hostHost or drv) depsHostHost)
|
2019-01-05 09:54:04 +00:00
|
|
|
(map (drv: drv.crossDrv or drv) buildInputs)
|
stdenv: Fix handling of dependencies and hooks
4 far-reaching changes: Smaller PATH, New vars, different propagation
logic, and different hook logic
Smaller PATH
------------
`buildInputs` no longer go on the PATH at build time, as they cannot be
run when cross compiling and we don't want to special case. Simply make
a `nativeBuildInput` too if one needs them on the PATH. Fixes #21191.
Many new depedendency variables
-------------------------------
See the stdenv chapter of the nixpkgs manual. I pulled out the existing
documentation of dependency specification into a new section, and added
language for these two (and their propagated equivalents) along side
the others'.
More complex propagation logic
------------------------------
Before a propagated*XXX*Input always acted as if it was specified
directly as a *XXX*Input downstream. That's simple enough, but violates
the intended roles of each sort of dep, which has functional and not
just stylistic consequences.
The new algorithm is detailed in the manual, and ensures everything
ends up in the right place. I tried to give both an informal and formal
description, but I suspect in practice it will not make much sense
until one tries cross compiling, after which it will immediately make
sense as the only sane option.
Simplified hook logic
---------------------
Rather than `envHook` and `crossEnvHook`, whose behavior differs
depending on whether we are cross compiling or not, there is now one
hook per sort (or rather non-propagated and propagated pair of sorts)
of dependency. These new hooks have the same meaning regardless of
cross compilation. See the setup hook section of stdenv chapter of the
Nixpkgs manual for more details.
2017-09-11 17:20:20 +01:00
|
|
|
]
|
|
|
|
[
|
|
|
|
(map (drv: drv.__spliced.targetTarget or drv) depsTargetTarget)
|
|
|
|
]
|
2017-07-05 22:56:53 +01:00
|
|
|
];
|
stdenv: Fix handling of dependencies and hooks
4 far-reaching changes: Smaller PATH, New vars, different propagation
logic, and different hook logic
Smaller PATH
------------
`buildInputs` no longer go on the PATH at build time, as they cannot be
run when cross compiling and we don't want to special case. Simply make
a `nativeBuildInput` too if one needs them on the PATH. Fixes #21191.
Many new depedendency variables
-------------------------------
See the stdenv chapter of the nixpkgs manual. I pulled out the existing
documentation of dependency specification into a new section, and added
language for these two (and their propagated equivalents) along side
the others'.
More complex propagation logic
------------------------------
Before a propagated*XXX*Input always acted as if it was specified
directly as a *XXX*Input downstream. That's simple enough, but violates
the intended roles of each sort of dep, which has functional and not
just stylistic consequences.
The new algorithm is detailed in the manual, and ensures everything
ends up in the right place. I tried to give both an informal and formal
description, but I suspect in practice it will not make much sense
until one tries cross compiling, after which it will immediately make
sense as the only sane option.
Simplified hook logic
---------------------
Rather than `envHook` and `crossEnvHook`, whose behavior differs
depending on whether we are cross compiling or not, there is now one
hook per sort (or rather non-propagated and propagated pair of sorts)
of dependency. These new hooks have the same meaning regardless of
cross compilation. See the setup hook section of stdenv chapter of the
Nixpkgs manual for more details.
2017-09-11 17:20:20 +01:00
|
|
|
propagatedDependencies = map (map lib.chooseDevOutputs) [
|
|
|
|
[
|
|
|
|
(map (drv: drv.__spliced.buildBuild or drv) depsBuildBuildPropagated)
|
|
|
|
(map (drv: drv.nativeDrv or drv) propagatedNativeBuildInputs)
|
|
|
|
(map (drv: drv.__spliced.buildTarget or drv) depsBuildTargetPropagated)
|
|
|
|
]
|
|
|
|
[
|
|
|
|
(map (drv: drv.__spliced.hostHost or drv) depsHostHostPropagated)
|
|
|
|
(map (drv: drv.crossDrv or drv) propagatedBuildInputs)
|
|
|
|
]
|
|
|
|
[
|
|
|
|
(map (drv: drv.__spliced.targetTarget or drv) depsTargetTargetPropagated)
|
|
|
|
]
|
2017-07-05 22:56:53 +01:00
|
|
|
];
|
|
|
|
|
2018-04-25 19:49:44 +01:00
|
|
|
computedSandboxProfile =
|
|
|
|
lib.concatMap (input: input.__propagatedSandboxProfile or [])
|
|
|
|
(stdenv.extraNativeBuildInputs
|
|
|
|
++ stdenv.extraBuildInputs
|
|
|
|
++ lib.concatLists dependencies);
|
|
|
|
|
|
|
|
computedPropagatedSandboxProfile =
|
|
|
|
lib.concatMap (input: input.__propagatedSandboxProfile or [])
|
|
|
|
(lib.concatLists propagatedDependencies);
|
|
|
|
|
|
|
|
computedImpureHostDeps =
|
|
|
|
lib.unique (lib.concatMap (input: input.__propagatedImpureHostDeps or [])
|
|
|
|
(stdenv.extraNativeBuildInputs
|
|
|
|
++ stdenv.extraBuildInputs
|
|
|
|
++ lib.concatLists dependencies));
|
|
|
|
|
|
|
|
computedPropagatedImpureHostDeps =
|
|
|
|
lib.unique (lib.concatMap (input: input.__propagatedImpureHostDeps or [])
|
|
|
|
(lib.concatLists propagatedDependencies));
|
|
|
|
|
2017-07-05 22:56:53 +01:00
|
|
|
derivationArg =
|
|
|
|
(removeAttrs attrs
|
2018-07-24 21:27:06 +01:00
|
|
|
["meta" "passthru" "pos"
|
2018-03-15 00:00:04 +00:00
|
|
|
"checkInputs" "installCheckInputs"
|
2019-02-14 19:32:08 +00:00
|
|
|
"__darwinAllowLocalNetworking"
|
2017-07-05 22:56:53 +01:00
|
|
|
"__impureHostDeps" "__propagatedImpureHostDeps"
|
|
|
|
"sandboxProfile" "propagatedSandboxProfile"])
|
2019-02-04 14:15:03 +00:00
|
|
|
// (lib.optionalAttrs (!(attrs ? name) && attrs ? pname && attrs ? version)) {
|
2019-01-28 16:38:30 +00:00
|
|
|
name = "${attrs.pname}-${attrs.version}";
|
2019-02-04 14:15:03 +00:00
|
|
|
} // (lib.optionalAttrs (stdenv.hostPlatform != stdenv.buildPlatform && !dontAddHostSuffix && (attrs ? name || (attrs ? pname && attrs ? version)))) {
|
2019-01-28 14:25:47 +00:00
|
|
|
# Fixed-output derivations like source tarballs shouldn't get a host
|
|
|
|
# suffix. But we have some weird ones with run-time deps that are
|
|
|
|
# just used for their side-affects. Those might as well since the
|
|
|
|
# hash can't be the same. See #32986.
|
2019-02-01 15:59:12 +00:00
|
|
|
name = "${attrs.name or "${attrs.pname}-${attrs.version}"}-${stdenv.hostPlatform.config}";
|
2019-01-28 14:25:47 +00:00
|
|
|
} // {
|
2017-07-05 22:56:53 +01:00
|
|
|
builder = attrs.realBuilder or stdenv.shell;
|
|
|
|
args = attrs.args or ["-e" (attrs.builder or ./default-builder.sh)];
|
|
|
|
inherit stdenv;
|
2018-09-04 04:03:38 +01:00
|
|
|
|
|
|
|
# The `system` attribute of a derivation has special meaning to Nix.
|
|
|
|
# Derivations set it to choose what sort of machine could be used to
|
|
|
|
# execute the build, The build platform entirely determines this,
|
|
|
|
# indeed more finely than Nix knows or cares about. The `system`
|
|
|
|
# attribute of `buildPlatfom` matches Nix's degree of specificity.
|
|
|
|
# exactly.
|
|
|
|
inherit (stdenv.buildPlatform) system;
|
|
|
|
|
2017-07-05 22:56:53 +01:00
|
|
|
userHook = config.stdenv.userHook or null;
|
|
|
|
__ignoreNulls = true;
|
|
|
|
|
2018-05-13 16:31:24 +01:00
|
|
|
inherit strictDeps;
|
|
|
|
|
stdenv: Fix handling of dependencies and hooks
4 far-reaching changes: Smaller PATH, New vars, different propagation
logic, and different hook logic
Smaller PATH
------------
`buildInputs` no longer go on the PATH at build time, as they cannot be
run when cross compiling and we don't want to special case. Simply make
a `nativeBuildInput` too if one needs them on the PATH. Fixes #21191.
Many new depedendency variables
-------------------------------
See the stdenv chapter of the nixpkgs manual. I pulled out the existing
documentation of dependency specification into a new section, and added
language for these two (and their propagated equivalents) along side
the others'.
More complex propagation logic
------------------------------
Before a propagated*XXX*Input always acted as if it was specified
directly as a *XXX*Input downstream. That's simple enough, but violates
the intended roles of each sort of dep, which has functional and not
just stylistic consequences.
The new algorithm is detailed in the manual, and ensures everything
ends up in the right place. I tried to give both an informal and formal
description, but I suspect in practice it will not make much sense
until one tries cross compiling, after which it will immediately make
sense as the only sane option.
Simplified hook logic
---------------------
Rather than `envHook` and `crossEnvHook`, whose behavior differs
depending on whether we are cross compiling or not, there is now one
hook per sort (or rather non-propagated and propagated pair of sorts)
of dependency. These new hooks have the same meaning regardless of
cross compilation. See the setup hook section of stdenv chapter of the
Nixpkgs manual for more details.
2017-09-11 17:20:20 +01:00
|
|
|
depsBuildBuild = lib.elemAt (lib.elemAt dependencies 0) 0;
|
|
|
|
nativeBuildInputs = lib.elemAt (lib.elemAt dependencies 0) 1;
|
|
|
|
depsBuildTarget = lib.elemAt (lib.elemAt dependencies 0) 2;
|
2018-07-23 20:22:48 +01:00
|
|
|
depsHostHost = lib.elemAt (lib.elemAt dependencies 1) 0;
|
stdenv: Fix handling of dependencies and hooks
4 far-reaching changes: Smaller PATH, New vars, different propagation
logic, and different hook logic
Smaller PATH
------------
`buildInputs` no longer go on the PATH at build time, as they cannot be
run when cross compiling and we don't want to special case. Simply make
a `nativeBuildInput` too if one needs them on the PATH. Fixes #21191.
Many new depedendency variables
-------------------------------
See the stdenv chapter of the nixpkgs manual. I pulled out the existing
documentation of dependency specification into a new section, and added
language for these two (and their propagated equivalents) along side
the others'.
More complex propagation logic
------------------------------
Before a propagated*XXX*Input always acted as if it was specified
directly as a *XXX*Input downstream. That's simple enough, but violates
the intended roles of each sort of dep, which has functional and not
just stylistic consequences.
The new algorithm is detailed in the manual, and ensures everything
ends up in the right place. I tried to give both an informal and formal
description, but I suspect in practice it will not make much sense
until one tries cross compiling, after which it will immediately make
sense as the only sane option.
Simplified hook logic
---------------------
Rather than `envHook` and `crossEnvHook`, whose behavior differs
depending on whether we are cross compiling or not, there is now one
hook per sort (or rather non-propagated and propagated pair of sorts)
of dependency. These new hooks have the same meaning regardless of
cross compilation. See the setup hook section of stdenv chapter of the
Nixpkgs manual for more details.
2017-09-11 17:20:20 +01:00
|
|
|
buildInputs = lib.elemAt (lib.elemAt dependencies 1) 1;
|
|
|
|
depsTargetTarget = lib.elemAt (lib.elemAt dependencies 2) 0;
|
2017-07-05 22:56:53 +01:00
|
|
|
|
stdenv: Fix handling of dependencies and hooks
4 far-reaching changes: Smaller PATH, New vars, different propagation
logic, and different hook logic
Smaller PATH
------------
`buildInputs` no longer go on the PATH at build time, as they cannot be
run when cross compiling and we don't want to special case. Simply make
a `nativeBuildInput` too if one needs them on the PATH. Fixes #21191.
Many new depedendency variables
-------------------------------
See the stdenv chapter of the nixpkgs manual. I pulled out the existing
documentation of dependency specification into a new section, and added
language for these two (and their propagated equivalents) along side
the others'.
More complex propagation logic
------------------------------
Before a propagated*XXX*Input always acted as if it was specified
directly as a *XXX*Input downstream. That's simple enough, but violates
the intended roles of each sort of dep, which has functional and not
just stylistic consequences.
The new algorithm is detailed in the manual, and ensures everything
ends up in the right place. I tried to give both an informal and formal
description, but I suspect in practice it will not make much sense
until one tries cross compiling, after which it will immediately make
sense as the only sane option.
Simplified hook logic
---------------------
Rather than `envHook` and `crossEnvHook`, whose behavior differs
depending on whether we are cross compiling or not, there is now one
hook per sort (or rather non-propagated and propagated pair of sorts)
of dependency. These new hooks have the same meaning regardless of
cross compilation. See the setup hook section of stdenv chapter of the
Nixpkgs manual for more details.
2017-09-11 17:20:20 +01:00
|
|
|
depsBuildBuildPropagated = lib.elemAt (lib.elemAt propagatedDependencies 0) 0;
|
|
|
|
propagatedNativeBuildInputs = lib.elemAt (lib.elemAt propagatedDependencies 0) 1;
|
|
|
|
depsBuildTargetPropagated = lib.elemAt (lib.elemAt propagatedDependencies 0) 2;
|
2018-07-23 20:22:48 +01:00
|
|
|
depsHostHostPropagated = lib.elemAt (lib.elemAt propagatedDependencies 1) 0;
|
stdenv: Fix handling of dependencies and hooks
4 far-reaching changes: Smaller PATH, New vars, different propagation
logic, and different hook logic
Smaller PATH
------------
`buildInputs` no longer go on the PATH at build time, as they cannot be
run when cross compiling and we don't want to special case. Simply make
a `nativeBuildInput` too if one needs them on the PATH. Fixes #21191.
Many new depedendency variables
-------------------------------
See the stdenv chapter of the nixpkgs manual. I pulled out the existing
documentation of dependency specification into a new section, and added
language for these two (and their propagated equivalents) along side
the others'.
More complex propagation logic
------------------------------
Before a propagated*XXX*Input always acted as if it was specified
directly as a *XXX*Input downstream. That's simple enough, but violates
the intended roles of each sort of dep, which has functional and not
just stylistic consequences.
The new algorithm is detailed in the manual, and ensures everything
ends up in the right place. I tried to give both an informal and formal
description, but I suspect in practice it will not make much sense
until one tries cross compiling, after which it will immediately make
sense as the only sane option.
Simplified hook logic
---------------------
Rather than `envHook` and `crossEnvHook`, whose behavior differs
depending on whether we are cross compiling or not, there is now one
hook per sort (or rather non-propagated and propagated pair of sorts)
of dependency. These new hooks have the same meaning regardless of
cross compilation. See the setup hook section of stdenv chapter of the
Nixpkgs manual for more details.
2017-09-11 17:20:20 +01:00
|
|
|
propagatedBuildInputs = lib.elemAt (lib.elemAt propagatedDependencies 1) 1;
|
|
|
|
depsTargetTargetPropagated = lib.elemAt (lib.elemAt propagatedDependencies 2) 0;
|
2017-07-13 00:00:19 +01:00
|
|
|
|
2017-07-15 18:47:21 +01:00
|
|
|
# This parameter is sometimes a string, sometimes null, and sometimes a list, yuck
|
2017-07-13 00:00:19 +01:00
|
|
|
configureFlags = let inherit (lib) optional elem; in
|
2017-07-15 18:47:21 +01:00
|
|
|
(/**/ if lib.isString configureFlags then [configureFlags]
|
|
|
|
else if configureFlags == null then []
|
|
|
|
else configureFlags)
|
2017-07-13 00:00:19 +01:00
|
|
|
++ optional (elem "build" configurePlatforms) "--build=${stdenv.buildPlatform.config}"
|
|
|
|
++ optional (elem "host" configurePlatforms) "--host=${stdenv.hostPlatform.config}"
|
|
|
|
++ optional (elem "target" configurePlatforms) "--target=${stdenv.targetPlatform.config}";
|
|
|
|
|
2019-04-17 03:51:26 +01:00
|
|
|
inherit patches;
|
|
|
|
|
2018-08-05 20:24:32 +01:00
|
|
|
inherit doCheck doInstallCheck;
|
2018-08-05 20:24:46 +01:00
|
|
|
|
|
|
|
inherit outputs;
|
2018-10-17 03:50:37 +01:00
|
|
|
} // lib.optionalAttrs (stdenv.hostPlatform != stdenv.buildPlatform) {
|
|
|
|
cmakeFlags =
|
|
|
|
(/**/ if lib.isString cmakeFlags then [cmakeFlags]
|
|
|
|
else if cmakeFlags == null then []
|
|
|
|
else cmakeFlags)
|
2020-08-11 03:52:54 +01:00
|
|
|
++ [ "-DCMAKE_SYSTEM_NAME=${lib.findFirst lib.isString "Generic" (
|
|
|
|
lib.optional (!stdenv.hostPlatform.isRedox) stdenv.hostPlatform.uname.system)}"]
|
2018-10-17 03:50:37 +01:00
|
|
|
++ lib.optional (stdenv.hostPlatform.uname.processor != null) "-DCMAKE_SYSTEM_PROCESSOR=${stdenv.hostPlatform.uname.processor}"
|
|
|
|
++ lib.optional (stdenv.hostPlatform.uname.release != null) "-DCMAKE_SYSTEM_VERSION=${stdenv.hostPlatform.release}"
|
2020-11-19 07:54:02 +00:00
|
|
|
++ lib.optional (stdenv.hostPlatform.isDarwin) "-DCMAKE_OSX_ARCHITECTURES=${stdenv.hostPlatform.darwinArch}"
|
2018-10-17 03:50:37 +01:00
|
|
|
++ lib.optional (stdenv.buildPlatform.uname.system != null) "-DCMAKE_HOST_SYSTEM_NAME=${stdenv.buildPlatform.uname.system}"
|
|
|
|
++ lib.optional (stdenv.buildPlatform.uname.processor != null) "-DCMAKE_HOST_SYSTEM_PROCESSOR=${stdenv.buildPlatform.uname.processor}"
|
|
|
|
++ lib.optional (stdenv.buildPlatform.uname.release != null) "-DCMAKE_HOST_SYSTEM_VERSION=${stdenv.buildPlatform.uname.release}";
|
2020-04-26 21:47:27 +01:00
|
|
|
|
|
|
|
mesonFlags = if mesonFlags == null then null else let
|
|
|
|
# See https://mesonbuild.com/Reference-tables.html#cpu-families
|
2020-04-28 21:51:44 +01:00
|
|
|
cpuFamily = platform: with platform;
|
2020-04-29 03:55:37 +01:00
|
|
|
/**/ if isAarch32 then "arm"
|
|
|
|
else if isAarch64 then "aarch64"
|
2020-04-28 21:51:44 +01:00
|
|
|
else if isx86_32 then "x86"
|
|
|
|
else if isx86_64 then "x86_64"
|
|
|
|
else platform.parsed.cpu.family + builtins.toString platform.parsed.cpu.bits;
|
2020-05-27 17:07:58 +01:00
|
|
|
crossFile = builtins.toFile "cross-file.conf" ''
|
2020-04-26 21:47:27 +01:00
|
|
|
[properties]
|
|
|
|
needs_exe_wrapper = true
|
|
|
|
|
|
|
|
[host_machine]
|
|
|
|
system = '${stdenv.targetPlatform.parsed.kernel.name}'
|
2020-04-28 21:51:44 +01:00
|
|
|
cpu_family = '${cpuFamily stdenv.targetPlatform}'
|
2020-04-26 21:47:27 +01:00
|
|
|
cpu = '${stdenv.targetPlatform.parsed.cpu.name}'
|
|
|
|
endian = ${if stdenv.targetPlatform.isLittleEndian then "'little'" else "'big'"}
|
2020-05-27 17:07:58 +01:00
|
|
|
'';
|
2020-04-26 21:47:27 +01:00
|
|
|
in [ "--cross-file=${crossFile}" ] ++ mesonFlags;
|
2018-09-05 02:08:14 +01:00
|
|
|
} // lib.optionalAttrs (attrs.enableParallelBuilding or false) {
|
|
|
|
enableParallelChecking = attrs.enableParallelChecking or true;
|
2020-10-24 23:34:50 +01:00
|
|
|
} // lib.optionalAttrs (hardeningDisable != [] || hardeningEnable != [] || stdenv.hostPlatform.isMusl) {
|
2018-04-11 19:00:13 +01:00
|
|
|
NIX_HARDENING_ENABLE = enabledHardeningOptions;
|
2021-01-23 01:33:55 +00:00
|
|
|
} // lib.optionalAttrs (stdenv.hostPlatform.isx86_64 && stdenv.hostPlatform ? gcc.arch) {
|
|
|
|
requiredSystemFeatures = attrs.requiredSystemFeatures or [] ++ [ "gccarch-${stdenv.hostPlatform.gcc.arch}" ];
|
2017-07-06 02:47:48 +01:00
|
|
|
} // lib.optionalAttrs (stdenv.buildPlatform.isDarwin) {
|
2019-02-14 19:32:08 +00:00
|
|
|
inherit __darwinAllowLocalNetworking;
|
2017-07-05 22:56:53 +01:00
|
|
|
# TODO: remove lib.unique once nix has a list canonicalization primitive
|
|
|
|
__sandboxProfile =
|
2017-07-06 00:58:24 +01:00
|
|
|
let profiles = [ stdenv.extraSandboxProfile ] ++ computedSandboxProfile ++ computedPropagatedSandboxProfile ++ [ propagatedSandboxProfile sandboxProfile ];
|
2017-07-05 22:56:53 +01:00
|
|
|
final = lib.concatStringsSep "\n" (lib.filter (x: x != "") (lib.unique profiles));
|
|
|
|
in final;
|
|
|
|
__propagatedSandboxProfile = lib.unique (computedPropagatedSandboxProfile ++ [ propagatedSandboxProfile ]);
|
2017-07-06 00:58:24 +01:00
|
|
|
__impureHostDeps = computedImpureHostDeps ++ computedPropagatedImpureHostDeps ++ __propagatedImpureHostDeps ++ __impureHostDeps ++ stdenv.__extraImpureHostDeps ++ [
|
2017-07-05 22:56:53 +01:00
|
|
|
"/dev/zero"
|
|
|
|
"/dev/random"
|
|
|
|
"/dev/urandom"
|
|
|
|
"/bin/sh"
|
|
|
|
];
|
|
|
|
__propagatedImpureHostDeps = computedPropagatedImpureHostDeps ++ __propagatedImpureHostDeps;
|
2018-04-25 19:49:44 +01:00
|
|
|
};
|
2017-07-05 22:56:53 +01:00
|
|
|
|
check-env: don't execute check-meta.nix 15,000 times
Generated from https://github.com/NixOS/nix/pull/2761:
```
ns calls ns/call
- /home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:22:5 591200 15026 39.3451
+ /home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:22:5 8744 308 28.3896
```
more, generated by:
```
$ NIX_SHOW_STATS=1 NIX_COUNT_CALLS=1 nix-instantiate ./pkgs/top-level/release.nix -A unstable > before 2>&1
$ jq -r '.functions | map((.name + ":" + .file + ":" + (.line|tostring) + ":" + (.column|tostring) + " " + (.count|tostring))) | .[]' before | sort > before.list
```
applying this patch, then:
```
$ NIX_SHOW_STATS=1 NIX_COUNT_CALLS=1 nix-instantiate ./pkgs/top-level/release.nix -A unstable > after 2>&1
$ jq -r '.functions | map((.name + ":" + .file + ":" + (.line|tostring) + ":" + (.column|tostring) + " " + (.count|tostring))) | .[]' after | sort > after.list
```
and then diffing before.list and after.list to get:
```
calls
- :/home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:4:1 7513
+ :/home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:4:1 154
- mutuallyExclusive:/home/grahamc/projects/github.com/NixOS/nixpkgs/lib/lists.nix:658:23 7513
+ mutuallyExclusive:/home/grahamc/projects/github.com/NixOS/nixpkgs/lib/lists.nix:658:23 154
- mutuallyExclusive:/home/grahamc/projects/github.com/NixOS/nixpkgs/lib/lists.nix:658:26 7513
+ mutuallyExclusive:/home/grahamc/projects/github.com/NixOS/nixpkgs/lib/lists.nix:658:26 154
- onlyLicenses:/home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:21:18 15026
+ onlyLicenses:/home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:21:18 308
```
The following information is from `NIX_SHOW_STATS=1 GC_INITIAL_HEAP_SIZE=4g nix-env -f ./outpaths.nix -qaP --no-name --out-path --arg checkMeta true`:
| stat | before | after | Δ | Δ% |
|:---------------------------|---------------:|---------------:|:----------------|--------:|
| **cpuTime** | 179.915 | 145.543 | 🡖 34.372 | -19.10% |
| **envs-bytes** | 3,900,878,824 | 3,599,483,208 | 🡖 301,395,616 | -7.73% |
| **envs-elements** | 214,426,071 | 185,881,709 | 🡖 28,544,362 | -13.31% |
| **envs-number** | 136,591,891 | 132,026,846 | 🡖 4,565,045 | -3.34% |
| **gc-heapSize** | 11,400,048,640 | 12,314,890,240 | 🡕 914,841,600 | 8.02% |
| **gc-totalBytes** | 25,976,902,560 | 24,510,740,176 | 🡖 1,466,162,384 | -5.64% |
| **list-bytes** | 1,665,290,080 | 1,665,290,080 | 0 | |
| **list-concats** | 7,264,417 | 7,264,417 | 0 | |
| **list-elements** | 208,161,260 | 208,161,260 | 0 | |
| **nrAvoided** | 191,359,386 | 179,693,661 | 🡖 11,665,725 | -6.10% |
| **nrFunctionCalls** | 119,665,062 | 116,348,547 | 🡖 3,316,515 | -2.77% |
| **nrLookups** | 80,996,257 | 76,069,825 | 🡖 4,926,432 | -6.08% |
| **nrOpUpdateValuesCopied** | 213,930,649 | 213,930,649 | 0 | |
| **nrOpUpdates** | 12,025,937 | 12,025,937 | 0 | |
| **nrPrimOpCalls** | 88,105,604 | 86,451,598 | 🡖 1,654,006 | -1.88% |
| **nrThunks** | 196,842,044 | 175,126,701 | 🡖 21,715,343 | -11.03% |
| **sets-bytes** | 7,678,425,776 | 7,285,767,928 | 🡖 392,657,848 | -5.11% |
| **sets-elements** | 310,241,340 | 294,373,227 | 🡖 15,868,113 | -5.11% |
| **sets-number** | 29,079,202 | 27,601,310 | 🡖 1,477,892 | -5.08% |
| **sizes-Attr** | 24 | 24 | 0 | |
| **sizes-Bindings** | 8 | 8 | 0 | |
| **sizes-Env** | 16 | 16 | 0 | |
| **sizes-Value** | 24 | 24 | 0 | |
| **symbols-bytes** | 16,474,666 | 16,474,676 | 🡕 10 | 0.00% |
| **symbols-number** | 376,426 | 376,427 | 🡕 1 | 0.00% |
| **values-bytes** | 6,856,506,288 | 6,316,585,560 | 🡖 539,920,728 | -7.87% |
| **values-number** | 285,687,762 | 263,191,065 | 🡖 22,496,697 | -7.87% |
The following information is from `NIX_SHOW_STATS=1 GC_INITIAL_HEAP_SIZE=4g nix-instantiate ./nixos/release-combined.nix -A tested`:
| stat | before | after | Δ | Δ% |
|:---------------------------|---------------:|---------------:|:----------------|-------:|
| **cpuTime** | 256.071 | 237.531 | 🡖 18.54 | -7.24% |
| **envs-bytes** | 7,111,004,192 | 7,041,478,520 | 🡖 69,525,672 | -0.98% |
| **envs-elements** | 346,236,940 | 339,588,487 | 🡖 6,648,453 | -1.92% |
| **envs-number** | 271,319,292 | 270,298,164 | 🡖 1,021,128 | -0.38% |
| **gc-heapSize** | 8,995,291,136 | 10,110,009,344 | 🡕 1,114,718,208 | 12.39% |
| **gc-totalBytes** | 37,172,737,408 | 36,878,391,888 | 🡖 294,345,520 | -0.79% |
| **list-bytes** | 1,886,162,656 | 1,886,163,472 | 🡕 816 | 0.00% |
| **list-concats** | 6,898,114 | 6,898,114 | 0 | |
| **list-elements** | 235,770,332 | 235,770,434 | 🡕 102 | 0.00% |
| **nrAvoided** | 328,829,821 | 326,618,157 | 🡖 2,211,664 | -0.67% |
| **nrFunctionCalls** | 240,850,845 | 239,998,495 | 🡖 852,350 | -0.35% |
| **nrLookups** | 144,849,632 | 142,126,339 | 🡖 2,723,293 | -1.88% |
| **nrOpUpdateValuesCopied** | 251,032,504 | 251,032,504 | 0 | |
| **nrOpUpdates** | 17,903,110 | 17,903,110 | 0 | |
| **nrPrimOpCalls** | 140,674,913 | 139,485,975 | 🡖 1,188,938 | -0.85% |
| **nrThunks** | 294,643,131 | 288,678,022 | 🡖 5,965,109 | -2.02% |
| **sets-bytes** | 9,464,322,192 | 9,456,172,048 | 🡖 8,150,144 | -0.09% |
| **sets-elements** | 377,474,889 | 377,134,877 | 🡖 340,012 | -0.09% |
| **sets-number** | 50,615,607 | 50,616,875 | 🡕 1,268 | 0.00% |
| **sizes-Attr** | 24 | 24 | 0 | |
| **sizes-Bindings** | 8 | 8 | 0 | |
| **sizes-Env** | 16 | 16 | 0 | |
| **sizes-Value** | 24 | 24 | 0 | |
| **symbols-bytes** | 3,147,102 | 3,147,064 | 🡖 38 | -0.00% |
| **symbols-number** | 82,819 | 82,819 | 0 | |
| **values-bytes** | 11,147,448,768 | 10,996,111,512 | 🡖 151,337,256 | -1.36% |
| **values-number** | 464,477,032 | 458,171,313 | 🡖 6,305,719 | -1.36% |
2019-04-11 17:35:35 +01:00
|
|
|
validity = checkMeta { inherit meta attrs; };
|
2017-12-25 17:38:45 +00:00
|
|
|
|
2017-07-05 22:56:53 +01:00
|
|
|
# The meta attribute is passed in the resulting attribute set,
|
|
|
|
# but it's not part of the actual derivation, i.e., it's not
|
|
|
|
# passed to the builder and is not a dependency. But since we
|
|
|
|
# include it in the result, it *is* available to nix-env for queries.
|
2018-01-02 14:52:27 +00:00
|
|
|
meta = {
|
2018-01-03 15:22:35 +00:00
|
|
|
# `name` above includes cross-compilation cruft (and is under assert),
|
|
|
|
# lets have a clean always accessible version here.
|
2019-02-01 15:59:12 +00:00
|
|
|
name = attrs.name or "${attrs.pname}-${attrs.version}";
|
2018-01-03 15:22:35 +00:00
|
|
|
|
2017-07-05 22:56:53 +01:00
|
|
|
# If the packager hasn't specified `outputsToInstall`, choose a default,
|
2020-01-01 18:53:39 +00:00
|
|
|
# which is the name of `p.bin or p.out or p` along with `p.man` when
|
|
|
|
# present.
|
|
|
|
#
|
|
|
|
# If the packager has specified it, it will be overridden below in
|
|
|
|
# `// meta`.
|
|
|
|
#
|
2017-07-05 22:56:53 +01:00
|
|
|
# Note: This default probably shouldn't be globally configurable.
|
|
|
|
# Services and users should specify outputs explicitly,
|
|
|
|
# unless they are comfortable with this default.
|
2018-01-02 14:52:27 +00:00
|
|
|
outputsToInstall =
|
|
|
|
let
|
2018-08-05 20:24:46 +01:00
|
|
|
hasOutput = out: builtins.elem out outputs;
|
2019-01-26 15:51:12 +00:00
|
|
|
in [( lib.findFirst hasOutput null (["bin" "out"] ++ outputs) )]
|
|
|
|
++ lib.optional (hasOutput "man") "man";
|
2017-07-05 22:56:53 +01:00
|
|
|
}
|
|
|
|
// attrs.meta or {}
|
2018-01-02 14:52:27 +00:00
|
|
|
# Fill `meta.position` to identify the source location of the package.
|
|
|
|
// lib.optionalAttrs (pos != null) {
|
|
|
|
position = pos.file + ":" + toString pos.line;
|
2018-01-02 14:52:27 +00:00
|
|
|
} // {
|
2020-04-19 11:04:58 +01:00
|
|
|
# Expose the result of the checks for everyone to see.
|
|
|
|
inherit (validity) unfree broken unsupported insecure;
|
2018-02-17 18:44:23 +00:00
|
|
|
available = validity.valid
|
2018-01-02 14:52:27 +00:00
|
|
|
&& (if config.checkMetaRecursively or false
|
2018-02-17 18:44:23 +00:00
|
|
|
then lib.all (d: d.meta.available or true) references
|
2018-01-02 14:52:27 +00:00
|
|
|
else true);
|
2018-01-02 14:52:27 +00:00
|
|
|
};
|
2017-07-05 22:56:53 +01:00
|
|
|
|
|
|
|
in
|
|
|
|
|
2017-12-25 17:38:45 +00:00
|
|
|
lib.extendDerivation
|
|
|
|
validity.handled
|
|
|
|
({
|
|
|
|
overrideAttrs = f: mkDerivation (attrs // (f attrs));
|
2020-08-15 22:11:20 +01:00
|
|
|
|
|
|
|
# A derivation that always builds successfully and whose runtime
|
|
|
|
# dependencies are the original derivations build time dependencies
|
|
|
|
# This allows easy building and distributing of all derivations
|
|
|
|
# needed to enter a nix-shell with
|
|
|
|
# nix-build shell.nix -A inputDerivation
|
|
|
|
inputDerivation = derivation (derivationArg // {
|
|
|
|
# Add a name in case the original drv didn't have one
|
|
|
|
name = derivationArg.name or "inputDerivation";
|
|
|
|
# This always only has one output
|
|
|
|
outputs = [ "out" ];
|
|
|
|
|
|
|
|
# Propagate the original builder and arguments, since we override
|
|
|
|
# them and they might contain references to build inputs
|
|
|
|
_derivation_original_builder = derivationArg.builder;
|
|
|
|
_derivation_original_args = derivationArg.args;
|
|
|
|
|
|
|
|
builder = stdenv.shell;
|
|
|
|
# The bash builtin `export` dumps all current environment variables,
|
|
|
|
# which is where all build input references end up (e.g. $PATH for
|
|
|
|
# binaries). By writing this to $out, Nix can find and register
|
|
|
|
# them as runtime dependencies (since Nix greps for store paths
|
|
|
|
# through $out to find them)
|
|
|
|
args = [ "-c" "export > $out" ];
|
|
|
|
});
|
|
|
|
|
2017-12-25 17:38:45 +00:00
|
|
|
inherit meta passthru;
|
|
|
|
} //
|
|
|
|
# Pass through extra attributes that are not inputs, but
|
|
|
|
# should be made available to Nix expressions using the
|
|
|
|
# derivation (e.g., in assertions).
|
|
|
|
passthru)
|
|
|
|
(derivation derivationArg);
|
|
|
|
|
2017-07-05 22:56:53 +01:00
|
|
|
}
|