nixpkgs/pkgs/applications/misc/appeditor/default.nix

{ lib, stdenv
, fetchFromGitHub
, nix-update-script
, vala
, meson
, ninja
, pkg-config
, pantheon
, python3
, gettext
, glib
, gtk3
, libgee
, wrapGAppsHook
}:

stdenv.mkDerivation rec {
  pname = "appeditor";
  version = "1.1.3";

  src = fetchFromGitHub {
    owner = "donadigo";
    repo = "appeditor";
    rev = version;
    sha256 = "sha256-0zutz1nnThyF7h44cDxjE53hhAJfJf6DTs9p4HflXr8=";
  };

  nativeBuildInputs = [
    gettext
    meson
    ninja
    vala
    pkg-config
    python3
    wrapGAppsHook
  ];

  buildInputs = [
    glib
    gtk3
    pantheon.granite
    libgee
  ];

  postPatch = ''
    # Fix build with vala 0.56
    # https://github.com/donadigo/appeditor/pull/122
    substituteInPlace src/Application.vala \
      --replace "private static string? create_exec_filename;" "public static string? create_exec_filename;"

    chmod +x meson/post_install.py
    patchShebangs meson/post_install.py
  '';

  passthru = {
    updateScript = nix-update-script {
      attrPath = pname;
    };
  };

  meta = with lib; {
    description = "Edit the Pantheon desktop application menu";
    homepage = "https://github.com/donadigo/appeditor";
    maintainers = with maintainers; [ xiorcale ] ++ teams.pantheon.members;
    platforms = platforms.linux;
    license = licenses.gpl3Plus;
    mainProgram = "com.github.donadigo.appeditor";
  };
}
treewide: with stdenv.lib; in meta -> with lib; Part of: https://github.com/NixOS/nixpkgs/issues/108938 meta = with stdenv.lib; is a widely used pattern. We want to slowly remove the `stdenv.lib` indirection and encourage people to use `lib` directly. Thus let’s start with the meta field. This used a rewriting script to mostly automatically replace all occurances of this pattern, and add the `lib` argument to the package header if it doesn’t exist yet. The script in its current form is available at https://cs.tvl.fyi/depot@2f807d7f141068d2d60676a89213eaa5353ca6e0/-/blob/users/Profpatsch/nixpkgs-rewriter/default.nix 2021-01-11 07:54:33 +00:00			`{ lib, stdenv`
appeditor: init at 1.1.0 appeditor: init at 1.1.0 appeditor: init at 1.1.0 2019-03-06 09:30:05 +00:00			`, fetchFromGitHub`
treewide: use nix-update updateScript for packages I maintain 2020-07-29 17:33:39 +01:00			`, nix-update-script`
pantheon: use latest vala elementary OS's ecosystem is curated around Ubuntu's LTS releases. This means the development platform for their curated applications always includes a LTS version of vala (in 18.04 it's 0.40). Because of how vala development works it suspect some of these applications to have serious issues if complied with the latest vala. However in the past year or so, for Pantheon at least, I don't think their applications will have much issues with latest vala, and if there is I don't think they'd be difficult to fix. In this single regard they've become more responsive since their preferred language is vala. As for the curated applications I have less of this confidence in. So I'd have to be accept less applications, but that's something I'm willing to compromise on. And this is easily reversible or could be done on a per-application basis. And nix already makes this trivial. 2019-10-10 03:47:37 +01:00			`, vala`
appeditor: init at 1.1.0 appeditor: init at 1.1.0 appeditor: init at 1.1.0 2019-03-06 09:30:05 +00:00			`, meson`
			`, ninja`
pkgs/applications: pkgconfig -> pkg-config 2021-01-17 02:09:27 +00:00			`, pkg-config`
appeditor: init at 1.1.0 appeditor: init at 1.1.0 appeditor: init at 1.1.0 2019-03-06 09:30:05 +00:00			`, pantheon`
			`, python3`
			`, gettext`
			`, glib`
			`, gtk3`
			`, libgee`
appeditor: 1.1.0 -> 1.1.1 2021-08-12 15:30:41 +01:00			`, wrapGAppsHook`
			`}:`
appeditor: init at 1.1.0 appeditor: init at 1.1.0 appeditor: init at 1.1.0 2019-03-06 09:30:05 +00:00
			`stdenv.mkDerivation rec {`
			`pname = "appeditor";`
appeditor: 1.1.1 -> 1.1.3 2021-12-20 00:35:13 +00:00			`version = "1.1.3";`
appeditor: init at 1.1.0 appeditor: init at 1.1.0 appeditor: init at 1.1.0 2019-03-06 09:30:05 +00:00
			`src = fetchFromGitHub {`
			`owner = "donadigo";`
			`repo = "appeditor";`
			`rev = version;`
appeditor: 1.1.1 -> 1.1.3 2021-12-20 00:35:13 +00:00			`sha256 = "sha256-0zutz1nnThyF7h44cDxjE53hhAJfJf6DTs9p4HflXr8=";`
appeditor: init at 1.1.0 appeditor: init at 1.1.0 appeditor: init at 1.1.0 2019-03-06 09:30:05 +00:00			`};`

			`nativeBuildInputs = [`
			`gettext`
			`meson`
			`ninja`
pantheon: use latest vala elementary OS's ecosystem is curated around Ubuntu's LTS releases. This means the development platform for their curated applications always includes a LTS version of vala (in 18.04 it's 0.40). Because of how vala development works it suspect some of these applications to have serious issues if complied with the latest vala. However in the past year or so, for Pantheon at least, I don't think their applications will have much issues with latest vala, and if there is I don't think they'd be difficult to fix. In this single regard they've become more responsive since their preferred language is vala. As for the curated applications I have less of this confidence in. So I'd have to be accept less applications, but that's something I'm willing to compromise on. And this is easily reversible or could be done on a per-application basis. And nix already makes this trivial. 2019-10-10 03:47:37 +01:00			`vala`
pkgs/applications: pkgconfig -> pkg-config 2021-01-17 02:09:27 +00:00			`pkg-config`
appeditor: init at 1.1.0 appeditor: init at 1.1.0 appeditor: init at 1.1.0 2019-03-06 09:30:05 +00:00			`python3`
			`wrapGAppsHook`
			`];`

			`buildInputs = [`
			`glib`
			`gtk3`
			`pantheon.granite`
			`libgee`
			`];`

			`postPatch = ''`
appeditor: fix build with vala 0.56 2022-03-19 08:48:16 +00:00			`# Fix build with vala 0.56`
			`# https://github.com/donadigo/appeditor/pull/122`
			`substituteInPlace src/Application.vala \`
			`--replace "private static string? create_exec_filename;" "public static string? create_exec_filename;"`

appeditor: init at 1.1.0 appeditor: init at 1.1.0 appeditor: init at 1.1.0 2019-03-06 09:30:05 +00:00			`chmod +x meson/post_install.py`
			`patchShebangs meson/post_install.py`
			`'';`

treewide: pantheon updateScript 2019-12-22 23:19:30 +00:00			`passthru = {`
treewide: use nix-update updateScript for packages I maintain 2020-07-29 17:33:39 +01:00			`updateScript = nix-update-script {`
treewide: pantheon updateScript 2019-12-22 23:19:30 +00:00			`attrPath = pname;`
			`};`
			`};`

treewide: with stdenv.lib; in meta -> with lib; Part of: https://github.com/NixOS/nixpkgs/issues/108938 meta = with stdenv.lib; is a widely used pattern. We want to slowly remove the `stdenv.lib` indirection and encourage people to use `lib` directly. Thus let’s start with the meta field. This used a rewriting script to mostly automatically replace all occurances of this pattern, and add the `lib` argument to the package header if it doesn’t exist yet. The script in its current form is available at https://cs.tvl.fyi/depot@2f807d7f141068d2d60676a89213eaa5353ca6e0/-/blob/users/Profpatsch/nixpkgs-rewriter/default.nix 2021-01-11 07:54:33 +00:00			`meta = with lib; {`
appeditor: init at 1.1.0 appeditor: init at 1.1.0 appeditor: init at 1.1.0 2019-03-06 09:30:05 +00:00			`description = "Edit the Pantheon desktop application menu";`
treewide: Per RFC45, remove all unquoted URLs 2020-04-01 02:11:51 +01:00			`homepage = "https://github.com/donadigo/appeditor";`
treewide: switch from pantheon.maintainers to lib.teams.pantheon 2021-09-18 16:00:51 +01:00			`maintainers = with maintainers; [ xiorcale ] ++ teams.pantheon.members;`
appeditor: init at 1.1.0 appeditor: init at 1.1.0 appeditor: init at 1.1.0 2019-03-06 09:30:05 +00:00			`platforms = platforms.linux;`
appeditor: 1.1.0 -> 1.1.1 2021-08-12 15:30:41 +01:00			`license = licenses.gpl3Plus;`
treewide: set meta.mainProgram for packages teams.pantheon.members maintain 2021-11-03 10:27:38 +00:00			`mainProgram = "com.github.donadigo.appeditor";`
appeditor: init at 1.1.0 appeditor: init at 1.1.0 appeditor: init at 1.1.0 2019-03-06 09:30:05 +00:00			`};`
			`}`