JakeHillion/drgn
1
0
Fork 0
mirror of https://github.com/JakeHillion/drgn.git synced 2024-12-23 09:43:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

libdrgn: fix note name matching

Browse Source 
The current code matches the desired note name as a prefix, but we need
an exact match.

Fixes: 75c3679147 ("Rewrite drgn core in C")
Signed-off-by: Omar Sandoval <osandov@osandov.com>
This commit is contained in:
Omar Sandoval 2021-12-03 12:01:15 -08:00
parent 0e318754fe
commit 91f6d03ee8
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libdrgn/program.c
View File

@ -293,11 +293,13 @@ drgn_program_set_core_dump(struct drgn_program *prog, const char *path)
name = (char *)data->d_buf + name_offset; name = (char *)data->d_buf + name_offset;
desc = (char *)data->d_buf + desc_offset; desc = (char *)data->d_buf + desc_offset;
if (strncmp(name, "CORE", nhdr.n_namesz) == 0) { if (nhdr.n_namesz == sizeof("CORE") &&
memcmp(name, "CORE", sizeof("CORE")) == 0) {
if (nhdr.n_type == NT_TASKSTRUCT) if (nhdr.n_type == NT_TASKSTRUCT)
have_nt_taskstruct = true; have_nt_taskstruct = true;
} else if (strncmp(name, "VMCOREINFO", } else if (nhdr.n_namesz == sizeof("VMCOREINFO") &&
nhdr.n_namesz) == 0) { memcmp(name, "VMCOREINFO",
sizeof("VMCOREINFO")) == 0) {
vmcoreinfo_note = desc; vmcoreinfo_note = desc;
vmcoreinfo_size = nhdr.n_descsz; vmcoreinfo_size = nhdr.n_descsz;
/* /*