JakeHillion/drgn
1
0
Fork 0
mirror of https://github.com/JakeHillion/drgn.git synced 2024-12-22 09:13:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

libdrgn: dwarf_info: don't call dwarf_dieoffset() redundantly

Browse Source 
When we get the DIE from the offset with dwarf_offdie(), there's no need
to go back to the offset with dwarf_dieoffset().

Signed-off-by: Omar Sandoval <osandov@osandov.com>
This commit is contained in:
Omar Sandoval 2023-07-06 11:56:34 -07:00
parent b5018aa913
commit 916a7217fb
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
libdrgn/dwarf_info.c
View File

@ -3314,17 +3314,15 @@ next_unit:;
it->debug_types ? &type_signature : NULL, NULL);
if (r == 0) {
/* Got the next unit. Return the unit DIE. */
if (it->debug_types) {
r = !dwarf_offdie_types(it->dwarf,
cu_off + cu_header_size, TOP());
} else {
r = !dwarf_offdie(it->dwarf, cu_off + cu_header_size,
TOP());
}
Dwarf_Off offset = cu_off + cu_header_size;
if (it->debug_types)
r = !dwarf_offdie_types(it->dwarf, offset, TOP());
else
r = !dwarf_offdie(it->dwarf, offset, TOP());
if (r)
return drgn_error_libdw();
it->cu_end = ((const char *)TOP()->addr
- dwarf_dieoffset(TOP())
- offset
+ it->next_cu_off);
return NULL;
} else if (r > 0) {
@ -3387,7 +3385,7 @@ struct drgn_error *drgn_module_find_dwarf_scopes(struct drgn_module *module,
goto err;
}
it.cu_end = ((const char *)cu_die->addr
- dwarf_dieoffset(cu_die)
- offset
+ it.next_cu_off);
subtree = 1;
} else {